Merge pull request #42 from eksrvb/bugfix/fix-comment-permission

eksrha · web-flow · commit 4ec0ebc46e18 · 2021-07-26T09:29:51.000+02:00
fix comment permission check
diff --git a/service/getBuildInfos.go b/service/getBuildInfos.go
@@ -144,7 +144,7 @@ func detectIfMajor(issueNumber int) bool {
 	for _, comment := range issueComments {
 		// Must have permission in the repo to create a major version
 		// MANNEQUIN|NONE https://docs.github.com/en/graphql/reference/enums#commentauthorassociation
-		if strings.Contains(comment.Body, "aci=major") && strings.Contains("MANNEQUIN|NONE", comment.AuthorAssociation) {
+		if strings.Contains(comment.Body, "aci=major") && !strings.Contains("MANNEQUIN|NONE", comment.AuthorAssociation) {
 			resBool = true
 			break
 		}

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ func detectIfMajor(issueNumber int) bool {`
`144`	`144`	`for _, comment := range issueComments {`
`145`	`145`	`// Must have permission in the repo to create a major version`
`146`	`146`	`// MANNEQUIN\|NONE https://docs.github.com/en/graphql/reference/enums#commentauthorassociation`
`147`		`- if strings.Contains(comment.Body, "aci=major") && strings.Contains("MANNEQUIN\|NONE", comment.AuthorAssociation) {`
	`147`	`+ if strings.Contains(comment.Body, "aci=major") && !strings.Contains("MANNEQUIN\|NONE", comment.AuthorAssociation) {`
`148`	`148`	`resBool = true`
`149`	`149`	`break`
`150`	`150`	`}`