fix: endless for loop at github GetLatestReleaseVersion() (#126)

eksrha · web-flow · commit 69d723c366e9 · 2023-01-16T17:08:26.000+01:00
diff --git a/docs/cmd/awesome-ci.md b/docs/cmd/awesome-ci.md
@@ -2,7 +2,6 @@
 layout: default
 nav_order: 2
 parent: CLI
-date: 2023-01-12T14:07:16Z
 title: "awesome-ci"
 ---
 ## awesome-ci
@@ -34,4 +33,4 @@ awesome-ci [flags]
 * [awesome-ci release](/commands/awesome-ci_release/)	 - release
 * [awesome-ci version](/commands/awesome-ci_version/)	 - Print the version number of Awesome-CI
 
-###### Auto generated by spf13/cobra on 12-Jan-2023
+###### Auto generated by spf13/cobra on 16-Jan-2023
diff --git a/docs/cmd/awesome-ci_connect.md b/docs/cmd/awesome-ci_connect.md
@@ -2,7 +2,6 @@
 layout: default
 nav_order: 2
 parent: CLI
-date: 2023-01-12T14:07:16Z
 title: " connect"
 ---
 ## awesome-ci connect
@@ -38,4 +37,4 @@ awesome-ci connect [flags]
 * [awesome-ci connect github](/commands/awesome-ci_connect_github/)	 - connect initial to a GitHub or GitHub Enterprise
 * [awesome-ci connect remove](/commands/awesome-ci_connect_remove/)	 - remove all connection files and secrets
 
-###### Auto generated by spf13/cobra on 12-Jan-2023
+###### Auto generated by spf13/cobra on 16-Jan-2023
diff --git a/docs/cmd/awesome-ci_connect_check.md b/docs/cmd/awesome-ci_connect_check.md
@@ -2,7 +2,6 @@
 layout: default
 nav_order: 2
 parent: CLI
-date: 2023-01-12T14:07:16Z
 title: " connect check"
 ---
 ## awesome-ci connect check
@@ -29,4 +28,4 @@ awesome-ci connect check [flags]
 
 * [awesome-ci connect](/commands/awesome-ci_connect/)	 - connect persistent to github by creating an encrypted rc file
 
-###### Auto generated by spf13/cobra on 12-Jan-2023
+###### Auto generated by spf13/cobra on 16-Jan-2023
diff --git a/docs/cmd/awesome-ci_connect_github.md b/docs/cmd/awesome-ci_connect_github.md
@@ -2,7 +2,6 @@
 layout: default
 nav_order: 2
 parent: CLI
-date: 2023-01-12T14:07:16Z
 title: " connect github"
 ---
 ## awesome-ci connect github
@@ -32,4 +31,4 @@ awesome-ci connect github [flags]
 
 * [awesome-ci connect](/commands/awesome-ci_connect/)	 - connect persistent to github by creating an encrypted rc file
 
-###### Auto generated by spf13/cobra on 12-Jan-2023
+###### Auto generated by spf13/cobra on 16-Jan-2023
diff --git a/docs/cmd/awesome-ci_connect_remove.md b/docs/cmd/awesome-ci_connect_remove.md
@@ -2,7 +2,6 @@
 layout: default
 nav_order: 2
 parent: CLI
-date: 2023-01-12T14:07:16Z
 title: " connect remove"
 ---
 ## awesome-ci connect remove
@@ -29,4 +28,4 @@ awesome-ci connect remove [flags]
 
 * [awesome-ci connect](/commands/awesome-ci_connect/)	 - connect persistent to github by creating an encrypted rc file
 
-###### Auto generated by spf13/cobra on 12-Jan-2023
+###### Auto generated by spf13/cobra on 16-Jan-2023
diff --git a/docs/cmd/awesome-ci_parse.md b/docs/cmd/awesome-ci_parse.md
@@ -2,7 +2,6 @@
 layout: default
 nav_order: 2
 parent: CLI
-date: 2023-01-12T14:07:16Z
 title: " parse"
 ---
 ## awesome-ci parse
@@ -38,4 +37,4 @@ awesome-ci parse [flags]
 * [awesome-ci parse json](/commands/awesome-ci_parse_json/)	 - parse a json string or file
 * [awesome-ci parse yaml](/commands/awesome-ci_parse_yaml/)	 - parse a yaml string or file
 
-###### Auto generated by spf13/cobra on 12-Jan-2023
+###### Auto generated by spf13/cobra on 16-Jan-2023
diff --git a/docs/cmd/awesome-ci_parse_json.md b/docs/cmd/awesome-ci_parse_json.md
@@ -2,7 +2,6 @@
 layout: default
 nav_order: 2
 parent: CLI
-date: 2023-01-12T14:07:16Z
 title: " parse json"
 ---
 ## awesome-ci parse json
@@ -32,4 +31,4 @@ awesome-ci parse json [flags]
 
 * [awesome-ci parse](/commands/awesome-ci_parse/)	 - parse json and yaml files and inspect values like jq
 
-###### Auto generated by spf13/cobra on 12-Jan-2023
+###### Auto generated by spf13/cobra on 16-Jan-2023
diff --git a/docs/cmd/awesome-ci_parse_yaml.md b/docs/cmd/awesome-ci_parse_yaml.md
@@ -2,7 +2,6 @@
 layout: default
 nav_order: 2
 parent: CLI
-date: 2023-01-12T14:07:16Z
 title: " parse yaml"
 ---
 ## awesome-ci parse yaml
@@ -32,4 +31,4 @@ awesome-ci parse yaml [flags]
 
 * [awesome-ci parse](/commands/awesome-ci_parse/)	 - parse json and yaml files and inspect values like jq
 
-###### Auto generated by spf13/cobra on 12-Jan-2023
+###### Auto generated by spf13/cobra on 16-Jan-2023
diff --git a/docs/cmd/awesome-ci_pr.md b/docs/cmd/awesome-ci_pr.md
@@ -2,7 +2,6 @@
 layout: default
 nav_order: 2
 parent: CLI
-date: 2023-01-12T14:07:16Z
 title: " pr"
 ---
 ## awesome-ci pr
@@ -34,4 +33,4 @@ awesome-ci pr [flags]
 * [awesome-ci](/commands/awesome-ci/)	 - Awesome CI make your release tagging easy
 * [awesome-ci pr info](/commands/awesome-ci_pr_info/)	 - get pull request info
 
-###### Auto generated by spf13/cobra on 12-Jan-2023
+###### Auto generated by spf13/cobra on 16-Jan-2023
diff --git a/docs/cmd/awesome-ci_pr_info.md b/docs/cmd/awesome-ci_pr_info.md
@@ -2,7 +2,6 @@
 layout: default
 nav_order: 2
 parent: CLI
-date: 2023-01-12T14:07:16Z
 title: " pr info"
 ---
 ## awesome-ci pr info
@@ -20,8 +19,9 @@ awesome-ci pr info [flags]
 ### Options
 
 ```
-  -h, --help         help for info
-  -n, --number int   overwrite the issue number
+  -h, --help                      help for info
+  -c, --merge-commit-sha string   send a given merge commit sha
+  -n, --number int                overwrite the issue number
 ```
 
 ### Options inherited from parent commands
@@ -34,4 +34,4 @@ awesome-ci pr info [flags]
 
 * [awesome-ci pr](/commands/awesome-ci_pr/)	 - pull request
 
-###### Auto generated by spf13/cobra on 12-Jan-2023
+###### Auto generated by spf13/cobra on 16-Jan-2023
diff --git a/docs/cmd/awesome-ci_release.md b/docs/cmd/awesome-ci_release.md
@@ -2,7 +2,6 @@
 layout: default
 nav_order: 2
 parent: CLI
-date: 2023-01-12T14:07:16Z
 title: " release"
 ---
 ## awesome-ci release
@@ -43,4 +42,4 @@ awesome-ci release [flags]
 * [awesome-ci release create](/commands/awesome-ci_release_create/)	 - create a GitHub release
 * [awesome-ci release publish](/commands/awesome-ci_release_publish/)	 - publish a GitHub release
 
-###### Auto generated by spf13/cobra on 12-Jan-2023
+###### Auto generated by spf13/cobra on 16-Jan-2023
diff --git a/docs/cmd/awesome-ci_release_create.md b/docs/cmd/awesome-ci_release_create.md
@@ -2,7 +2,6 @@
 layout: default
 nav_order: 2
 parent: CLI
-date: 2023-01-12T14:07:16Z
 title: " release create"
 ---
 ## awesome-ci release create
@@ -41,4 +40,4 @@ awesome-ci release create [flags]
 
 * [awesome-ci release](/commands/awesome-ci_release/)	 - release
 
-###### Auto generated by spf13/cobra on 12-Jan-2023
+###### Auto generated by spf13/cobra on 16-Jan-2023
diff --git a/docs/cmd/awesome-ci_release_publish.md b/docs/cmd/awesome-ci_release_publish.md
@@ -2,7 +2,6 @@
 layout: default
 nav_order: 2
 parent: CLI
-date: 2023-01-12T14:07:16Z
 title: " release publish"
 ---
 ## awesome-ci release publish
@@ -43,4 +42,4 @@ awesome-ci release publish [flags]
 
 * [awesome-ci release](/commands/awesome-ci_release/)	 - release
 
-###### Auto generated by spf13/cobra on 12-Jan-2023
+###### Auto generated by spf13/cobra on 16-Jan-2023
diff --git a/docs/cmd/awesome-ci_version.md b/docs/cmd/awesome-ci_version.md
@@ -2,7 +2,6 @@
 layout: default
 nav_order: 2
 parent: CLI
-date: 2023-01-12T14:07:16Z
 title: " version"
 ---
 ## awesome-ci version
@@ -33,4 +32,4 @@ awesome-ci version [flags]
 
 * [awesome-ci](/commands/awesome-ci/)	 - Awesome CI make your release tagging easy
 
-###### Auto generated by spf13/cobra on 12-Jan-2023
+###### Auto generated by spf13/cobra on 16-Jan-2023
diff --git a/internal/app/awesome-ci/scm-portal/github/release.go b/internal/app/awesome-ci/scm-portal/github/release.go
@@ -114,38 +114,45 @@ func (ghrc *GitHubRichClient) PublishRelease(
 // GetLatestReleaseVersion
 func (ghrc *GitHubRichClient) GetLatestReleaseVersion() (latestRelease *github.RepositoryRelease, err error) {
 	var releaseMap = make(map[string]*github.RepositoryRelease)
-
-	var listOptions github.ListOptions = github.ListOptions{
-		PerPage: 100,
-		Page:    0,
-	}
-
-	for listOptions.Page >= 0 {
-		releases, response, err := ghrc.Client.Repositories.ListReleases(ctx, ghrc.Owner, ghrc.Repository, &listOptions)
-
+	var loadReleasesFromRepo func(page int)
+
+	loadReleasesFromRepo = func(page int) {
+		log.Tracef("querying release page %d", page)
+		releases, response, err := ghrc.Client.Repositories.ListReleases(ctx, ghrc.Owner, ghrc.Repository, &github.ListOptions{
+			PerPage: 100,
+			Page:    page,
+		})
 		if err != nil {
-			return nil, err
+			log.Fatalf("error at loading repos from emst: %v", err)
 		}
 
+		log.Tracef("found %d releases at page %d begin with mapping...", len(releases), page)
 		for _, release := range releases {
 			releaseMap[*release.TagName] = release
 		}
 
-		if listOptions.Page == response.NextPage {
-			break
+		log.Traceln("####### next page:", response.NextPage)
+		if response.NextPage == 0 {
+			log.Traceln("ended with paging through releases")
+			return
+		} else {
+			loadReleasesFromRepo(page + 1)
 		}
-
-		listOptions.Page = response.NextPage
 	}
 
+	// starting recusive function
+	loadReleasesFromRepo(1)
+
 	return ghrc.findLatestRelease(`.`, releaseMap)
 }
 
 func (ghrc *GitHubRichClient) findLatestRelease(directory string, githubReleaseMap map[string]*github.RepositoryRelease) (latestRelease *github.RepositoryRelease, err error) {
+	log.Traceln("open local git repository...")
 	gitRepo, err := git.PlainOpen(directory)
 	if err != nil {
 		return nil, err
 	}
+	log.Traceln("...opened local git repository")
 
 	tags, err := tools.GetGitTagsUpToHead(gitRepo)
 
diff --git a/internal/app/awesome-ci/scm-portal/github/root.go b/internal/app/awesome-ci/scm-portal/github/root.go
@@ -40,7 +40,10 @@ func NewGitHubClient(serverUrl *string, repoUrl *string, token *string) (githubR
 	}
 
 	if rateLimit, _, err := githubClient.RateLimits(context.Background()); err != nil {
-		return nil, fmt.Errorf("connection to GitHub could not be etablished: %v", err)
+		if !strings.Contains(fmt.Sprintf("%v", err), "404 Rate limiting is not enabled") {
+			log.Traceln("rate limiting is not enabled, but connection is good")
+			return nil, fmt.Errorf("connection to GitHub could not be etablished: %v", err)
+		}
 	} else {
 		log.Tracef("remaining rates %d", rateLimit.Core.Remaining)
 	}
diff --git a/internal/app/awesome-ci/scm-portal/prmr_request.go b/internal/app/awesome-ci/scm-portal/prmr_request.go
@@ -23,6 +23,7 @@ func (lay SCMLayer) GetPrInfos(number int, mergeCommitSha string) (infos *PrMrRe
 		if err != nil {
 			return nil, err
 		}
+		log.Traceln("got PR information from scm-portal-layer")
 
 		infos.Number = *prInfos.Number
 		infos.Sha = *prInfos.Head.SHA
@@ -35,29 +36,36 @@ func (lay SCMLayer) GetPrInfos(number int, mergeCommitSha string) (infos *PrMrRe
 		if infos.PatchLevel, err = semver.ParsePatchLevelFormBranch(infos.BranchName); err != nil {
 			log.Warnln(err)
 		}
+		log.Traceln("completed PR standard information to: ", *infos)
 
 	case *gitlab.GitLabRichClient:
 		// not implemented
 		log.Warnln("gitlab is not yet implemented")
 	}
 
 	// 2. comment help instructions to issue
+	log.Traceln("comment help instructions to issue")
 	if errCommHelp := lay.CommentHelpToPullRequest(infos.Number); errCommHelp != nil {
 		log.Warnln(errCommHelp)
 	}
+	log.Traceln("commented help instructions to issue")
 
 	// 3. read comments from pr/mr and looking for overrides
+	log.Traceln("read comments from pr/mr and looking for overrides")
 	version, patchLevel, err := lay.SearchIssuesForOverrides(infos.Number)
 	if err != nil {
 		return nil, err
 	}
+	log.Tracef("read comments from pr/mr complete conclusions (if nil no override), version: %v, patchLevel: %v", version, patchLevel)
 
 	// get latest release, if any
+	log.Traceln("get latest release, if any")
 	repositoryRelease, err := lay.GetLatestReleaseVersion()
 	if err != nil {
 		log.Infoln("no github release found -> wirting default 0.0.0")
 		infos.LatestVersion = "0.0.0"
 	} else {
+		log.Infoln("found latest release", repositoryRelease.TagName)
 		infos.LatestVersion = repositoryRelease.TagName
 	}
 
diff --git a/internal/app/awesome-ci/service/release.go b/internal/app/awesome-ci/service/release.go
@@ -81,13 +81,20 @@ func ReleaseCreate(args *ReleaseArgs) {
 
 	if args.DryRun {
 		log.Infof("Would create new release with version: %s\n", version)
+
+		fmt.Println("### Info output:")
+		fmt.Printf("Would create new release with version: %s\n", version)
 	} else {
 		log.Infof("Writing new release: %s\n", version)
+		fmt.Println("### Info output:")
+		fmt.Printf("Writing new release with version: %s\n", version)
+
 		createdRelease, err := scmLayer.CreateRelease(version, args.ReleaseBranch, args.Body)
 		if err != nil {
 			log.Fatalln(err)
 		}
 		log.Infof("Create release successful. ID: %d", createdRelease.ID)
+		fmt.Printf("Create release successful. ID: %d", createdRelease.ID)
 
 		var envVars []ces.KeyValue = []ces.KeyValue{
 			{Name: "ACI_RELEASE_ID", Value: fmt.Sprintf("%d", createdRelease.ID)},
