do not query unassesary (#159)

Author: eksrha

go.mod

@@ -1,59 +1,59 @@
 module github.com/fullstack-devops/awesome-ci
 
-go 1.20
+go 1.21
 
 require (
 	github.com/coreos/go-semver v0.3.1
 	github.com/ghodss/yaml v1.0.0
-	github.com/go-git/go-git/v5 v5.7.0
-	github.com/google/go-github/v53 v53.2.0
+	github.com/go-git/go-git/v5 v5.10.0
+	github.com/google/go-github/v56 v56.0.0
 	github.com/itchyny/gojq v0.12.13
-	github.com/spf13/cobra v1.7.0
-	github.com/xanzy/go-gitlab v0.86.0
-	golang.org/x/oauth2 v0.10.0
+	github.com/spf13/cobra v1.8.0
+	github.com/xanzy/go-gitlab v0.93.2
+	golang.org/x/oauth2 v0.13.0
 	gopkg.in/yaml.v2 v2.4.0
 )
 
 require (
-	github.com/cpuguy83/go-md2man/v2 v2.0.2 // indirect
+	dario.cat/mergo v1.0.0 // indirect
+	github.com/cpuguy83/go-md2man/v2 v2.0.3 // indirect
+	github.com/cyphar/filepath-securejoin v0.2.4 // indirect
 	github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
 	github.com/inconshreveable/mousetrap v1.1.0 // indirect
 	github.com/itchyny/timefmt-go v0.1.5 // indirect
-	github.com/kr/pretty v0.3.1 // indirect
 	github.com/russross/blackfriday/v2 v2.1.0 // indirect
 	github.com/spf13/pflag v1.0.5 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )
 
 require (
 	github.com/Microsoft/go-winio v0.6.1 // indirect
-	github.com/ProtonMail/go-crypto v0.0.0-20230626094100-7e9e0395ebec // indirect
+	github.com/ProtonMail/go-crypto v0.0.0-20230923063757-afb1ddc0824c // indirect
 	github.com/acomagu/bufpipe v1.0.4 // indirect
-	github.com/cloudflare/circl v1.3.3 // indirect
+	github.com/cloudflare/circl v1.3.6 // indirect
 	github.com/emirpasic/gods v1.18.1 // indirect
 	github.com/go-git/gcfg v1.5.1-0.20230307220236-3a3c6141e376 // indirect
-	github.com/go-git/go-billy/v5 v5.4.1 // indirect
+	github.com/go-git/go-billy/v5 v5.5.0 // indirect
 	github.com/golang/protobuf v1.5.3 // indirect
 	github.com/google/go-querystring v1.1.0 // indirect
 	github.com/hashicorp/go-cleanhttp v0.5.2 // indirect
 	github.com/hashicorp/go-hclog v1.4.0 // indirect
 	github.com/hashicorp/go-retryablehttp v0.7.4 // indirect
-	github.com/imdario/mergo v0.3.16 // indirect
 	github.com/jbenet/go-context v0.0.0-20150711004518-d14ea06fba99 // indirect
 	github.com/kevinburke/ssh_config v1.2.0 // indirect
 	github.com/mattn/go-colorable v0.1.13 // indirect
 	github.com/pjbgf/sha1cd v0.3.0 // indirect
 	github.com/sergi/go-diff v1.3.1 // indirect
 	github.com/sirupsen/logrus v1.9.3
-	github.com/skeema/knownhosts v1.1.1 // indirect
+	github.com/skeema/knownhosts v1.2.1 // indirect
 	github.com/xanzy/ssh-agent v0.3.3 // indirect
-	golang.org/x/crypto v0.11.0 // indirect
-	golang.org/x/mod v0.12.0 // indirect
-	golang.org/x/net v0.12.0 // indirect
-	golang.org/x/sys v0.10.0 // indirect
-	golang.org/x/time v0.3.0 // indirect
-	golang.org/x/tools v0.11.0 // indirect
-	google.golang.org/appengine v1.6.7 // indirect
+	golang.org/x/crypto v0.14.0 // indirect
+	golang.org/x/mod v0.14.0 // indirect
+	golang.org/x/net v0.17.0 // indirect
+	golang.org/x/sys v0.14.0 // indirect
+	golang.org/x/time v0.4.0 // indirect
+	golang.org/x/tools v0.14.0 // indirect
+	google.golang.org/appengine v1.6.8 // indirect
 	google.golang.org/protobuf v1.31.0 // indirect
 	gopkg.in/warnings.v0 v0.1.2 // indirect
 )

go.sum

@@ -8,7 +8,7 @@ import (
 	"github.com/fullstack-devops/awesome-ci/internal/pkg/semver"
 	log "github.com/sirupsen/logrus"
 
-	"github.com/google/go-github/v53/github"
+	"github.com/google/go-github/v56/github"
 )
 
 var (
@@ -90,7 +90,8 @@ func (ghrc *GitHubRichClient) CommentHelpToPullRequest(number int) (err error) {
 	return
 }
 
-func (ghrc *GitHubRichClient) SearchIssuesForOverrides(prNumber int) (nextVersion string, patchLevel semver.PatchLevel, err error) {
+func (ghrc *GitHubRichClient) SearchIssuesForOverrides(prNumber int) (nextVersion *string, patchLevel *semver.PatchLevel, err error) {
+	var pLevel semver.PatchLevel
 	// if an comment exists with aci_patch_level=major, make a major version!
 	issueComments, err := ghrc.GetIssueComments(prNumber)
 	if err != nil {
@@ -115,17 +116,18 @@ func (ghrc *GitHubRichClient) SearchIssuesForOverrides(prNumber int) (nextVersio
 			aciPatchLevel := regexp.MustCompile(`^aci_patch_level: ([a-zA-Z]+)`)
 
 			if aciVersionOverride.MatchString(*comment.Body) {
-				nextVersion = aciVersionOverride.FindStringSubmatch(*comment.Body)[1]
+				nextVersion = &aciVersionOverride.FindStringSubmatch(*comment.Body)[1]
 				log.Infof("found version override in comment form %s at %s", comment.User.GetLogin(), comment.GetCreatedAt())
 				break
 			}
 
 			if aciPatchLevel.MatchString(*comment.Body) {
-				patchLevel, err = semver.ParsePatchLevel(aciPatchLevel.FindStringSubmatch(*comment.Body)[1])
+				pLevel, err = semver.ParsePatchLevel(aciPatchLevel.FindStringSubmatch(*comment.Body)[1])
 				if err != nil && err != semver.ErrUseMinimalPatchVersion {
 					log.Warnln(err)
 				}
 				log.Infof("found patchLevel override in comment form %s at %s", comment.User.GetLogin(), comment.GetCreatedAt())
+				patchLevel = &pLevel
 				break
 			}
 		}

internal/app/awesome-ci/scm-portal/github/issues.go

@@ -1,6 +1,6 @@
 package github
 
-import "github.com/google/go-github/v53/github"
+import "github.com/google/go-github/v56/github"
 
 type GitHubRichClient struct {
 	Client     *github.Client

internal/app/awesome-ci/scm-portal/github/models.go

@@ -3,7 +3,7 @@ package github
 import (
 	"fmt"
 
-	"github.com/google/go-github/v53/github"
+	"github.com/google/go-github/v56/github"
 	log "github.com/sirupsen/logrus"
 )
 

internal/app/awesome-ci/scm-portal/github/pullrequest.go

@@ -8,7 +8,7 @@ import (
 	"github.com/fullstack-devops/awesome-ci/internal/pkg/tools"
 
 	"github.com/go-git/go-git/v5"
-	"github.com/google/go-github/v53/github"
+	"github.com/google/go-github/v56/github"
 	log "github.com/sirupsen/logrus"
 )
 
@@ -129,7 +129,7 @@ func (ghrc *GitHubRichClient) GetLatestReleaseVersion() (latestRelease *github.R
 			Page:    page,
 		})
 		if err != nil {
-			log.Fatalf("error at loading repos from emst: %v", err)
+			log.Fatalf("error at loading repos from: %v", err)
 		}
 
 		log.Tracef("found %d releases at page %d begin with mapping...", len(releases), page)

internal/app/awesome-ci/scm-portal/github/release.go

@@ -7,7 +7,7 @@ import (
 
 	"github.com/fullstack-devops/awesome-ci/internal/pkg/tools"
 
-	"github.com/google/go-github/v53/github"
+	"github.com/google/go-github/v56/github"
 	log "github.com/sirupsen/logrus"
 	"golang.org/x/oauth2"
 )

internal/app/awesome-ci/scm-portal/github/root.go

@@ -9,13 +9,11 @@ import (
 )
 
 func (lay SCMLayer) SearchIssuesForOverrides(number int) (nextVersion *string, patchLevel *semver.PatchLevel, err error) {
-	var nVersion string
-	var pLevel semver.PatchLevel
 
 	switch grc := lay.Grc.(type) {
 
 	case *github.GitHubRichClient:
-		nVersion, pLevel, err = grc.SearchIssuesForOverrides(number)
+		nextVersion, patchLevel, err = grc.SearchIssuesForOverrides(number)
 		if err != nil {
 			return nil, nil, err
 		}
@@ -25,16 +23,5 @@ func (lay SCMLayer) SearchIssuesForOverrides(number int) (nextVersion *string, p
 		log.Warnln("gitlab is not yet implemented")
 	}
 
-	if nVersion == "" {
-		nextVersion = nil
-	} else {
-		nextVersion = &nVersion
-	}
-	if pLevel == "" {
-		patchLevel = nil
-	} else {
-		patchLevel = &pLevel
-	}
-
 	return
 }

internal/app/awesome-ci/scm-portal/issues.go

@@ -58,19 +58,18 @@ func (lay SCMLayer) GetPrInfos(number int, mergeCommitSha string) (infos *PrMrRe
 	}
 	log.Tracef("read comments from pr/mr complete conclusions (if nil no override), version: %v, patchLevel: %v", version, patchLevel)
 
-	// get latest release, if any
-	log.Traceln("get latest release, if any")
-	repositoryRelease, err := lay.GetLatestReleaseVersion()
-	if err != nil {
-		log.Infoln("no github release found -> wirting default 0.0.0")
-		infos.LatestVersion = "0.0.0"
-	} else {
-		log.Infoln("found latest release", repositoryRelease.TagName)
-		infos.LatestVersion = repositoryRelease.TagName
-	}
-
 	// check if version override (3)
 	if version == nil {
+		// get latest release, if any
+		log.Traceln("get latest release, if any")
+		repositoryRelease, err := lay.GetLatestReleaseVersion()
+		if err != nil {
+			log.Infoln("no github release found -> writing default 0.0.0")
+			infos.LatestVersion = "0.0.0"
+		} else {
+			log.Infoln("found latest release", repositoryRelease.TagName)
+			infos.LatestVersion = repositoryRelease.TagName
+		}
 
 		if patchLevel != nil {
 			infos.PatchLevel = *patchLevel

internal/app/awesome-ci/scm-portal/prmr_request.go

@@ -17,7 +17,7 @@ import (
 	"github.com/go-git/go-git/v5"
 	"github.com/go-git/go-git/v5/plumbing"
 	"github.com/go-git/go-git/v5/plumbing/transport/http"
-	"github.com/google/go-github/v53/github"
+	"github.com/google/go-github/v56/github"
 )
 
 type TestEnvironment struct {