Skip to content

Commit f069808

Browse files
authored
Merge pull request #16 from fullstack-devops/bugfix/merge-ui-frame-to-one-module
merged fs-frame to one module
2 parents 255d9b8 + 49298a7 commit f069808

21 files changed

+88
-108
lines changed

projects/lib-workspace/src/app/app.module.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@ import {
1414
FsCalendarModule,
1515
FsCalendarService,
1616
FsMaterialFullModule,
17-
FsUiFrameContentModule,
1817
FsUiFrameModule,
19-
FsUiFrameToolbarModule,
2018
} from 'projects/ng-mat-components/src/public-api';
2119
import { CalendarTableComponent } from './content/calendar-table/calendar-table.component';
2220
import { HomeComponent } from './content/home/home.component';
@@ -41,8 +39,6 @@ import { TestComponent } from './content/test/test.component';
4139
/* Lib modules */
4240
FsMaterialFullModule,
4341
FsUiFrameModule,
44-
FsUiFrameContentModule,
45-
FsUiFrameToolbarModule,
4642
FsCalendarModule,
4743
],
4844
providers: [

projects/ng-mat-components/src/lib/fs-ui-frame-content/fs-ui-frame-content.module.ts

Lines changed: 0 additions & 12 deletions
This file was deleted.

projects/ng-mat-components/src/lib/fs-ui-frame-content/public-api.ts

Lines changed: 0 additions & 6 deletions
This file was deleted.

projects/ng-mat-components/src/lib/fs-ui-frame-toolbar/fs-ui-frame-toolbar.module.ts

Lines changed: 0 additions & 27 deletions
This file was deleted.

projects/ng-mat-components/src/lib/fs-ui-frame-toolbar/public-api.ts

Lines changed: 0 additions & 9 deletions
This file was deleted.

projects/ng-mat-components/src/lib/fs-ui-frame-toolbar/directives/fs-ui-frame-toolbar-center.directive.ts renamed to projects/ng-mat-components/src/lib/fs-ui-frame/directives/fs-ui-frame-toolbar-center.directive.ts

File renamed without changes.

projects/ng-mat-components/src/lib/fs-ui-frame-toolbar/directives/fs-ui-frame-toolbar-side.directive.ts renamed to projects/ng-mat-components/src/lib/fs-ui-frame/directives/fs-ui-frame-toolbar-side.directive.ts

File renamed without changes.

projects/ng-mat-components/src/lib/fs-ui-frame-toolbar/directives/fs-ui-frame-toolbar-title.directive.ts renamed to projects/ng-mat-components/src/lib/fs-ui-frame/directives/fs-ui-frame-toolbar-title.directive.ts

File renamed without changes.
Lines changed: 29 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,79 +1,85 @@
11
import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core';
2-
import { Router, ActivatedRoute, NavigationEnd } from '@angular/router';
2+
import { ActivatedRoute, NavigationEnd, Router } from '@angular/router';
33
import { filter, map } from 'rxjs';
4-
import { FrameEvent, NavUser, FrameRoutes, FrameConfig, FrameEvents } from './fs-ui-frame.modules';
5-
import { FsUiFrameService } from './fs-ui-frame.service';
4+
import { FsUiFrameService } from './services/fs-ui-frame.service';
5+
import {
6+
FrameConfig,
7+
FrameEvent,
8+
FrameEvents,
9+
FrameRoutes,
10+
NavUser,
11+
} from './ui-frame.modules';
612

713
@Component({
814
selector: 'fs-ui-frame',
915
templateUrl: './fs-ui-frame.component.html',
1016
styleUrls: ['./fs-ui-frame.component.scss'],
1117
host: {
12-
'class': 'fs-ui-frame',
18+
class: 'fs-ui-frame',
1319
},
1420
})
1521
export class FsUiFrameComponent implements OnInit {
16-
1722
@Output() event = new EventEmitter<FrameEvent>();
1823

1924
@Input() navUser: NavUser | undefined;
2025
@Input() appRoutes: FrameRoutes = [];
2126
@Input() frameConfig: FrameConfig = {
2227
appName: 'Dummy App',
2328
// appNameShort: stringOfLength('DUMMY', 0, 6),
24-
logo: 'https://upload.wikimedia.org/wikipedia/commons/thumb/c/cf/Angular_full_color_logo.svg/1024px-Angular_full_color_logo.svg.png'
29+
logo: 'https://upload.wikimedia.org/wikipedia/commons/thumb/c/cf/Angular_full_color_logo.svg/1024px-Angular_full_color_logo.svg.png',
2530
};
2631

27-
isClosed: boolean = true
28-
isActivePath: string = ''
29-
navList: FrameRoutes = []
32+
isClosed: boolean = true;
33+
isActivePath: string = '';
34+
navList: FrameRoutes = [];
3035

31-
constructor(private frameService: FsUiFrameService,
36+
constructor(
37+
private frameService: FsUiFrameService,
3238
private router: Router,
33-
private activatedRoute: ActivatedRoute) { }
39+
private activatedRoute: ActivatedRoute
40+
) {}
3441

3542
ngOnInit(): void {
36-
this.navList = this.appRoutes.filter(elm => {
37-
return elm.data?.displaySidemenu === true
43+
this.navList = this.appRoutes.filter((elm) => {
44+
return elm.data?.displaySidemenu === true;
3845
});
3946
this.router.events
4047
.pipe(
4148
filter((event) => event instanceof NavigationEnd),
4249
map(() => {
4350
const child = this.activatedRoute.firstChild;
44-
return child
51+
return child;
4552
})
4653
)
4754
.subscribe((ttl: ActivatedRoute | null) => {
48-
ttl?.url.subscribe(obj => {
49-
this.isActivePath = obj[0].path
50-
})
55+
ttl?.url.subscribe((obj) => {
56+
this.isActivePath = obj[0].path;
57+
});
5158
});
5259
}
5360

5461
toggleSidemenu() {
55-
this.frameService.isMenuClosed.emit(!this.isClosed)
56-
this.isClosed = !this.isClosed
62+
this.frameService.isMenuClosed.emit(!this.isClosed);
63+
this.isClosed = !this.isClosed;
5764
}
5865

5966
isNavActive(name: string): boolean {
60-
return name === this.isActivePath
67+
return name === this.isActivePath;
6168
}
6269

6370
onManageAccount(): void {
6471
const frameEvent: FrameEvent = {
6572
type: FrameEvents.MANAGE_ACCOUNT,
6673
data: {},
67-
}
74+
};
6875
this.event.emit(frameEvent);
6976
}
7077

7178
onLogout(): void {
7279
const frameEvent: FrameEvent = {
7380
type: FrameEvents.LOGOUT,
7481
data: {},
75-
}
82+
};
7683
this.event.emit(frameEvent);
7784
}
78-
7985
}

projects/ng-mat-components/src/lib/fs-ui-frame/fs-ui-frame.module.ts

Lines changed: 23 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import { NgModule } from '@angular/core';
21
import { CommonModule } from '@angular/common';
2+
import { NgModule } from '@angular/core';
33
import { BrowserModule } from '@angular/platform-browser';
44
import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
55
import { RouterModule } from '@angular/router';
@@ -11,7 +11,12 @@ import { MatInputModule } from '@angular/material/input';
1111
import { MatMenuModule } from '@angular/material/menu';
1212
import { MatTooltipModule } from '@angular/material/tooltip';
1313

14+
import { FsUiFrameToolbarCenterDirective } from './directives/fs-ui-frame-toolbar-center.directive';
15+
import { FsUiFrameToolbarSideDirective } from './directives/fs-ui-frame-toolbar-side.directive';
16+
import { FsUiFrameToolbarTitleDirective } from './directives/fs-ui-frame-toolbar-title.directive';
1417
import { FsUiFrameComponent } from './fs-ui-frame.component';
18+
import { FsUiFrameContentComponent } from './ui-frame-content/fs-ui-frame-content.component';
19+
import { FsUiFrameToolbarComponent } from './ui-frame-toolbar/fs-ui-frame-toolbar.component';
1520

1621
@NgModule({
1722
imports: [
@@ -26,7 +31,21 @@ import { FsUiFrameComponent } from './fs-ui-frame.component';
2631
MatMenuModule,
2732
MatTooltipModule,
2833
],
29-
exports: [FsUiFrameComponent],
30-
declarations: [FsUiFrameComponent],
34+
exports: [
35+
FsUiFrameComponent,
36+
FsUiFrameToolbarComponent,
37+
FsUiFrameToolbarCenterDirective,
38+
FsUiFrameToolbarSideDirective,
39+
FsUiFrameToolbarTitleDirective,
40+
FsUiFrameContentComponent,
41+
],
42+
declarations: [
43+
FsUiFrameComponent,
44+
FsUiFrameToolbarComponent,
45+
FsUiFrameToolbarCenterDirective,
46+
FsUiFrameToolbarSideDirective,
47+
FsUiFrameToolbarTitleDirective,
48+
FsUiFrameContentComponent,
49+
],
3150
})
32-
export class FsUiFrameModule { }
51+
export class FsUiFrameModule {}

0 commit comments

Comments
 (0)