Skip to content

Commit da18290

Browse files
committed
Use consistent naming for test 'user can log in'
1 parent 68f8989 commit da18290

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

src/content/5/en/part5d.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ Let's start by opening the login form.
263263
describe('Note app', () => {
264264
// ...
265265

266-
test('login form can be opened', async ({ page }) => {
266+
test('user can log in', async ({ page }) => {
267267
await page.goto('http://localhost:5173')
268268

269269
await page.getByRole('button', { name: 'login' }).click()
@@ -293,7 +293,7 @@ When the form is opened, the test should look for the text fields and enter the
293293
describe('Note app', () => {
294294
// ...
295295

296-
test('login form can be opened', async ({ page }) => {
296+
test('user can log in', async ({ page }) => {
297297
await page.goto('http://localhost:5173')
298298

299299
await page.getByRole('button', { name: 'login' }).click()
@@ -316,7 +316,7 @@ The problem now is that _getByRole_ finds two text fields, and calling the [fill
316316
describe('Note app', () => {
317317
// ...
318318

319-
test('login form can be opened', async ({ page }) => {
319+
test('user can log in', async ({ page }) => {
320320
await page.goto('http://localhost:5173')
321321

322322
await page.getByRole('button', { name: 'login' }).click()
@@ -338,7 +338,7 @@ If there were more than two text fields, using the methods _first_ and _last_ wo
338338
```js
339339
describe('Note app', () => {
340340
// ...
341-
test('login form can be opened', async ({ page }) => {
341+
test('user can log in', async ({ page }) => {
342342
await page.goto('http://localhost:5173')
343343

344344
await page.getByRole('button', { name: 'login' }).click()
@@ -396,7 +396,7 @@ Input fields can and should be located in tests using <i>labels</i> with the [ge
396396
describe('Note app', () => {
397397
// ...
398398

399-
test('login form can be opened', async ({ page }) => {
399+
test('user can log in', async ({ page }) => {
400400
await page.goto('http://localhost:5173')
401401

402402
await page.getByRole('button', { name: 'login' }).click()
@@ -434,7 +434,7 @@ describe('Note app', () => {
434434
await expect(page.getByText('Note app, Department of Computer Science, University of Helsinki 2024')).toBeVisible()
435435
})
436436

437-
test('login form can be opened', async ({ page }) => {
437+
test('user can log in', async ({ page }) => {
438438
await page.getByRole('button', { name: 'login' }).click()
439439
await page.getByLabel('username').fill('mluukkai')
440440
await page.getByLabel('password').fill('salainen')

src/content/5/fi/osa5d.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ Aloitetaan kirjautumislomakkeen avaamisella.
227227
describe('Note app', () => {
228228
// ...
229229

230-
test('login form can be opened', async ({ page }) => {
230+
test('user can log in', async ({ page }) => {
231231
await page.goto('http://localhost:5173')
232232

233233
await page.getByRole('button', { name: 'login' }).click()
@@ -257,7 +257,7 @@ Kun lomake on avattu, testin tulisi etsiä siitä tekstikentät ja kirjoittaa ni
257257
describe('Note app', () => {
258258
// ...
259259

260-
test('login form can be opened', async ({ page }) => {
260+
test('user can log in', async ({ page }) => {
261261
await page.goto('http://localhost:5173')
262262

263263
await page.getByRole('button', { name: 'login' }).click()
@@ -280,7 +280,7 @@ Ongelmana on nyt se, että _getByRole_ löytää kaksi tekstikenttää, ja metod
280280
describe('Note app', () => {
281281
// ...
282282

283-
test('login form can be opened', async ({ page }) => {
283+
test('user can log in', async ({ page }) => {
284284
await page.goto('http://localhost:5173')
285285

286286
await page.getByRole('button', { name: 'login' }).click()
@@ -300,7 +300,7 @@ Jos tekstikenttiä olisi enemmän kuin kaksi, ei metodien _first_ ja _last_ käy
300300
```js
301301
describe('Note app', () => {
302302
// ...
303-
test('login form can be opened', async ({ page }) => {
303+
test('user can log in', async ({ page }) => {
304304
await page.goto('http://localhost:5173')
305305

306306
await page.getByRole('button', { name: 'login' }).click()
@@ -357,7 +357,7 @@ Syötekentät voi ja kannattaa etsiä testeissä <i>labelien</i> avulla käyttä
357357
describe('Note app', () => {
358358
// ...
359359

360-
test('login form can be opened', async ({ page }) => {
360+
test('user can log in', async ({ page }) => {
361361
await page.goto('http://localhost:5173')
362362

363363
await page.getByRole('button', { name: 'login' }).click()
@@ -395,7 +395,7 @@ describe('Note app', () => {
395395
await expect(page.getByText('Note app, Department of Computer Science, University of Helsinki 2024')).toBeVisible()
396396
})
397397

398-
test('login form can be opened', async ({ page }) => {
398+
test('user can log in', async ({ page }) => {
399399
await page.getByRole('button', { name: 'login' }).click()
400400
await page.getByLabel('username').fill('mluukkai')
401401
await page.getByLabel('password').fill('salainen')

0 commit comments

Comments
 (0)