Skip to content

Commit 6a9a8a5

Browse files
committed
Fixed bug with login with Provider iOS
1 parent 61915bd commit 6a9a8a5

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

ios/Firestack/Firestack.m

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,12 @@
44
// Copyright © 2016 Facebook. All rights reserved.
55
//
66

7-
#import <objc/runtime.h>
8-
97
#import "Firestack.h"
108
#import "FirestackErrors.h"
119
#import "FirestackEvents.h"
1210
#import "FirestackAnalytics.h"
1311
// #import "FirestackCloudMessaging.h"
1412

15-
@import Firebase;
16-
1713
static Firestack *_sharedInstance = nil;
1814
static dispatch_once_t onceToken;
1915

ios/Firestack/FirestackAuth.m

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ @implementation FirestackAuth
6464
callback(@[[NSNull null], userProps]);
6565
} else {
6666
NSLog(@"An error occurred: %@", [error localizedDescription]);
67-
NSLog(@"Error: %@", error);
6867
// No user is signed in.
6968
NSDictionary *err = @{
7069
@"error": @"No user signed in",
@@ -436,16 +435,16 @@ - (FIRAuthCredential *)getCredentialForProvider:(NSString *)provider
436435
secret:(NSString *)authTokenSecret
437436
{
438437
FIRAuthCredential *credential;
439-
if ([provider caseInsensitiveCompare: @"twitter"]) {
438+
if ([provider compare:@"twitter" options:NSCaseInsensitiveSearch] == NSOrderedSame) {
440439
credential = [FIRTwitterAuthProvider credentialWithToken:authToken
441440
secret:authTokenSecret];
442-
} if ([provider caseInsensitiveCompare: @"facebook"]) {
441+
} else if ([provider compare:@"facebook" options:NSCaseInsensitiveSearch] == NSOrderedSame) {
443442
credential = [FIRFacebookAuthProvider credentialWithAccessToken:authToken];
444-
} if ([provider caseInsensitiveCompare: @"google"]) {
443+
} else if ([provider compare:@"google" options:NSCaseInsensitiveSearch] == NSOrderedSame) {
445444
credential = [FIRGoogleAuthProvider credentialWithIDToken:authToken
446445
accessToken:authTokenSecret];
447446
} else {
448-
NSLog(@"Provider not yet handled");
447+
NSLog(@"Provider not yet handled: %@", provider);
449448
}
450449
return credential;
451450
}

0 commit comments

Comments
 (0)