Merge pull request #7 from fullstackzach/another-test-branch

missing jira

Author: fullstackzach

.github/scripts/commit-checker.sh renamed to .github/scripts/commit-linting.sh

@@ -20,8 +20,6 @@ BRANCH_MERGE_BASE=$(git merge-base ${BASE_BRANCH} ${CURRENT_BRANCH})
 # Find all commits since common ancestor
 BRANCH_COMMITS=$(git rev-list ${BRANCH_MERGE_BASE}..HEAD)
 
-#echo $BRANCH_COMMITS
-
 # Check every commit message since ancestor for regex match
 for commit in $BRANCH_COMMITS; do
     COMMIT_MSG_UPPER=$(git log --max-count=1 --format=%B $commit | tr '[a-z]' '[A-Z]')
@@ -50,7 +48,7 @@ done
 # If any commit are invalid, print the reject message
 if [ "$invalidCommit" == true ]; then
     echo "Commit messages must include a JIRA ticket number e.g. \"AAA-1234\". This can be anywhere in your commit"
-    echo "You can skip this step if necessary by running \"git commit --amend\" and add \"[skip jira]\" in your commit message"
+    echo "You can skip this whole step if necessary by running \"git commit --amend\" and add \"[skip jira]\" in your commit message"
     echo "Please fix the commit message(s) and push again."
     echo "https://help.github.com/en/articles/changing-a-commit-message"
     echo "************"

.github/workflows/commit-checker.yml renamed to .github/workflows/commit-linting.yml

@@ -1,10 +1,10 @@
-name: Commit Checker
+name: Commit messages contain a Jira issue
 
 # Run on push to any branch
 on: [pull_request]
 
 jobs:
-  commit-checker:
+  commit-linting:
     runs-on: ubuntu-latest
 
     steps:
@@ -13,6 +13,5 @@ jobs:
         fetch-depth: 0
         ref: '${{ github.event.pull_request.base.ref }}'
 
-    - name: Commit validation
-      run: bash ${GITHUB_WORKSPACE}/.github/scripts/commit-checker.sh ${{ github.event.pull_request.head.ref }} ${{ github.event.pull_request.base.ref }}
-        
+    - name: Commit messages contain a Jira issue
+      run: bash ${GITHUB_WORKSPACE}/.github/scripts/commit-checker.sh ${{ github.event.pull_request.head.ref }} ${{ github.event.pull_request.base.ref }}

README.md

@@ -1,3 +1,3 @@
 # gh-actions-playground
 
-test 2345
+test 234567s