add swiflint configuration and fix lint error

Author: fumito-ito

.swiftlint.yml

@@ -0,0 +1,112 @@
+excluded:
+  - ${PWD}/DerivedData
+  - ${PWD}/.build
+  - Tests
+  - Demo.swiftpm
+
+disabled_rules:
+  - discarded_notification_center_observer
+  - notification_center_detachment
+  - orphaned_doc_comment
+  - todo
+  - unused_capture_list
+  - opening_brace
+  - trailing_comma
+
+analyzer_rules:
+  - unused_import
+
+opt_in_rules:
+  - array_init
+  - attributes
+  - closure_end_indentation
+  - closure_spacing
+  - collection_alignment
+  - colon # promote to error
+  - convenience_type
+  - discouraged_object_literal
+  - empty_collection_literal
+  - empty_count
+  - empty_string
+  - enum_case_associated_values_count
+  - fatal_error_message
+  - first_where
+  - force_unwrapping
+  - implicitly_unwrapped_optional
+  - indentation_width
+  - last_where
+  - legacy_random
+  - literal_expression_end_indentation
+  - multiline_arguments
+  - multiline_function_chains
+  - multiline_literal_brackets
+  - multiline_parameters
+  - multiline_parameters_brackets
+  - operator_usage_whitespace
+  - overridden_super_call
+  - pattern_matching_keywords
+  - prefer_self_type_over_type_of_self
+  - redundant_nil_coalescing
+  - redundant_type_annotation
+  - strict_fileprivate
+  - toggle_bool
+  - trailing_closure
+  - unneeded_parentheses_in_closure_argument
+  - vertical_whitespace_closing_braces
+  - vertical_whitespace_opening_braces
+  - yoda_condition
+
+
+custom_rules:
+  array_constructor:
+    name: "Array/Dictionary initializer"
+    regex: '[let,var] .+ = (\[.+\]\(\))'
+    capture_group: 1
+    message: "Use explicit type annotation when initializing empty arrays and dictionaries"
+    severity: warning
+
+
+attributes:
+  always_on_same_line:
+    - "@IBSegueAction"
+    - "@IBAction"
+    - "@NSManaged"
+    - "@objc"
+
+force_cast: warning
+force_try: warning
+function_body_length:
+    warning: 60
+
+legacy_hashing: error
+
+identifier_name:
+  excluded:
+    - i
+    - id
+    - x
+    - y
+    - z
+
+indentation_width:
+  indentation_width: 4
+
+line_length:
+  warning: 150
+  ignores_urls: true
+  ignores_function_declarations: true
+  ignores_comments: true
+
+multiline_arguments:
+  first_argument_location: next_line
+  only_enforce_after_first_closure_on_first_line: true
+  
+private_over_fileprivate:
+  validate_extensions: true
+
+trailing_whitespace:
+  ignores_empty_lines: false
+  ignores_comments: true
+
+vertical_whitespace:
+  max_empty_lines: 2

Mintfile

@@ -0,0 +1 @@
+realm/[email protected]

Sources/FirebaseRemoteConfigOpenFeatureProvider/Extensions/Array+Extensions.swift

@@ -9,6 +9,7 @@ import Foundation
 import OpenFeature
 
 extension Array where Element == Any {
+    // swiftlint:disable:next cyclomatic_complexity
     func wrapInValue() throws -> [Value] {
         try self.map { value in
             switch TypeDetector.detectType(from: value) {

Sources/FirebaseRemoteConfigOpenFeatureProvider/Extensions/Dictionary+Extensions.swift

@@ -9,6 +9,7 @@ import Foundation
 import OpenFeature
 
 extension Dictionary<String, Any> {
+    // swiftlint:disable:next cyclomatic_complexity
     func wrapInValue() throws -> [String: OpenFeature.Value] {
         try self.mapValues { value in
             switch TypeDetector.detectType(from: value) {

Sources/FirebaseRemoteConfigOpenFeatureProvider/Extensions/RemoteConfigValueCompatible+Extensions.swift

@@ -40,7 +40,11 @@ extension RemoteConfigValueCompatible {
                 throw OpenFeatureError.parseError(message: "指定されたキーから取得した文字列を日付に変換することができない")
             }
 
-            return .init(value: date, variant: FirebaseRemoteConfigOpenFeatureProvider.dateFormatter.string(from: date), reason: source.reason.rawValue)
+            return .init(
+                value: date,
+                variant: FirebaseRemoteConfigOpenFeatureProvider.dateFormatter.string(from: date),
+                reason: source.reason.rawValue
+            )
         }
     }
 
@@ -86,10 +90,12 @@ extension RemoteConfigValueCompatible {
             case (_, let .some(dictionary), _):
                 value = .structure(try dictionary.wrapInValue())
             case (_, _, let .some(unwrappedString)):
-                switch (FirebaseRemoteConfigOpenFeatureProvider.dateFormatter.date(from: unwrappedString),
-                        Int64(unwrappedString),
-                        Double(unwrappedString),
-                        Bool(unwrappedString)) {
+                switch (
+                    FirebaseRemoteConfigOpenFeatureProvider.dateFormatter.date(from: unwrappedString),
+                    Int64(unwrappedString),
+                    Double(unwrappedString),
+                    Bool(unwrappedString)
+                ) {
                 case (let .some(date), _, _, _):
                     value = .date(date)
                 case (_, let .some(int), _, _):

Sources/FirebaseRemoteConfigOpenFeatureProvider/FirebaseRemoteConfigOpenFeatureProvider.swift

@@ -5,8 +5,9 @@ import OpenFeature
 import FirebaseRemoteConfig
 import FirebaseCore
 
-public let firebaseRemoteConfigOpenFeatureProviderStaleTimeIntervalKey = "firebaseRemoteConfigOpenFeatureProviderStaleTimeIntervalKey"
+// swiftlint:disable:next identifier_name
 public let firebaseRemoteConfigOpenFeatureProviderOldContextKey = "firebaseRemoteConfigOpenFeatureProviderOldContextKey"
+// swiftlint:disable:next identifier_name
 public let firebaseRemoteConfigOpenFeatureProviderNewContextKey = "firebaseRemoteConfigOpenFeatureProviderNewContextKey"
 
 public final class FirebaseRemoteConfigOpenFeatureProvider: FeatureProvider {
@@ -25,7 +26,7 @@ public final class FirebaseRemoteConfigOpenFeatureProvider: FeatureProvider {
 
         return dateFormatter
     }()
-    
+
     /// Provider status
     public private(set) var status: FirebaseRemoteConfigOpenFeatureProviderStatus = .notReady {
         didSet {
@@ -39,7 +40,7 @@ public final class FirebaseRemoteConfigOpenFeatureProvider: FeatureProvider {
             }
         }
     }
-    
+
     /// Provider initializer
     ///
     /// This initilizer updates provider status belong with remote config instance. Also it starts observing notification for remoteConfig update.
@@ -49,19 +50,19 @@ public final class FirebaseRemoteConfigOpenFeatureProvider: FeatureProvider {
         updateStatus(for: remoteConfig)
         NotificationCenter.default.addObserver(self, selector: #selector(remoteConfigDidActivated), name: .onRemoteConfigActivated, object: nil)
     }
-    
+
     deinit {
         NotificationCenter.default.removeObserver(self, name: .onRemoteConfigActivated, object: nil)
     }
-    
+
     /// Provider initializer
     ///
     /// This provider does not support context
     /// - Parameter initialContext: initial context
     public func initialize(initialContext: EvaluationContext?) {
         updateStatus(for: remoteConfig)
     }
-    
+
     /// Update contexts for the provider
     ///
     /// This function notifies `.configurationChanged`event
@@ -168,12 +169,13 @@ extension FirebaseRemoteConfigOpenFeatureProvider {
         // Make sure this key is consistent with kFIRGoogleAppIDKey in FirebaseCore SDK
         // see also https://github.com/firebase/firebase-ios-sdk/blob/main/FirebaseRemoteConfig/Swift/PropertyWrapper/RemoteConfigValueObservable.swift
         let firebaseRemoteConfigAppNameKey = "FIRAppNameKey"
-        
-        guard let appName = notification.userInfo?[firebaseRemoteConfigAppNameKey] as? String,
-              FirebaseApp.app()?.name == appName else {
+
+        guard
+            let appName = notification.userInfo?[firebaseRemoteConfigAppNameKey] as? String,
+            FirebaseApp.app()?.name == appName else {
             return
         }
-        
+
         if status != .ready {
             status = .ready
         }

Sources/FirebaseRemoteConfigOpenFeatureProvider/FirebaseRemoteConfigOpenFeatureProviderMetadata.swift

@@ -1,6 +1,7 @@
 import Foundation
 import OpenFeature
 
+// swiftlint:disable:next type_name
 public struct FirebaseRemoteConfigOpenFeatureProviderMetadata: ProviderMetadata {
     public var name: String? {
         return "FirebaseRemoteConfigOpenFeatureProvider"

Sources/FirebaseRemoteConfigOpenFeatureProvider/FirebaseRemoteConfigOpenFeatureProviderStatus.swift

@@ -10,6 +10,7 @@ import Foundation
 /// Status of provider
 ///
 /// Note: This provider and RemoteConfig does not support `STALED` status.
+// swiftlint:disable:next type_name
 public enum FirebaseRemoteConfigOpenFeatureProviderStatus: String {
     case notReady = "NOT_READY"
     case ready = "READY"

Sources/FirebaseRemoteConfigOpenFeatureProvider/Utils/TypeDetector.swift

@@ -20,6 +20,7 @@ enum TypeDetector {
         case unknown
     }
 
+    // swiftlint:disable:next cyclomatic_complexity
     static func detectType(from object: Any) -> DetectedType {
         switch CFGetTypeID(object as CFTypeRef) {
         case CFBooleanGetTypeID():
@@ -59,4 +60,3 @@ enum TypeDetector {
         }
     }
 }
-