remove notification observer when deinit

fumito-ito · fumito-ito · commit 92821f93292b · 2024-02-05T22:48:35.000+09:00
diff --git a/Sources/FirebaseRemoteConfigOpenFeatureProvider/FirebaseRemoteConfigOpenFeatureProvider.swift b/Sources/FirebaseRemoteConfigOpenFeatureProvider/FirebaseRemoteConfigOpenFeatureProvider.swift
@@ -45,6 +45,11 @@ public final class FirebaseRemoteConfigOpenFeatureProvider: FeatureProvider {
         NotificationCenter.default.addObserver(self, selector: #selector(remoteConfigDidActivated), name: .onRemoteConfigActivated, object: nil)
     }
 
+    
+    deinit {
+        NotificationCenter.default.removeObserver(self, name: .onRemoteConfigActivated, object: nil)
+    }
+    
     public func initialize(initialContext: EvaluationContext?) {
         updateStatus(for: remoteConfig)
     }

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,11 @@ public final class FirebaseRemoteConfigOpenFeatureProvider: FeatureProvider {`
`45`	`45`	`NotificationCenter.default.addObserver(self, selector: #selector(remoteConfigDidActivated), name: .onRemoteConfigActivated, object: nil)`
`46`	`46`	`}`
`47`	`47`
	`48`	`+`
	`49`	`+ deinit {`
	`50`	`+ NotificationCenter.default.removeObserver(self, name: .onRemoteConfigActivated, object: nil)`
	`51`	`+ }`
	`52`	`+`
`48`	`53`	`public func initialize(initialContext: EvaluationContext?) {`
`49`	`54`	`updateStatus(for: remoteConfig)`
`50`	`55`	`}`