Skip to content

Commit 346d5ac

Browse files
fummicc1claude
andcommitted
ci: Remove unnecessary performance-impact job from PR validation
- Remove performance impact analysis job from pr-validation workflow - Simplifies PR validation by focusing on essential checks only - Reduces CI execution time and resource usage The performance benchmarking was not providing actionable insights and added complexity without significant value to the validation process. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent fd89591 commit 346d5ac

File tree

1 file changed

+0
-75
lines changed

1 file changed

+0
-75
lines changed

.github/workflows/pr-validation.yml

Lines changed: 0 additions & 75 deletions
Original file line numberDiff line numberDiff line change
@@ -160,78 +160,3 @@ jobs:
160160
else
161161
echo "No Swift source files changed in this PR"
162162
fi
163-
164-
performance-impact:
165-
name: Performance Impact Analysis
166-
runs-on: macos-15
167-
if: github.event.pull_request.draft == false
168-
169-
steps:
170-
- name: Checkout base branch
171-
uses: actions/checkout@v4
172-
with:
173-
ref: ${{ github.base_ref }}
174-
175-
- name: Setup Xcode
176-
uses: maxim-lobanov/setup-xcode@v1
177-
with:
178-
xcode-version: '16.4'
179-
180-
- name: Setup Swift
181-
run: |
182-
# macOS - use Xcode's Swift
183-
echo "Using Xcode's Swift on macOS"
184-
xcode-select --print-path
185-
swift --version
186-
187-
- name: Build baseline
188-
run: |
189-
swift build --configuration release
190-
191-
- name: Benchmark baseline
192-
run: |
193-
# Create a sample Swift file for benchmarking
194-
mkdir -p benchmark-data
195-
cat > benchmark-data/sample.swift << 'EOF'
196-
func complexFunction(param: Int) -> String {
197-
if param > 100 {
198-
for i in 0..<param {
199-
if i % 2 == 0 {
200-
if i % 4 == 0 {
201-
print("Complex logic")
202-
}
203-
}
204-
}
205-
return "high"
206-
} else if param > 50 {
207-
return "medium"
208-
} else {
209-
return "low"
210-
}
211-
}
212-
EOF
213-
214-
# Benchmark the current version
215-
time swift run swift-complexity benchmark-data/sample.swift --format json > baseline-benchmark.json
216-
217-
- name: Checkout PR
218-
uses: actions/checkout@v4
219-
with:
220-
ref: ${{ github.event.pull_request.head.sha }}
221-
222-
- name: Build PR version
223-
run: |
224-
swift build --configuration release
225-
226-
- name: Benchmark PR version
227-
run: |
228-
# Benchmark the PR version
229-
time swift run swift-complexity benchmark-data/sample.swift --format json > pr-benchmark.json
230-
231-
- name: Compare results
232-
run: |
233-
echo "Baseline benchmark completed"
234-
echo "PR benchmark completed"
235-
echo "Performance comparison would be implemented here"
236-
# In a real scenario, you'd compare execution times and memory usage
237-

0 commit comments

Comments
 (0)