fix compiler warnings

Author: funap

src/Explorer/ContextMenu.cpp

@@ -30,6 +30,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
 #include "Explorer.h"
 #include "ExplorerDialog.h"
 #include "FavesDialog.h"
+#include "NewDlg.h"
 #include "NppInterface.h"
 #include "QuickOpenDialog.h"
 #include "../NppPlugin/menuCmdID.h"

src/Explorer/ContextMenu.h

@@ -25,18 +25,12 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
 
 #pragma once
 
-#include "Explorer.h"
-#include "ExplorerResource.h"
-#include "NewDlg.h"
-#include "../NppPlugin/DockingFeature/Window.h"
-
 #include <shlobj.h>
-#include <commctrl.h>
-
-#include <malloc.h>
 #include <vector>
 #include <string>
 
+#include "Explorer.h"
+
 struct __declspec(uuid("000214e6-0000-0000-c000-000000000046")) IShellFolder;
 
 class ContextMenu

src/Explorer/ExplorerDialog.cpp

@@ -26,6 +26,8 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
 #include <dbt.h>
 #include <algorithm>
 #include <filesystem>
+#include <list>
+#include <string>
 
 #include "Explorer.h"
 #include "ExplorerResource.h"

src/Explorer/ExplorerDialog.h

@@ -61,7 +61,7 @@ class ExplorerDialog : public DockingDlgInterface, public TreeHelper, public CID
 
     void init(HINSTANCE hInst, HWND hParent, ExProp *prop);
     void redraw();
-    void destroy() {};
+    void destroy() override {};
     void doDialog(bool willBeShown = true);
     BOOL gotoPath();
     void gotoUserFolder();

src/Explorer/FavesDialog.h

@@ -26,7 +26,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
 #include "Explorer.h"
 #include "FavesModel.h"
 #include "TreeHelperClass.h"
-#include "Toolbar.h"
+#include "ToolBar.h"
 #include "../NppPlugin/DockingFeature/DockingDlgInterface.h"
 
 enum MenuID {
@@ -60,7 +60,7 @@ class FavesDialog : public DockingDlgInterface, public TreeHelper
         ExpandElementsRecursive(TVI_ROOT);
     };
 
-    void destroy()
+    void destroy() override
     {
         /* save settings and destroy the resources */
         SaveSettings();

src/Explorer/FileDlg.h

@@ -19,7 +19,6 @@
 
 #include <windows.h>
 #include <commdlg.h>
-#include <WCHAR.H>
 
 #include <vector>
 #include <string>

src/Explorer/FileSystemWatcher.h

@@ -21,7 +21,6 @@
 // THE SOFTWARE.
 #pragma once
 
-#include <Windows.h>
 #include <string>
 #include <functional>
 #include <filesystem>

src/Explorer/HelpDialog.h

@@ -32,14 +32,14 @@ class HelpDlg : public StaticDialog
 public:
     HelpDlg() : StaticDialog() {};
 
-    void init(HINSTANCE hInst, HWND hParent)
+    void init(HINSTANCE hInst, HWND hParent) override
     {
         Window::init(hInst, hParent);
     };
 
     void doDialog();
 
-    virtual void destroy() {
+    void destroy() override{
         _emailLink.destroy();
         _urlNppPlugins.destroy();
     };

src/Explorer/NewDlg.h

@@ -42,7 +42,7 @@ class NewDlg : public StaticDialog
 
     INT_PTR doDialog(LPCTSTR pFileName, LPCTSTR pDesc);
 
-    virtual void destroy() {};
+    void destroy() override {};
 
 
 protected :

src/Explorer/PropDlg.h

@@ -45,10 +45,10 @@ class PropDlg : public StaticDialog, public TreeHelper
     PropDlg();
     ~PropDlg();
 
-    void init(HINSTANCE hInst, HWND hWnd) {
+    void init(HINSTANCE hInst, HWND hWnd) override {
         Window::init(hInst, hWnd);
     };
-    virtual void destroy() {};
+    void destroy() override {};
 
     INT_PTR doDialog(LPTSTR pName, LPTSTR pLink, LPTSTR pDesc, LinkDlg linkDlg = LinkDlg::NONE, BOOL fileMustExist = FALSE);
     void setRoot(FavesItemPtr pElem, INT iUserImagePos, BOOL bWithLink = FALSE);