Go 1.24.5, matching linter upgrades

Author: joonas-fi

.golangci.yml

@@ -1,21 +1,12 @@
-
-issues:
-  exclude-files:
-    # golangci-lint doesn't recognize our generated files (*.gen.go)
-    - ".+\\.gen\\.go$"
-
+version: "2"
 linters:
-  disable-all: true
+  default: none
   enable:
     - errcheck
-    - gosimple
     - govet
     - ineffassign
     - staticcheck
-    - typecheck
-    - unused # everything below this is in addition to enabled-by-default
-
-    - goimports
+    - unused
     - copyloopvar
     - exhaustive
     - unconvert
@@ -30,12 +21,37 @@ linters:
     # - gomnd # too strict
     # - tagliatelle # naming, not struct tag validness..
 
-    # full list available by running: $ golangci-lint linters
-
-linters-settings:
-  gocritic:
-    disabled-checks:
-    - ifElseChain # false positives (some if-else chains with "short ifs" look more cumbersome rewritten)
-  gosec:
-    excludes:
-      - G115  # https://dev.to/ccoveille/about-the-gosec-g115-drama-or-how-i-faced-back-integer-conversion-overflow-in-go-1302
+    # full list available by running: $ golangci-lint linters  settings:
+  settings:
+    gocritic:
+      disabled-checks:
+        - ifElseChain
+    gosec:
+      excludes:
+        - G115
+    staticcheck:
+      checks:
+        - all
+        - '-ST1001' # "Dot imports are discouraged."
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - .+\.gen\.go$
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - .+\.gen\.go$
+      - third_party$
+      - builtin$
+      - examples$

Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.23.1
+FROM golang:1.24.5
 
 WORKDIR /workspace
 

build-go-project.sh

@@ -74,20 +74,19 @@ codeGeneration() {
 }
 
 staticAnalysis() {
-	# if we're in GitHub actions, use such an output format that GitHub knows to display the
-	# errors inline with the code
-	local output_format_arg=""
-	if [ "${GITHUB_ACTIONS:-}" == "true" ]; then
-		output_format_arg="--out-format=github-actions"
-	fi
+	# if [ "${GITHUB_ACTIONS:-}" == "true" ]; then
+		# TODO: can't specify `--out-format=github-actions` as it was removed removed. we are supposed to use problem matchers:
+		# https://github.com/golangci/golangci-lint-action/blob/main/problem-matchers.json along with the `text` (the default) format.
+		# the problem matchers are defined by `golangci-lint-action` and as such encourages vendor lock-in to do everything in discrete actions.
+	# fi
 
 	# its config file is looked up from parent directories, so if we're at /workspace and we have
 	# /.golangci.yml, that's going to get used (unless there's /workspace/.golangci.yml)
 
 	# golangci-lint includes what "$ go vet ./..." would do but also more
 	# timeout added because default (1m) sometimes timeouts on bigger projects in underpowered GitHub actions.
 	# more details: https://github.com/golangci/golangci-lint-action/issues/297
-	golangci-lint run --timeout=3m $output_format_arg
+	golangci-lint run --timeout=3m
 }
 
 builds_count=0