quality rules: repo origin check must not "crash" the process if not a Git repo (or no origin defined)

Author: joonas-fi

cmd/bob/projecthomepage.go

@@ -21,7 +21,7 @@ func openProjectHomepageEntrypoint() *cobra.Command {
 		Args:    cobra.NoArgs,
 		Run: func(_ *cobra.Command, _ []string) {
 			osutil.ExitIfError(func() error {
-				repo, err := gitHubRepoRefFromGit()
+				repo, err := gitHubRepoRefFromGitNonNil()
 				if err != nil {
 					return err
 				}
@@ -36,18 +36,36 @@ func openProjectHomepageEntrypoint() *cobra.Command {
 	}
 }
 
+func gitHubRepoRefFromGitNonNil() (*githubRepoRef, error) {
+	ref, err := gitHubRepoRefFromGit()
+	if err != nil {
+		return nil, err
+	}
+
+	if ref == nil {
+		return nil, errors.New("unable to resolve GitHub organization/repo name")
+	}
+
+	return ref, err
+}
+
+// NOTE: returns nil, nil if not a Git repo OR no origin specified OR not a GitHub origin
 func gitHubRepoRefFromGit() (*githubRepoRef, error) {
 	conf, err := os.ReadFile(".git/config")
 	if err != nil {
-		return nil, err
+		if os.IsNotExist(err) {
+			return nil, nil
+		} else { // some other error
+			return nil, err
+		}
 	}
 
 	// dirty
 	originParseRe := regexp.MustCompile(`url = [email protected]:(.+)/(.+).git`)
 
 	matches := originParseRe.FindStringSubmatch(string(conf))
 	if matches == nil {
-		return nil, errors.New("unable to resolve GitHub organization/repo name")
+		return nil, nil
 	}
 
 	org, repo := matches[1], matches[2]

cmd/bob/quality.go

@@ -87,7 +87,15 @@ func conditionsPass(conditions []QualityRuleCondition) bool {
 				panic("repo_origin needs to be in form '*foobar*'")
 			}
 
-			originMatches := strings.Contains(githubURL(getGithubRepoRef()), originWildcard)
+			ref := getGithubRepoRef()
+
+			originMatches := func() bool {
+				if ref != nil {
+					return strings.Contains(githubURL(*ref), originWildcard)
+				} else {
+					return false
+				}
+			}()
 
 			if !conditionPasses(originMatches) {
 				return false
@@ -99,7 +107,7 @@ func conditionsPass(conditions []QualityRuleCondition) bool {
 }
 
 // lazily read gitHubRepoRefFromGit() just once
-func getGithubRepoRef() githubRepoRef {
+func getGithubRepoRef() *githubRepoRef {
 	if githubRepoRefSingleton == nil {
 		var err error
 		githubRepoRefSingleton, err = gitHubRepoRefFromGit()
@@ -108,7 +116,7 @@ func getGithubRepoRef() githubRepoRef {
 		}
 	}
 
-	return *githubRepoRefSingleton
+	return githubRepoRefSingleton
 }
 
 var githubRepoRefSingleton *githubRepoRef