bugfix: if publish not requested, don't run the publish commands of builders

joonas-fi · joonas-fi · commit 7342985410f8 · 2025-04-12T15:51:26.000+03:00
diff --git a/cmd/bob/build.go b/cmd/bob/build.go
@@ -364,8 +364,10 @@ func build(buildCtx *BuildContext) (*buildOutput, error) {
 		return withErr(err) // err context ok
 	}
 
-	if err := pass("publish", publishPass); err != nil {
-		return withErr(err) // err context ok
+	if buildCtx.PublishArtefacts {
+		if err := pass("publish", publishPass); err != nil {
+			return withErr(err) // err context ok
+		}
 	}
 
 	dockerLoginCache := newDockerRegistryLoginCache()

Original file line number	Diff line number	Diff line change
`@@ -364,8 +364,10 @@ func build(buildCtx BuildContext) (buildOutput, error) {`
`364`	`364`	`return withErr(err) // err context ok`
`365`	`365`	`}`
`366`	`366`
`367`		`- if err := pass("publish", publishPass); err != nil {`
`368`		`- return withErr(err) // err context ok`
	`367`	`+ if buildCtx.PublishArtefacts {`
	`368`	`+ if err := pass("publish", publishPass); err != nil {`
	`369`	`+ return withErr(err) // err context ok`
	`370`	`+ }`
`369`	`371`	`}`
`370`	`372`
`371`	`373`	`dockerLoginCache := newDockerRegistryLoginCache()`