backport DefaultReadHeaderTimeout from gokit

this is preparation for updating Go

Author: joonas-fi

pkg/gokitbp/backports.go

@@ -0,0 +1,10 @@
+// `gokit` backports. things that exist in newer version of gokit, but which we cannot update to yet.
+package gokitbp
+
+import (
+	"time"
+)
+
+var (
+	DefaultReadHeaderTimeout = 60 * time.Second
+)

pkg/stofuse/restapi.go

@@ -9,6 +9,7 @@ import (
 	"github.com/function61/gokit/logex"
 	"github.com/function61/gokit/taskrunner"
 	"github.com/function61/pi-security-module/pkg/httpserver/muxregistrator"
+	"github.com/function61/varasto/pkg/gokitbp"
 	"github.com/function61/varasto/pkg/stofuse/stofusetypes"
 	"github.com/function61/varasto/pkg/stoutils"
 	"github.com/gorilla/mux"
@@ -35,7 +36,8 @@ func rpcStart(addr string, sigs *sigFabric, tasks *taskrunner.Runner) error {
 	}
 
 	srv := &http.Server{
-		Handler: router,
+		Handler:           router,
+		ReadHeaderTimeout: gokitbp.DefaultReadHeaderTimeout,
 	}
 
 	tasks.Start("rpc "+addr, func(_ context.Context) error {

pkg/stomediascanner/entrypoint.go

@@ -13,6 +13,7 @@ import (
 	"github.com/function61/gokit/logex"
 	"github.com/function61/gokit/osutil"
 	"github.com/function61/gokit/taskrunner"
+	"github.com/function61/varasto/pkg/gokitbp"
 	"github.com/function61/varasto/pkg/stoutils"
 	"github.com/gorilla/mux"
 	"github.com/spf13/cobra"
@@ -37,7 +38,8 @@ func logic(ctx context.Context, addr string, rootLogger *log.Logger) error {
 	}
 
 	srv := &http.Server{
-		Handler: router,
+		Handler:           router,
+		ReadHeaderTimeout: gokitbp.DefaultReadHeaderTimeout,
 	}
 
 	tasks := taskrunner.New(ctx, rootLogger)

pkg/stoserver/server.go

@@ -31,6 +31,7 @@ import (
 	"github.com/function61/varasto/pkg/blorm"
 	"github.com/function61/varasto/pkg/childprocesscontroller"
 	"github.com/function61/varasto/pkg/frontend"
+	"github.com/function61/varasto/pkg/gokitbp"
 	"github.com/function61/varasto/pkg/logtee"
 	"github.com/function61/varasto/pkg/restartcontroller"
 	"github.com/function61/varasto/pkg/scheduler"
@@ -226,8 +227,9 @@ func runServer(
 	defineUI(router)
 
 	srv := &http.Server{
-		Addr:    "0.0.0.0:443", // 0.0.0.0 = listen on all interfaces
-		Handler: serverConfig.Metrics.WrapHttpServer(router),
+		Addr:              "0.0.0.0:443", // 0.0.0.0 = listen on all interfaces
+		Handler:           serverConfig.Metrics.WrapHttpServer(router),
+		ReadHeaderTimeout: gokitbp.DefaultReadHeaderTimeout,
 		TLSConfig: &tls.Config{
 			MinVersion:   tls.VersionTLS12, // require TLS 1.2 minimum
 			Certificates: []tls.Certificate{serverConfig.TlsCertificate.keypair},