You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
** TODO Some docstrings are quite long which lets you pass package-lint and makes for good enough M-x apropos output, but they wrap poorly in M-x help.
2
+
** TODO "delimiater" -> "delimiter"
3
+
** TODO Since you're using Emacs 25 you can use the string-trim functions (could format-table-trim-row be rewritten as just (string-trim row begin-row end-row)?
4
+
** TODO Could the first conditional in format-table-remove-noise be written either as:
5
+
6
+
#+BEGIN_SRC emacs-lisp
7
+
(unless (or (string-equal "" cur-line)
8
+
(and regexp (string-match regexp cur-line)))
9
+
(push cur-line ret))
10
+
#+END_SRC
11
+
12
+
*** or, even more aggressively (perhaps even using string-blank-p instead of string-empty-p?):
13
+
14
+
#+BEGIN_SRC emacs-lisp
15
+
(and (not (string-empty-p cur-line))
16
+
(not (and regexp (string-match regexp cur-line)))
17
+
(push cur-line ret))
18
+
#+END_SRC
19
+
20
+
** TODO Could the last conditional in format-table-remove-noise be written with (when ret ...) instead of (if (not ret) nil ...)?
21
+
** TODO Rather than
22
+
23
+
#+BEGIN_SRC emacs-lisp
24
+
(let* ((lines (split-string str "[
25
+
26
+
]+"))...)
27
+
#+END_SRC
28
+
29
+
which incidentally contains two newlines, why not:
0 commit comments