Skip to content

Commit b2b645b

Browse files
author
Jason Duncan
committed
Added TODO with suggestions from riscy.
1 parent 415c90a commit b2b645b

File tree

1 file changed

+33
-0
lines changed

1 file changed

+33
-0
lines changed

TODO.org

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
** TODO Some docstrings are quite long which lets you pass package-lint and makes for good enough M-x apropos output, but they wrap poorly in M-x help.
2+
** TODO "delimiater" -> "delimiter"
3+
** TODO Since you're using Emacs 25 you can use the string-trim functions (could format-table-trim-row be rewritten as just (string-trim row begin-row end-row)?
4+
** TODO Could the first conditional in format-table-remove-noise be written either as:
5+
6+
#+BEGIN_SRC emacs-lisp
7+
(unless (or (string-equal "" cur-line)
8+
(and regexp (string-match regexp cur-line)))
9+
(push cur-line ret))
10+
#+END_SRC
11+
12+
*** or, even more aggressively (perhaps even using string-blank-p instead of string-empty-p?):
13+
14+
#+BEGIN_SRC emacs-lisp
15+
(and (not (string-empty-p cur-line))
16+
(not (and regexp (string-match regexp cur-line)))
17+
(push cur-line ret))
18+
#+END_SRC
19+
20+
** TODO Could the last conditional in format-table-remove-noise be written with (when ret ...) instead of (if (not ret) nil ...)?
21+
** TODO Rather than
22+
23+
#+BEGIN_SRC emacs-lisp
24+
(let* ((lines (split-string str "[
25+
26+
]+"))...)
27+
#+END_SRC
28+
29+
which incidentally contains two newlines, why not:
30+
31+
#+BEGIN_SRC emacs-lisp
32+
(let* ((lines (split-string str "[\n]+")) ...)
33+
#+END_SRC

0 commit comments

Comments
 (0)