Skip to content

Commit 31458c7

Browse files
committed
better bfx error type
1 parent 3c89370 commit 31458c7

File tree

5 files changed

+18
-21
lines changed

5 files changed

+18
-21
lines changed

prv

Submodule prv updated from da9f31a to 1be45d2

pub/bfx/src/Bfx/Class/FromRpc.hs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import qualified Bfx.Data.FeeSummary as FeeSummary
99
import Bfx.Data.Kind
1010
import Bfx.Data.Type
1111
import qualified Bfx.Data.Wallets as Wallets
12-
import Bfx.Data.Web
1312
import Bfx.Math
1413
import Bfx.Parser
1514
import Data.Aeson.Lens

pub/bfx/src/Bfx/Data/Type.hs

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ module Bfx.Data.Type
3131

3232
-- * Misc
3333
-- $misc
34+
RawResponse (..),
3435
PltStatus (..),
3536
Error (..),
3637
emptyReq,
@@ -412,6 +413,18 @@ data Ticker = Ticker
412413
-- $misc
413414
-- General utility data used elsewhere.
414415

416+
newtype RawResponse = RawResponse
417+
{ unRawResponse :: BL.ByteString
418+
}
419+
deriving stock
420+
( Eq,
421+
Ord,
422+
Show,
423+
Read,
424+
Data,
425+
Generic
426+
)
427+
415428
data PltStatus
416429
= PltOperative
417430
| PltMaintenance
@@ -424,8 +437,8 @@ data PltStatus
424437

425438
data Error
426439
= ErrorWebException HttpException
427-
| ErrorWebPub Web.Request (Web.Response BL.ByteString)
428-
| ErrorWebPrv BL.ByteString Web.Request (Web.Response BL.ByteString)
440+
| ErrorWebPub Web.Request RawResponse (Web.Response BL.ByteString)
441+
| ErrorWebPrv BL.ByteString Web.Request RawResponse (Web.Response BL.ByteString)
429442
| ErrorParser Web.Request (Web.Response BL.ByteString) Text
430443
| ErrorMath Text
431444
| ErrorTryFrom SomeException

pub/bfx/src/Bfx/Data/Web.hs

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ module Bfx.Data.Web
55
ApiKey (..),
66
RequestMethod (..),
77
BaseUrl (..),
8-
RawResponse (..),
98
Nonce,
109
unNonce,
1110
NonceGen,
@@ -19,7 +18,6 @@ where
1918
import qualified Data.Aeson as A
2019
import qualified Data.Aeson.Types as A
2120
import qualified Data.ByteString as BS
22-
import qualified Data.ByteString.Lazy as BL
2321
import Functora.Cfg
2422
import Functora.Prelude
2523
import qualified Prelude
@@ -75,19 +73,6 @@ newtype BaseUrl = BaseUrl
7573
IsString
7674
)
7775

78-
newtype RawResponse = RawResponse
79-
{ unRawResponse :: BL.ByteString
80-
}
81-
deriving newtype
82-
( Eq,
83-
Ord,
84-
Show
85-
)
86-
deriving stock
87-
( Data,
88-
Generic
89-
)
90-
9176
newtype Nonce = Nonce
9277
{ unNonce :: Natural
9378
}

pub/bfx/src/Bfx/Rpc/Generic.hs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ pub qs req = do
7272
$ fromRpc @method rawRes
7373
else
7474
throw
75-
$ ErrorWebPub webReq1 webRes
75+
$ ErrorWebPub webReq1 rawRes webRes
7676

7777
prv ::
7878
forall method req res m.
@@ -135,7 +135,7 @@ prv env req = do
135135
$ fromRpc @method rawRes
136136
else
137137
throw
138-
$ ErrorWebPrv reqBody webReq1 webRes
138+
$ ErrorWebPrv reqBody webReq1 rawRes webRes
139139

140140
sign ::
141141
PrvKey ->

0 commit comments

Comments
 (0)