Skip to content

Commit 316b362

Browse files
committed
refactoring wip
1 parent 0983c67 commit 316b362

File tree

6 files changed

+9
-16
lines changed

6 files changed

+9
-16
lines changed

ghcjs/lightning-verifier/src/App/Widgets/Fav.hs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import qualified Functora.Miso.Widgets.Field as Field
1313
import qualified Functora.Miso.Widgets.Grid as Grid
1414
import qualified Material.Button as Button
1515
import qualified Material.Dialog as Dialog
16-
import qualified Miso.String as MS
1716

1817
fav :: Model -> [View Action]
1918
fav st =
@@ -114,8 +113,8 @@ fav st =
114113

115114
makeFavName :: Model -> Unicode
116115
makeFavName =
117-
MS.toUpper
118-
. MS.strip
116+
toUpper
117+
. strip
119118
. (^. #modelFavName . #fieldInput . #uniqueValue)
120119

121120
favItems :: Model -> [View Action]

ghcjs/lightning-verifier/src/Main.hs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import Network.Wai.Application.Static
99
import qualified Network.Wai.Handler.Warp as Warp
1010
import qualified Network.WebSockets as Ws
1111
import qualified Data.ByteString.Lazy as BL
12-
import qualified Miso.String as MS
1312
#endif
1413

1514
#ifdef wasi_HOST_OS
@@ -84,7 +83,7 @@ runApp app = do
8483
staticApp (defaultWebAppSettings "static") req
8584
("site.webmanifest" : _) ->
8685
staticApp (defaultWebAppSettings "static") req
87-
(file : _) | (MS.isSuffixOf ".js" file) && (file /= "jsaddle.js") ->
86+
(file : _) | (isSuffixOf ".js" file) && (file /= "jsaddle.js") ->
8887
staticApp (defaultWebAppSettings "static") req
8988
_ ->
9089
JS.jsaddleAppWithJs (JS.jsaddleJs False <> js) req

ghcjs/lightning-verifier/test/App/TypesSpec.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ fun = \case
3131
spec :: Spec
3232
spec = do
3333
prop "Identity/JSON" $ \txt -> do
34-
let wrap :: Identity MisoString = Identity txt
34+
let wrap :: Identity Unicode = Identity txt
3535
let txtJson = A.encode txt
3636
let wrapJson = A.encode wrap
3737
wrap ^. #runIdentity `shouldBe` txt

ghcjs/miso-widgets/src/Functora/Miso/Jsm/Generic.hs

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ where
1717
import qualified Data.ByteString.Lazy as BL
1818
import Functora.Miso.Prelude
1919
import qualified Language.Javascript.JSaddle as JS
20-
import qualified Miso.String as MS
2120
import qualified Text.URI as URI
2221
import qualified Prelude
2322
import qualified Prelude ((!!))
@@ -123,15 +122,11 @@ selectStorage key after =
123122

124123
selectBarcode :: (Maybe Unicode -> JSM ()) -> JSM ()
125124
selectBarcode after =
126-
genericPromise "selectBarcode" Nothing
127-
$ after
128-
. fmap MS.strip
125+
genericPromise "selectBarcode" Nothing $ after . fmap strip
129126

130127
selectClipboard :: (Maybe Unicode -> JSM ()) -> JSM ()
131128
selectClipboard after =
132-
genericPromise "selectClipboard" Nothing
133-
$ after
134-
. fmap MS.strip
129+
genericPromise "selectClipboard" Nothing $ after . fmap strip
135130

136131
genericPromise ::
137132
Unicode ->

ghcjs/miso-widgets/src/Functora/Miso/Widgets/Field.hs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -870,7 +870,7 @@ genericFieldViewer args widget =
870870
allowCopy =
871871
opts ^. #fieldOptsAllowCopy
872872
allowTrunc =
873-
maybe False (MS.length input >) $ opts ^. #fieldOptsTruncateLimit
873+
maybe False (length input >) $ opts ^. #fieldOptsTruncateLimit
874874
stateTrunc =
875875
fromMaybe Closed $ opts ^. #fieldOptsTruncateState
876876
extraWidgets =
@@ -939,7 +939,7 @@ truncateFieldInput ::
939939
Unicode
940940
truncateFieldInput True Closed limit full =
941941
let half = fromMaybe defTruncateLimit limit `div` 2
942-
in MS.take half full
942+
in take half full
943943
<> "..."
944944
<> MS.takeEnd half full
945945
truncateFieldInput _ _ _ full =

pub/functora/src/prelude/Functora/Prelude.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,6 @@ import Data.Sequences as X hiding
231231
sortOn,
232232
splitAt,
233233
subsequences,
234-
take,
235234
takeWhile,
236235
uncons,
237236
)
@@ -306,6 +305,7 @@ import Universum as X hiding
306305
state,
307306
swap,
308307
tails,
308+
take,
309309
throwM,
310310
toStrict,
311311
try,

0 commit comments

Comments
 (0)