Skip to content

Commit a4e0180

Browse files
committed
better loading screen
1 parent 5125bf9 commit a4e0180

File tree

5 files changed

+34
-19
lines changed

5 files changed

+34
-19
lines changed

ghcjs/currency-converter/src/App/Widgets/Fav.hs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ makeFavName :: Model -> MisoString
135135
makeFavName st =
136136
toMisoString
137137
. T.toUpper
138+
. T.strip
138139
$ fromMisoString preFavName
139140
where
140141
preFavName =

ghcjs/currency-converter/src/App/Widgets/FieldPairs.hs

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,26 @@ fieldPairViewer st pair =
2020
else
2121
[ cell
2222
$ strong_
23-
[Typography.typography]
23+
[ Typography.typography,
24+
class_ "fill",
25+
class_ "mdc-text-field",
26+
class_ "mdc-text-field--filled",
27+
style_
28+
[ ("align-items", "center"),
29+
("align-content", "center"),
30+
("word-break", "normal"),
31+
("overflow-wrap", "anywhere"),
32+
("min-height", "56px"),
33+
("height", "auto"),
34+
("padding-top", "8px"),
35+
("padding-bottom", "8px"),
36+
("line-height", "150%")
37+
]
38+
]
2439
[text $ pair ^. #fieldPairKey . #fieldOutput]
2540
]
2641
)
27-
<> ( if k == mempty && v == mempty
42+
<> ( if v == mempty
2843
then mempty
2944
else
3045
[ cell
@@ -36,7 +51,7 @@ fieldPairViewer st pair =
3651
k = pair ^. #fieldPairKey . #fieldOutput
3752
v = inspectDynamicField $ pair ^. #fieldPairValue . #fieldOutput
3853
cell =
39-
if k == mempty
54+
if k == mempty || v == mempty
4055
then Cell.bigCell
4156
else Cell.mediumCell
4257

ghcjs/currency-converter/src/App/Widgets/Main.hs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -27,17 +27,9 @@ mainWidget st =
2727
[ LayoutGrid.alignMiddle
2828
]
2929
$ [ LayoutGrid.inner
30-
( [ class_ "container",
31-
TopAppBar.shortFixedAdjust
32-
]
33-
--
34-
-- NOTE : Hiding widget on the first render to avoid flickering.
35-
--
36-
<> ( if st ^. #modelLoading
37-
then [style_ [("display", "none")]]
38-
else mempty
39-
)
40-
)
30+
[ class_ "container",
31+
TopAppBar.shortFixedAdjust
32+
]
4133
( Menu.menu st
4234
<> screenWidget st
4335
<> [ -- LayoutGrid.cell [LayoutGrid.span12]
@@ -53,7 +45,15 @@ mainWidget st =
5345
)
5446
]
5547
<> ( if st ^. #modelLoading
56-
then [div_ [class_ "lds-dual-ring"] mempty]
48+
then
49+
[ div_
50+
[ class_
51+
"mdc-dialog mdc-dialog--fullscreen fullscreen-dialog mdc-dialog--open mdc-dialog-scroll-divider-footer mdc-dialog--scrollable"
52+
]
53+
[ div_ [class_ "mdc-dialog__scrim"] mempty,
54+
div_ [class_ "lds-dual-ring"] mempty
55+
]
56+
]
5757
else mempty
5858
)
5959

ghcjs/currency-converter/src/Main.hs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,7 @@ updateModel (ChanUpdate prevSt) _ = do
199199
)
200200
$ foldlM (\acc updater -> evalModel $ updater acc) prevSt actions
201201
uri <- URI.mkURI $ shareLink nextSt
202-
let fm = nextSt ^. #modelFavMap
203-
when (fm /= mempty) $ Storage.insertStorage ("favorite-" <> vsn) fm
202+
Storage.insertStorage ("favorite-" <> vsn) (nextSt ^. #modelFavMap)
204203
Storage.insertStorage ("current-" <> vsn) uri
205204
if nextSt ^. #modelLoading
206205
then do

ghcjs/currency-converter/static/app.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ textarea {
6868
height: 64px;
6969
margin: 8px;
7070
border-radius: 50%;
71-
border: 6px solid #6200ee;
72-
border-color: #6200ee transparent #6200ee transparent;
71+
border: 6px solid #ffffff;
72+
border-color: #ffffff transparent #ffffff transparent;
7373
animation: lds-dual-ring 1.2s linear infinite;
7474
}
7575
@keyframes lds-dual-ring {

0 commit comments

Comments
 (0)