Asc or Desc parameter for bfx candle history

Author: functora

pub/bfx/src/Bfx.hs

@@ -466,7 +466,8 @@ candlesLast tf sym opts =
   Generic.pub
     @'CandlesLast
     ( catMaybes
-        [ SomeQueryParam "limit" <$> Candles.limit opts,
+        [ SomeQueryParam "sort" <$> Candles.ascOrDesc opts,
+          SomeQueryParam "limit" <$> Candles.limit opts,
           SomeQueryParam "start" <$> Candles.start opts,
           SomeQueryParam "end" <$> Candles.end opts
         ]
@@ -490,7 +491,8 @@ candlesHist tf sym opts =
   Generic.pub
     @'CandlesHist
     ( catMaybes
-        [ SomeQueryParam "limit" <$> Candles.limit opts,
+        [ SomeQueryParam "sort" <$> Candles.ascOrDesc opts,
+          SomeQueryParam "limit" <$> Candles.limit opts,
           SomeQueryParam "start" <$> Candles.start opts,
           SomeQueryParam "end" <$> Candles.end opts
         ]

pub/bfx/src/Bfx/Class/ToRequestParam.hs

@@ -67,3 +67,8 @@ instance ToRequestParam QuotePerBase where
       . abs
       . from @(Ratio Natural) @Rational
       . unQuotePerBase
+
+instance ToRequestParam AscOrDesc where
+  toTextParam = \case
+    Asc -> "1"
+    Desc -> "-1"

pub/bfx/src/Bfx/Data/Candles.hs

@@ -48,7 +48,8 @@ data Request = Request
     )
 
 data Options = Options
-  { limit :: Maybe Natural,
+  { ascOrDesc :: Maybe AscOrDesc,
+    limit :: Maybe Natural,
     start :: Maybe UTCTime,
     end :: Maybe UTCTime
   }
@@ -64,7 +65,8 @@ data Options = Options
 optsDef :: Options
 optsDef =
   Options
-    { limit = Just 10000,
+    { ascOrDesc = Nothing,
+      limit = Just 10000,
       start = Nothing,
       end = Nothing
     }

pub/bfx/test/BfxSpec.hs

@@ -108,10 +108,22 @@ spec = before sysEnv $ do
     res <- tryAny . Bfx.netWorth env $ CurrencyCode "BTC"
     res `shouldSatisfy` isRight
   it "candlesLast succeeds" . const $ do
-    res <- tryAny $ Bfx.candlesLast Ctf1h adaBtc Candles.optsDef
+    res <-
+      tryAny
+        . Bfx.candlesLast Ctf1h adaBtc
+        $ Candles.optsDef
+        & #ascOrDesc
+        .~ Just Desc
     res `shouldSatisfy` isRight
   it "candlesHist succeeds" . const $ do
-    res <- tryAny $ Bfx.candlesHist Ctf1h adaBtc Candles.optsDef
+    res <-
+      tryAny
+        . Bfx.candlesHist Ctf1h btcUsd
+        $ Candles.optsDef
+        & #ascOrDesc
+        .~ Just Asc
+        & #limit
+        .~ Just 5
     res `shouldSatisfy` isRight
   it "mkOrder" . const $ do
     let req =

pub/functora/functora.cabal

@@ -518,7 +518,6 @@ test-suite functora-test
     build-depends:
       , aes
       , bolt11
-      , card-lib
       , cfg
       , elm2miso-lib
       , functora

pub/functora/src/cfg/Functora/CfgOrphan.hs

@@ -16,6 +16,7 @@ import Data.Binary.Instances ()
 import Functora.Prelude
 import qualified GHC.Generics as Generics
 import qualified Text.URI as URI
+import Toml (HasCodec, HasItemCodec)
 import qualified Toml
 #if defined(__GHCJS__) || defined(ghcjs_HOST_OS) || defined(wasi_HOST_OS)
 import Data.JSString (JSString)
@@ -237,3 +238,7 @@ instance Toml.HasItemCodec JSString where
       $ Toml.Text
       . from @JSString @Text
 #endif
+
+deriving via GenericEnum AscOrDesc instance HasCodec AscOrDesc
+
+deriving via GenericEnum AscOrDesc instance HasItemCodec AscOrDesc

pub/functora/src/prelude/Functora/Prelude.hs

@@ -118,6 +118,7 @@ module Functora.Prelude
     Mono,
     dropAround,
     dropWhileEnd,
+    AscOrDesc (..),
 
     -- * DerivingVia
     -- $derivingVia
@@ -1129,6 +1130,20 @@ dropWhileEnd f =
     )
     mempty
 
+data AscOrDesc
+  = Asc
+  | Desc
+  deriving stock
+    ( Eq,
+      Ord,
+      Show,
+      Read,
+      Data,
+      Generic,
+      Enum,
+      Bounded
+    )
+
 -- $derivingVia
 -- Newtypes to simplify deriving via.
 -- We have to expose default constructors/accessors