fix: fix lookupProfile throwing error for some BNS

Author: pradel

packages/core/src/storage/common/index.test.ts

@@ -0,0 +1,26 @@
+import { getTokenFileUrl } from './index';
+
+const ZONEFILE_CONTENT = {
+  $origin: 'sigle.btc.',
+  $ttl: 3600,
+  uri: [
+    {
+      name: '@',
+      target: '',
+      priority: 10,
+      weight: 1,
+    },
+    {
+      name: '_http._tcp',
+      target: 'https://gaia.blockstack.org/hub/15FF6jnJ1vV4fvo8LFPY1AK6dSbxMP6hkE/profile.json',
+      priority: 10,
+      weight: 1,
+    },
+  ],
+};
+
+describe('getTokenFileUrl tests', () => {
+  it('should get token file url', async () => {
+    expect(getTokenFileUrl(ZONEFILE_CONTENT)).toBe(ZONEFILE_CONTENT.uri[1].target);
+  });
+});

packages/core/src/storage/common/index.ts

@@ -38,12 +38,21 @@ export function getTokenFileUrl(zoneFileJson: any): string | null {
   if (zoneFileJson.uri.length < 1) {
     return null;
   }
-  const firstUriRecord = zoneFileJson.uri[0];
 
-  if (!firstUriRecord.hasOwnProperty('target')) {
+  const validRecords = zoneFileJson.uri.filter(
+    (record: any) => record.hasOwnProperty('target') && record.name === '_http._tcp'
+  );
+
+  if (validRecords.length < 1) {
+    return null;
+  }
+
+  const firstValidRecord = validRecords[0];
+
+  if (!firstValidRecord.hasOwnProperty('target')) {
     return null;
   }
-  let tokenFileUrl = firstUriRecord.target;
+  let tokenFileUrl = firstValidRecord.target;
 
   if (tokenFileUrl.startsWith('https')) {
     // pass