Improve handling around converters.

Author: funilrys

PyFunceble/converter/input_line2subject.py

@@ -60,7 +60,7 @@
 
 class InputLine2Subject(ConverterBase):
     """
-    Converts/Extract the subjcts to test from an inputed line.
+    Converts/Extract the subjects to test from an imputed line.
     """
 
     COMMENT: str = "#"
@@ -72,7 +72,7 @@ class InputLine2Subject(ConverterBase):
     @ConverterBase.data_to_convert.setter
     def data_to_convert(self, value: Any) -> None:
         """
-        Overrites the default behavior.
+        Overrides the default behavior.
 
         :raise TypeError:
             When the given data to convert is not :py:class:`str`

PyFunceble/converter/internal_url.py

@@ -71,7 +71,7 @@ class InternalUrlConverter(ConverterBase):
     @ConverterBase.data_to_convert.setter
     def data_to_convert(self, value: Any) -> None:
         """
-        Overrites the default behavior.
+        Overrides the default behavior.
 
         :raise TypeError:
             When the given data to convert is not :py:class:`str`

PyFunceble/converter/rpz_input_line2subject.py

@@ -59,7 +59,7 @@
 
 class RPZInputLine2Subject(InputLine2Subject):
     """
-    Converts/Extracts the subject from the given RPZ inputline.
+    Converts/Extracts the subject from the given RPZ input line.
     """
 
     COMMENT: list = [";", "//", "#"]
@@ -96,9 +96,7 @@ def convert(self, data: Any, *, aggressive: bool = False) -> List[str]:
             if self.SPACE in subject or self.TAB in subject:
                 subject = subject.split()[0]
 
-                if not subject.isdigit():
-                    result.append(subject)
-            elif not subject.isdigit():
+            if not subject.isdigit():
                 result.append(subject)
 
         return result

PyFunceble/converter/subject2complements.py

@@ -64,6 +64,7 @@ class Subject2Complements(ConverterBase):
     """
 
     _include_given: bool = False
+    domain_syntax_checker: Optional[DomainSyntaxChecker] = None
 
     def __init__(
         self,
@@ -74,6 +75,8 @@ def __init__(
         if include_given is not None:
             self.include_given = include_given
 
+        self.domain_syntax_checker = DomainSyntaxChecker()
+
         super().__init__(data_to_convert=data_to_convert)
 
     @ConverterBase.data_to_convert.setter
@@ -143,7 +146,7 @@ def convert(self, data: Any, *, aggressive: bool = False) -> List[str]:
         _ = aggressive
         result = []
 
-        checker = DomainSyntaxChecker(data)
+        checker = self.domain_syntax_checker.set_subject(data)
 
         if self.include_given and data not in result:
             result.append(data)

PyFunceble/converter/url2netloc.py

@@ -58,7 +58,7 @@
 
 class Url2Netloc(ConverterBase):
     """
-    Provides the interface for the conversion/extration of the network location
+    Provides the interface for the conversion/extraction of the network location
     of a given URL.
     """
 
@@ -70,7 +70,7 @@ class Url2Netloc(ConverterBase):
     @ConverterBase.data_to_convert.setter
     def data_to_convert(self, value: Any) -> None:
         """
-        Overrites the default behavior.
+        Overrides the default behavior.
 
         :raise TypeError:
             When the given data to convert is not :py:class:`str`
@@ -116,7 +116,7 @@ def get_converted(self) -> str:
         Provides the converted data (after conversion)
         """
 
-        # Retrocompatibility.
+        # Retro-compatibility.
         self.parse_url()
 
         return self.convert(self.data_to_convert)

PyFunceble/converter/wildcard2subject.py

@@ -52,7 +52,7 @@
 """
 # pylint: enable=line-too-long
 
-from typing import Any
+from typing import Any, Optional
 
 from PyFunceble.converter.base import ConverterBase
 
@@ -67,7 +67,7 @@ class Wildcard2Subject(ConverterBase):
     @ConverterBase.data_to_convert.setter
     def data_to_convert(self, value: Any) -> None:
         """
-        Overrites the default behavior.
+        Overrides the default behavior.
 
         :raise TypeError:
             When the given data to convert is not :py:class:`str`
@@ -86,7 +86,7 @@ def get_converted(self) -> str:
 
         return self.convert(self.data_to_convert)
 
-    def convert(self, data: Any, *, aggressive: bool = False) -> str:
+    def convert(self, data: Any, *, aggressive: bool = False) -> Optional[str]:
         """
         Converts the given dataset.