adblocker: improve coverage.

This patch fixes #422.

Indeed, before this patch, the following case wasn't handled properly:

  example.com##a[href=https://example.org][target=_blank]

Contributors:
  * @ryanbr

Author: funilrys

PyFunceble/converter/adblock_input_line2subject.py

@@ -123,7 +123,9 @@ def extract_base(subject: Union[str, List[str]]) -> Union[str, List[str]]:
             Giving :code:`"hello.world/?is=beautiful"` returns :code:`"hello.world"`
         """
 
-        subject = subject.replace("*", "").replace("~", "")
+        subject = (
+            subject.replace("*", "").replace("~", "").replace('"', "").replace("'", "")
+        )
 
         try:
             return Url2Netloc(subject).get_converted()
@@ -175,11 +177,12 @@ def _decode_options(self, decoded_options: List[str]) -> Set[str]:
 
             if "href" in rule:
                 matched = self._regex_helper.set_regex(
-                    r"((?:\"|\')(.*)(?:\"|\'))"
-                ).match(rule, return_match=True, rematch=True, group=1)
+                    r"((?:\"|\')(.*?)(?:\"|\'))"
+                ).match(rule, return_match=True, rematch=True)
 
                 if matched:
-                    result.add(self.extract_base(matched))
+                    result.update(self.extract_base(x) for x in matched)
+
                 continue
 
         return result

tests/converter/test_adblock_input_line2subject.py

@@ -274,6 +274,18 @@ class TestAdblockInputLine2Subject(unittest.TestCase):
                 "aggressive": ["example.com", "example.net", "example.org"],
             },
         },
+        {
+            "subject": 'example.com##a[href="https://example.org"][target="_blank"]',
+            "expected": {"aggressive": ["example.com", "example.org"], "standard": []},
+        },
+        {
+            # unlikely, but we should be able to handle such weird cases.
+            "subject": 'example.com##a[href="https://example.org"][target="https://example.net"]',
+            "expected": {
+                "aggressive": ["example.com", "example.net", "example.org"],
+                "standard": [],
+            },
+        },
     ]
 
     def setUp(self) -> None: