Fix issue when a CNAME redirects to same CNAME.

funilrys · funilrys · commit c297f0940f41 · 2021-09-20T22:38:32.000+02:00
This patch fixes #243. Indeed, before this patch, and since we introduced the CNAME follow-up, when a CNAME redicted to the same CNAME or a previous known one in the chain, we were looping over and over. This patch fixes it by always checking if any of the given CNAME was already met. Contributors: * @spirillen
diff --git a/PyFunceble/query/requests/adapter/base.py b/PyFunceble/query/requests/adapter/base.py
@@ -132,6 +132,9 @@ def get_last_cname(subject: str) -> Optional[str]:
                     .query()
                 )
 
+                if any(x in last_cname_result for x in local_last_cname_result):
+                    break
+
                 last_cname_result.extend(local_last_cname_result)
 
                 if local_last_cname_result:

Original file line number	Diff line number	Diff line change
`@@ -132,6 +132,9 @@ def get_last_cname(subject: str) -> Optional[str]:`
`132`	`132`	`.query()`
`133`	`133`	`)`
`134`	`134`
	`135`	`+ if any(x in last_cname_result for x in local_last_cname_result):`
	`136`	`+ break`
	`137`	`+`
`135`	`138`	`last_cname_result.extend(local_last_cname_result)`
`136`	`139`
`137`	`140`	`if local_last_cname_result:`