ensure that click events on transparent labels do not lead to node selection

Author: AnniekStok

src/motile_tracker/data_views/views/layers/track_labels.py

@@ -136,18 +136,37 @@ def assign_new_label(self, event):
 
         new_label(self)
 
-    def process_click(self, event: Event, label: int):
-        """Process the click event to update the selected nodes"""
+    def process_click(
+        self, event: Event, label: int, layer: ContourLabels | None = None
+    ):
+        """Process the click event to update the selected nodes.
 
-        if (
-            label is not None and label != 0 and self.colormap.map(label)[-1] != 0
-        ):  # check opacity (=visibility) in the colormap
-            append = "Shift" in event.modifiers
-            jump = "Control" in event.modifiers
-            if jump:
-                self.tracks_viewer.center_on_node(label)
+        Args:
+            event (Event): The click event.
+            label (int): The label value at the clicked position.
+            layer (ContourLabels | None): The (ortho view) layer from which the click originated.
+                If provided, it is used to check label visibility in that layer's colormap.
+        """
+
+        if label is not None and label != 0:
+            # check visibility in the respective colormap. If a label is not visible, it
+            # is not allowed to be selected from this view
+            if layer is not None:
+                is_visible = layer.colormap.color_dict.get(label)[3] > 0
+            else:
+                is_visible = self.colormap.color_dict.get(label)[3] > 0
+            if is_visible:
+                append = "Shift" in event.modifiers
+                jump = "Control" in event.modifiers
+                if jump:
+                    self.tracks_viewer.center_on_node(label)
+                else:
+                    self.tracks_viewer.selected_nodes.add(label, append)
             else:
-                self.tracks_viewer.selected_nodes.add(label, append)
+                warnings.warn(
+                    f"Node {label} is not visible in this view and cannot be selected.",
+                    stacklevel=2,
+                )
 
     def _get_colormap(self) -> DirectLabelColormap:
         """Get a DirectLabelColormap that maps node ids to their track ids, and then

src/motile_tracker/data_views/views/layers/track_points.py

@@ -122,8 +122,20 @@ def add(self, coords: list[float]):
         with self.events.current_size.blocker():
             super().add(coords)
 
-    def process_click(self, event: Event, point_index: int | None):
-        """Select the clicked point(s)"""
+    def process_click(
+        self,
+        event: Event,
+        point_index: int | None,
+        _layer: napari.layers.Points | None = None,
+    ):
+        """Select the clicked point(s)
+
+        Args:
+            event (Event): The mouse event
+            point_index (int | None): The index of the clicked point, or None if no point
+                was clicked
+            _layer (napari.layers.Points | None): Optional, unused. The (ortho view) layer on which the click occurred, which is forwarded by default.
+        """
 
         if point_index is None:
             self.tracks_viewer.selected_nodes.reset()

src/motile_tracker/data_views/views/ortho_views.py

@@ -1,3 +1,4 @@
+import copy
 import inspect
 
 import napari_orthogonal_views.ortho_view_widget as ov_widget
@@ -235,7 +236,7 @@ def sync_colormap(orig_layer: TrackLabels, copied_layer: Labels, event: Event):
         ContourLabels instance. Check the slice ndisplay and contour settings to adjust
         background opacity accordingly."""
 
-        copied_layer.colormap = orig_layer.colormap
+        copied_layer.colormap = copy.deepcopy(orig_layer.colormap)
         if copied_layer._slice.slice_input.ndisplay == 3 and orig_layer.contour > 0:
             copied_layer.set_opacity(orig_layer.background, 0)
         else:
@@ -274,7 +275,7 @@ def click(
             was_click = yield from detect_click(event)
             if was_click:
                 value = get_click_value(layer, event)
-                orig_layer.process_click(event, value)
+                orig_layer.process_click(event, value, layer)
 
     # Wrap and attach click callback
     def click_wrapper(layer, event):