Skip to content

Commit 962f2b3

Browse files
authored
Update info.tcl test to revert client output limits sooner (redis#13738)
This PR is based on: valkey-io/valkey#1462 We set the client output buffer limits to 10 bytes, and then execute info stats which produces more than 10 bytes of output, which can cause that command to throw an error. I'm not sure why it wasn't consistently erroring before, might have been some change related to the ubuntu upgrade though. failed CI: https://github.com/redis/redis/actions/runs/12738281720/job/35500381299 ------ Co-authored-by: Madelyn Olson [[email protected]](mailto:[email protected])
1 parent 4d8c056 commit 962f2b3

File tree

1 file changed

+15
-2
lines changed

1 file changed

+15
-2
lines changed

tests/unit/info.tcl

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,16 @@
1+
#
2+
# Copyright (c) 2009-Present, Redis Ltd.
3+
# All rights reserved.
4+
#
5+
# Copyright (c) 2024-present, Valkey contributors.
6+
# All rights reserved.
7+
#
8+
# Licensed under your choice of the Redis Source Available License 2.0
9+
# (RSALv2) or the Server Side Public License v1 (SSPLv1).
10+
#
11+
# Portions of this file are available under BSD3 terms; see REDISCONTRIBUTIONS for more information.
12+
#
13+
114
proc cmdstat {cmd} {
215
return [cmdrstat $cmd r]
316
}
@@ -386,10 +399,10 @@ start_server {tags {"info" "external:skip"}} {
386399
r config set client-output-buffer-limit "normal 10 0 0"
387400
r set key [string repeat a 100000] ;# to trigger output buffer limit check this needs to be big
388401
catch {r get key}
402+
r config set client-output-buffer-limit $org_outbuf_limit
389403
set info [r info stats]
390404
assert_equal [getInfoProperty $info client_output_buffer_limit_disconnections] {1}
391-
r config set client-output-buffer-limit $org_outbuf_limit
392-
} {OK} {logreqres:skip} ;# same as obuf-limits.tcl, skip logreqres
405+
} {} {logreqres:skip} ;# same as obuf-limits.tcl, skip logreqres
393406

394407
test {clients: pubsub clients} {
395408
set info [r info clients]

0 commit comments

Comments
 (0)