fix lint errors

apply optional chaining
mark unused function params with `_`

Author: pirxpilot

lib/service/graphhopper/index.js

@@ -116,7 +116,7 @@ function extractDirections(result, { details, distance, instructions, points, ti
 }
 
 function getStatus(st, response) {
-  st = st && st.status;
+  st = st?.status;
   if (!(st || response)) {
     return;
   }
@@ -245,7 +245,7 @@ function init(options) {
       query,
       provider: options.name
     };
-    const paths = response && response.paths;
+    const paths = response?.paths;
     if (paths) {
       directions.routes = [];
       if (query.turnbyturn || query.path === pathType.smooth || query.path === pathType.coarse) {

lib/service/mapquest/index.js

@@ -80,12 +80,12 @@ function extractDirections(result, leg) {
   return result;
 }
 
-function getStatus(err, response) {
+function getStatus(_err, response) {
   if (!response) {
     return;
   }
   const { info, route } = response;
-  const st = info && info.statuscode;
+  const st = info?.statuscode;
   if (st === 403 || st === 500) {
     // assume its because we exceeded the limit
     return status.failure;
@@ -157,16 +157,16 @@ function init(options) {
   }
 
   function processResponse(response, query) {
-    if (response && response.info) {
+    if (response?.info) {
       const { statuscode: st } = response.info;
       if (st === 402 || st > 600) {
         // let it cascade to the next service
         return;
       }
     }
 
-    const route = response && response.route;
-    if (!(route && route.legs && route.legs.length)) {
+    const route = response?.route;
+    if (!route?.legs?.length) {
       // shouldn't happen
       return;
     }
@@ -185,9 +185,9 @@ function init(options) {
     route.legs.reduce(extractDirections, {
       directions,
       unitMultiplier: query.units === 'km' ? util.metersInKm : util.metersInMile,
-      maneuverIndexes: route.shape && route.shape.maneuverIndexes,
-      legIndexes: route.shape && route.shape.legIndexes,
-      path: route.shape && route.shape.shapePoints.reduce(addPoint, []),
+      maneuverIndexes: route.shape?.maneuverIndexes,
+      legIndexes: route.shape?.legIndexes,
+      path: route.shape?.shapePoints.reduce(addPoint, []),
       fullPath
     });
     if (fullPath) {

lib/service/osrm/index.js

@@ -45,8 +45,8 @@ function convertRoute({ legs }) {
 }
 
 // response codes: http://project-osrm.org/docs/v5.5.2/api/#responses
-function getStatus(err, response) {
-  const code = response && response.code;
+function getStatus(_err, response) {
+  const code = response?.code;
   if (!response) {
     return;
   }

lib/service/partition.js

@@ -3,7 +3,7 @@ const util = require('./util');
 module.exports = partition;
 
 function distanceSquare(p1, p2) {
-  return Math.pow(p1[0] - p2[0], 2) + Math.pow(p1[1] - p2[1], 2);
+  return (p1[0] - p2[0]) ** 2 + (p1[1] - p2[1]) ** 2;
 }
 
 function pointOnLine(point, p1, p2) {

lib/service/valhalla/index.js

@@ -66,7 +66,7 @@ function extractSegment(
   const seg = {
     duration,
     distance,
-    path: path && path.slice(begin_shape_index, end_shape_index),
+    path: path?.slice(begin_shape_index, end_shape_index),
     instructions: instruction
   };
   if (rough) {
@@ -95,8 +95,8 @@ function extractDirections(result, leg) {
   const { directions } = result;
   result.path = util.decode(leg.shape, { factor: 1e6 });
   const route = {
-    duration: (leg.summary && leg.summary.time) || 0,
-    distance: Math.round(((leg.summary && leg.summary.length) || 0) * result.unitMultiplier)
+    duration: leg.summary?.time || 0,
+    distance: Math.round((leg.summary?.length || 0) * result.unitMultiplier)
   };
   if (result.fullPath) {
     route.path = result.path;
@@ -138,8 +138,8 @@ function directDistance(locations, units) {
   );
 }
 
-function getStatus(err, response) {
-  let st = response && response.status_code;
+function getStatus(_err, response) {
+  let st = response?.status_code;
   if (!response) {
     return;
   }
@@ -152,9 +152,9 @@ function getStatus(err, response) {
     // no route
     return status.empty;
   }
-  st = response.trip && response.trip.status;
+  st = response.trip?.status;
   if (st === 0) {
-    if (response.trip.legs && response.trip.legs.length) {
+    if (response.trip.legs?.length) {
       const { length, time } = response.trip.summary;
       const distance = directDistance(response.trip.locations, response.trip.units);
       // make sure points are not too far from roads
@@ -229,8 +229,8 @@ function init(options) {
   }
 
   function processResponse(response, query) {
-    const trip = response && response.trip;
-    if (trip && trip.legs && trip.legs.length) {
+    const trip = response?.trip;
+    if (trip?.legs?.length) {
       const directions = {
         query,
         provider: options.name,

test/service/simplify.js

@@ -73,15 +73,13 @@ describe('simplify', function () {
     ];
 
     let path = [];
-    let i;
-    let segments;
 
-    for (i = 0; i < 200; i += 1) {
+    for (let i = 0; i < 200; i += 1) {
       path.push([i / 10, i / 10]);
     }
     routes[0].distance = distance(path);
 
-    segments = [
+    const segments = [
       {
         path: path.slice(0, 30)
       },