use arrow function where possible

Author: pirxpilot

biome.json

@@ -38,8 +38,7 @@
         "noUnusedVariables": "error"
       },
       "complexity": {
-        "noForEach": "off",
-        "useArrowFunction": "off"
+        "noForEach": "off"
       },
       "style": {
         "noParameterAssign": "off",

lib/service/osrm/index.js

@@ -102,14 +102,14 @@ function init(options) {
         if (query.turnbyturn || query.path === pathType.smooth || query.path === pathType.coarse) {
           directions.segments = [];
           // copy segments from route to its own table
-          directions.routes.forEach(function (route) {
+          directions.routes.forEach(route => {
             route.segmentIndex = directions.segments.length;
             directions.segments = directions.segments.concat(route.segments);
             delete route.segments;
           });
         } else {
           // delete segments
-          directions.routes.forEach(function (route) {
+          directions.routes.forEach(route => {
             delete route.segments;
           });
         }

lib/service/util.js

@@ -64,11 +64,7 @@ function isFuture(time) {
 
 // like normal join but with optional filter fn
 function join(arr, conn, fn) {
-  fn =
-    fn ||
-    function (it) {
-      return it;
-    };
+  fn = fn || (it => it);
   return arr.filter(fn).join(conn);
 }
 
@@ -77,7 +73,7 @@ function last(arr) {
 }
 
 function split2object(str, conn, obj) {
-  return str.split(conn || '-').reduce(function (result, word) {
+  return str.split(conn || '-').reduce((result, word) => {
     result[word] = word;
     return result;
   }, obj || {});

test/directions.js

@@ -23,25 +23,25 @@ function timeService(millis, success = true) {
   }
 }
 
-describe('furkot-directions node module', async function () {
-  await it('no input', async function () {
+describe('furkot-directions node module', async () => {
+  await it('no input', async () => {
     const result = await furkotDirections()();
     should.not.exist(result);
   });
 
-  await it('empty input', async function () {
+  await it('empty input', async () => {
     const result = await furkotDirections()({});
     should.not.exist(result);
   });
 
-  await it('one point', async function () {
+  await it('one point', async () => {
     const result = await furkotDirections()({
       points: [[0, 0]]
     });
     should.not.exist(result);
   });
 
-  await it('no service', async function () {
+  await it('no service', async () => {
     const result = await furkotDirections({
       services: []
     })({
@@ -54,7 +54,7 @@ describe('furkot-directions node module', async function () {
     result.should.have.property('routes').with.length(1);
   });
 
-  await it('service', async function () {
+  await it('service', async () => {
     const query = {
       points: [
         [0, 0],
@@ -77,15 +77,15 @@ describe('furkot-directions node module', async function () {
     result.should.have.property('query', query);
   });
 
-  await it('only enabled services', function () {
+  await it('only enabled services', () => {
     const options = {
       valhalla_enable() {}
     };
     const directions = furkotDirections(options);
     directions.options.should.have.property('services').with.length(1);
   });
 
-  await it('override provider name', function () {
+  await it('override provider name', () => {
     const options = {
       order: ['stadiamaps'],
       stadiamaps: 'valhalla',
@@ -95,7 +95,7 @@ describe('furkot-directions node module', async function () {
     directions.options.should.have.property('services').with.length(1);
   });
 
-  await it('timeout', async function () {
+  await it('timeout', async () => {
     const promise = furkotDirections({
       services: [
         {
@@ -122,7 +122,7 @@ describe('furkot-directions node module', async function () {
     });
   });
 
-  await it('abort', async function () {
+  await it('abort', async () => {
     const ac = new AbortController();
     const promise = furkotDirections({
       services: [

test/service/graphhopper/index.js

@@ -3,7 +3,7 @@ const should = require('should');
 const { directionsQuery, pathType } = require('../../../lib/model');
 const graphhopper = require('../../../lib/service/graphhopper');
 
-describe('graphhopper directions', async function () {
+describe('graphhopper directions', async () => {
   let response;
 
   const directions = graphhopper({
@@ -15,7 +15,7 @@ describe('graphhopper directions', async function () {
     }
   }).operation;
 
-  await it('test', async function () {
+  await it('test', async () => {
     response = require('./fixtures/response');
 
     const query = {
@@ -42,7 +42,7 @@ describe('graphhopper directions', async function () {
     result.should.have.property('provider', 'graphhopper');
   });
 
-  await it('turn-by-turn', async function () {
+  await it('turn-by-turn', async () => {
     response = require('./fixtures/turnbyturn');
 
     const query = {
@@ -72,15 +72,11 @@ describe('graphhopper directions', async function () {
     result.segments[0].should.have.property('distance', 508);
     result.segments[0].should.have.property('path').with.length(13);
     result.segments[0].should.have.property('instructions', 'Continue');
-    result.segments
-      .reduce(function (len, seg) {
-        return len + seg.path.length - 1;
-      }, 0)
-      .should.equal(5749);
+    result.segments.reduce((len, seg) => len + seg.path.length - 1, 0).should.equal(5749);
     result.should.have.property('provider', 'graphhopper');
   });
 
-  await it('ferry', async function () {
+  await it('ferry', async () => {
     response = require('./fixtures/ferry');
 
     const query = {
@@ -108,7 +104,7 @@ describe('graphhopper directions', async function () {
     result.should.have.property('provider', 'graphhopper');
   });
 
-  await it('other ferry', async function () {
+  await it('other ferry', async () => {
     response = require('./fixtures/ferry-2');
 
     const query = {
@@ -132,7 +128,7 @@ describe('graphhopper directions', async function () {
     result.should.have.property('provider', 'graphhopper');
   });
 
-  await it('rough surface', async function () {
+  await it('rough surface', async () => {
     response = require('./fixtures/rough');
 
     const query = {
@@ -180,7 +176,7 @@ describe('graphhopper directions', async function () {
     result.should.have.property('provider', 'graphhopper');
   });
 
-  await it('toll roads', async function () {
+  await it('toll roads', async () => {
     response = require('./fixtures/tolls');
 
     const query = {

test/service/index.js

@@ -4,14 +4,14 @@ const service = require('../../lib/service');
 const status = require('../../lib/service/status');
 const util = require('../../lib/service/util');
 
-describe('service', function () {
+describe('service', () => {
   let s;
   let st;
   let reqTimeout;
   let reqResponse;
   const timeout = 200;
 
-  beforeEach(function () {
+  beforeEach(() => {
     st = [];
     reqResponse = 'response';
     reqTimeout = 1;
@@ -38,7 +38,7 @@ describe('service', function () {
     }).operation;
   });
 
-  it('success', async function () {
+  it('success', async () => {
     const result = await s({
       points: [
         [0, 0],
@@ -48,7 +48,7 @@ describe('service', function () {
     result.should.equal('response');
   });
 
-  it('request later', async function () {
+  it('request later', async () => {
     st = [status.error];
     const result = await s({
       points: [
@@ -59,7 +59,7 @@ describe('service', function () {
     result.should.equal('response');
   });
 
-  it('cascade to next service', async function () {
+  it('cascade to next service', async () => {
     reqResponse = undefined;
     const result = await s({
       points: [

test/service/mapquest/index.js

@@ -13,8 +13,8 @@ const directions = mapquest({
   }
 }).operation;
 
-describe('mapquest directions', async function () {
-  await it('test', async function () {
+describe('mapquest directions', async () => {
+  await it('test', async () => {
     response = require('./fixtures/turnbyturn');
 
     const query = {
@@ -51,8 +51,8 @@ describe('mapquest directions', async function () {
   });
 });
 
-describe('open mapquest directions', async function () {
-  await it('test', async function () {
+describe('open mapquest directions', async () => {
+  await it('test', async () => {
     response = require('./fixtures/response');
 
     const query = {

test/service/openroute/index.js

@@ -13,8 +13,8 @@ const directions = openroute({
   }
 }).operation;
 
-describe('openroute directions', async function () {
-  await it('turn-by-turn', async function () {
+describe('openroute directions', async () => {
+  await it('turn-by-turn', async () => {
     response = require('./fixtures/turnbyturn');
 
     const query = {
@@ -42,15 +42,11 @@ describe('openroute directions', async function () {
     result.segments[0].should.have.property('distance', 2226);
     result.segments[0].should.have.property('path').with.length(42);
     result.segments[0].should.have.property('instructions', 'Head south on K 7931');
-    result.segments
-      .reduce(function (len, seg) {
-        return len + seg.path.length - 1;
-      }, 0)
-      .should.equal(7964);
+    result.segments.reduce((len, seg) => len + seg.path.length - 1, 0).should.equal(7964);
     result.should.have.property('provider', 'openroute');
   });
 
-  await it('empty', async function () {
+  await it('empty', async () => {
     response = require('./fixtures/empty');
 
     const query = {
@@ -78,15 +74,11 @@ describe('openroute directions', async function () {
     result.segments[0].should.have.property('distance', 0);
     result.segments[0].should.have.property('path').with.length(0);
     result.segments[0].should.have.property('instructions', 'Head east');
-    result.segments
-      .reduce(function (len, seg) {
-        return len + seg.path.length;
-      }, 0)
-      .should.equal(0);
+    result.segments.reduce((len, seg) => len + seg.path.length, 0).should.equal(0);
     result.should.have.property('provider', 'openroute');
   });
 
-  await it('ferry', async function () {
+  await it('ferry', async () => {
     response = require('./fixtures/ferry');
 
     const query = {
@@ -122,7 +114,7 @@ describe('openroute directions', async function () {
     result.should.have.property('provider', 'openroute');
   });
 
-  await it('too long roundabout route', async function () {
+  await it('too long roundabout route', async () => {
     response = require('./fixtures/roundabout-too-long');
 
     const query = {
@@ -135,7 +127,7 @@ describe('openroute directions', async function () {
     should.not.exist(result);
   });
 
-  await it('rough surface', async function () {
+  await it('rough surface', async () => {
     response = require('./fixtures/rough');
 
     const query = {
@@ -166,7 +158,7 @@ describe('openroute directions', async function () {
     result.should.have.property('provider', 'openroute');
   });
 
-  await it('toll roads', async function () {
+  await it('toll roads', async () => {
     response = require('./fixtures/tolls');
 
     const query = {

test/service/osrm/index.js

@@ -4,11 +4,11 @@ const should = require('should');
 const osrm = require('../../../lib/service/osrm');
 const model = require('../../../lib/model');
 
-describe('osrm', async function () {
-  await it('should return turnbyturn directions', async function (t) {
-    const request = t.mock.fn(undefined, async () => {
-      return { response: require('./fixtures/turnbyturn.json') };
-    });
+describe('osrm', async () => {
+  await it('should return turnbyturn directions', async t => {
+    const request = t.mock.fn(undefined, async () => ({
+      response: require('./fixtures/turnbyturn.json')
+    }));
 
     const directions = osrm({
       name: 'osrm',
@@ -34,7 +34,7 @@ describe('osrm', async function () {
 
     result.should.have.property('routes').with.length(2);
 
-    result.routes.forEach(function (route) {
+    result.routes.forEach(route => {
       route.should.have.property('distance').which.is.Number();
       route.should.have.property('duration').which.is.Number();
       route.should.have.property('path').which.is.Array();
@@ -44,7 +44,7 @@ describe('osrm', async function () {
 
     result.should.have.property('segments').which.is.Array();
 
-    result.segments.forEach(function (segment) {
+    result.segments.forEach(segment => {
       segment.should.have.property('distance').which.is.Number();
       segment.should.have.property('duration').which.is.Number();
       segment.should.have.property('path').which.is.Array();
@@ -63,10 +63,10 @@ describe('osrm', async function () {
     ]);
   });
 
-  await it('should return zero results', async function (t) {
-    const request = t.mock.fn(undefined, async () => {
-      return { response: require('./fixtures/zeroresults.json') };
-    });
+  await it('should return zero results', async t => {
+    const request = t.mock.fn(undefined, async () => ({
+      response: require('./fixtures/zeroresults.json')
+    }));
 
     const directions = osrm({
       name: 'osrm',