Skip to content

Commit 71e46f9

Browse files
authored
Merge pull request #676 from furlongm/cve-title
remove unused cve title field
2 parents 8aebcde + 6596588 commit 71e46f9

File tree

4 files changed

+27
-21
lines changed

4 files changed

+27
-21
lines changed
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# Generated by Django 4.2.20 on 2025-04-20 20:15
2+
3+
from django.db import migrations
4+
5+
6+
class Migration(migrations.Migration):
7+
8+
dependencies = [
9+
('security', '0006_alter_cve_options_alter_cvss_unique_together'),
10+
]
11+
12+
operations = [
13+
migrations.RemoveField(
14+
model_name='cve',
15+
name='title',
16+
),
17+
]

security/models.py

Lines changed: 9 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ def __str__(self):
9292
class CVE(models.Model):
9393

9494
cve_id = models.CharField(max_length=255, unique=True)
95-
title = models.CharField(max_length=255, blank=True, null=True)
9695
description = models.TextField(blank=True, default='')
9796
reserved_date = models.DateTimeField(blank=True, null=True)
9897
published_date = models.DateTimeField(blank=True, null=True)
@@ -233,32 +232,23 @@ def parse_mitre_cve_data(self, cve_json):
233232
if updated_date:
234233
self.updated_date = tz_aware_datetime(cve_metadata.get('dateUpdated'))
235234
cna_container = cve_json.get('containers').get('cna')
236-
title = cna_container.get('title')
237-
if not title:
238-
product = cna_container.get('product')
239235
descriptions = cna_container.get('descriptions')
240236
if descriptions:
241237
self.description = descriptions[0].get('value')
242238
problem_types = cna_container.get('problemTypes', [])
243239
for problem_type in problem_types:
244240
descriptions = problem_type.get('descriptions')
245-
if descriptions:
246-
for description in descriptions:
247-
cwe_description = description.get('description')
248-
if description.get('type') == 'CWE':
249-
cwe_id = description.get('cweId')
250-
if cwe_id:
251-
cwe, created = CWE.objects.get_or_create(cwe_id=cwe_id)
252-
self.cwes.add(cwe)
253-
cwe_ids = re.findall(r'CWE-\d+', cwe_description)
254-
for cwe_id in cwe_ids:
241+
for description in descriptions:
242+
if description.get('type') == 'CWE':
243+
cwe_id = description.get('cweId')
244+
if cwe_id:
255245
cwe, created = CWE.objects.get_or_create(cwe_id=cwe_id)
256246
self.cwes.add(cwe)
257-
if not title:
258-
if product and cwe_description:
259-
self.title = f'{product} - {cwe_description}'
260-
else:
261-
self.title = ''
247+
cwe_description = description.get('description')
248+
cwe_ids = re.findall(r'CWE-\d+', cwe_description)
249+
for cwe_id in cwe_ids:
250+
cwe, created = CWE.objects.get_or_create(cwe_id=cwe_id)
251+
self.cwes.add(cwe)
262252
metrics = cna_container.get('metrics')
263253
if metrics:
264254
for metric in metrics:

security/serializers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class Meta:
2828
class CVESerializer(serializers.HyperlinkedModelSerializer):
2929
class Meta:
3030
model = CVE
31-
fields = ('cve_id', 'title', 'description', 'cvss_score', 'cwe',
31+
fields = ('cve_id', 'description', 'cvss_score', 'cwe',
3232
'registered_date', 'published_date', 'updated_date')
3333

3434

security/templates/security/cve_detail.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
<div class="well well-sm">
2222
<table class="table table-striped table-bordered table-hover table-condensed table-responsive">
2323
<tr><th class="col-sm-1">CVE ID</th><td>{{ cve.cve_id }}</td></tr>
24-
<tr><th class="col-sm-1">Title</th><td>{{ cve.title }}</td></tr>
2524
<tr><th class="col-sm-1">Description</th><td>{{ cve.description }}</td></tr>
2625
<tr><th class="col-sm-1">Reserved</th><td>{{ cve.reserved_date|date|default_if_none:'' }}</td></tr>
2726
<tr><th class="col-sm-1">Rejected</th><td>{{ cve.rejected_date|date|default_if_none:'' }}</td></tr>

0 commit comments

Comments
 (0)