Merge pull request #711 from furlongm/bugbear

fix some flake8-bugbear bugs

Author: furlongm

patchman/urls.py

@@ -44,7 +44,7 @@
 router.register(r'package', package_views.PackageViewSet)
 router.register(r'package-update', package_views.PackageUpdateViewSet)
 router.register(r'cve', security_views.CVEViewSet)
-router.register(r'reference', security_views.ReferenceViewSet),
+router.register(r'reference', security_views.ReferenceViewSet)
 router.register(r'erratum', errata_views.ErratumViewSet)
 router.register(r'repo', repo_views.RepositoryViewSet)
 router.register(r'mirror', repo_views.MirrorViewSet)

repos/repo_types/gentoo.py

@@ -226,7 +226,7 @@ def extract_gentoo_overlay_ebuilds(t):
     """ Extract ebuilds from a Gentoo overlay tarball
     """
     extracted_ebuilds = {}
-    for root, dirs, files in os.walk(t):
+    for root, _, files in os.walk(t):
         for name in files:
             if fnmatch(name, '*.ebuild'):
                 package_name = root.replace(t + '/', '')

repos/repo_types/rpm.py

@@ -69,7 +69,7 @@ def refresh_rpm_repo_mirrors(repo, errata_only=False):
     ]
     ts = get_datetime_now()
     enabled_mirrors = repo.mirror_set.filter(mirrorlist=False, refresh=True, enabled=True)
-    for i, mirror in enumerate(enabled_mirrors):
+    for mirror in enabled_mirrors:
         res = find_mirror_url(mirror.url, formats)
         if not res:
             mirror.fail()

util/__init__.py

@@ -114,10 +114,14 @@ def fetch_content(response, text='', ljust=35):
     wait=wait_exponential(multiplier=1, min=1, max=10),
     reraise=False,
 )
-def get_url(url, headers={}, params={}):
+def get_url(url, headers=None, params=None):
     """ Perform a http GET on a URL. Return None on error.
     """
     response = None
+    if not headers:
+        headers = {}
+    if not params:
+        params = {}
     try:
         debug_message.send(sender=None, text=f'Trying {url} headers:{headers} params:{params}')
         response = requests.get(url, headers=headers, params=params, stream=True, proxies=proxies, timeout=30)