refactor ExtractJsonArrayStringArgument

[eksperts]

this here is the culprit: https://github.com/fusetools/Fuse.Billing.Android/blob/master/src/Fuse.Billing.Android/BillingModule.uno#L225

first, Json.Escape() is deprecated as of 0.36
second, the method seems poorly designed. it could be better if it would work with an array instead of if/elseing on the param type.

[kusma]

Looking at the code, I can't really see how this code could ever have worked. It seems to try to create an array of a single string. But it calls Json.Escape, which doesn't put quotes around the string, making it an invalid JSON entity...

[eksperts]

well I know why this never occurred as a problem.
in my JS implementation, I'm always passing an array to this method, even if it's just a single SKU. So effectively in my case that part of the method was never triggered.

[kusma]

Right, that makes some kind of sense.

[BeeWarloc]

@eksperts If I understand you correctly you mean it would be more straight-forward if the method only accepted an array? I think I agree with that.

@kusma Yeah, you're right. The Json.Escape thing here definitively never worked, it should rather have been Json.Stringify instead (if that accepts a string). Could be that the author is a bit of an idiot, not actually testing the code he wrote. 😸 ✋

[eksperts]

@BeeWarloc you understood me correctly, yes

[LuisRodriguezLD]

Hello. Any news on this?

[BeeWarloc]

@LuisRodriguezLD Nope, unfortunately haven't gotten to this yet.

The fix should be quick and simple, but I'm leaning towards just changing the documentation to say it just supports taking in an array of skus, as I think the string overload just makes the API more ambiguous. 🙂