Skip to content

Commit 32d0f78

Browse files
committed
Merge branch 'release/1.0.2'
2 parents 3ffe485 + 5c561dd commit 32d0f78

18 files changed

+201
-74
lines changed

README.md

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -19,18 +19,13 @@ import { AppComponent } from './app.component';
1919
// Import angular2-fusioncharts
2020
import { FusionChartsModule } from 'angular2-fusioncharts';
2121

22-
// Import FusionCharts library
22+
// Import FusionCharts library and chart modules
2323
import * as FusionCharts from 'fusioncharts';
24-
// Load FusionCharts Charts module
25-
let Charts = require('fusioncharts/fusioncharts.charts');
24+
import * as Charts from 'fusioncharts/fusioncharts.charts';
25+
import * as FintTheme from 'fusioncharts/themes/fusioncharts.theme.fint';
2626

27-
// Create FusionCharts provider function
28-
export function FusionChartsProvider () {
29-
// Resolve charts dependency
30-
Charts(FusionCharts);
31-
32-
return FusionCharts;
33-
}
27+
// Pass the fusioncharts library and chart modules
28+
FusionChartsModule.fcRoot(FusionCharts, Charts, FintTheme);
3429

3530
@NgModule({
3631
declarations: [
@@ -40,8 +35,7 @@ export function FusionChartsProvider () {
4035
imports: [
4136
BrowserModule,
4237
// Specify FusionChartsModule as import
43-
// and pass FusionChartsProvider as a dependency
44-
FusionChartsModule.forRoot(FusionChartsProvider)
38+
FusionChartsModule
4539
],
4640
providers: [],
4741
bootstrap: [AppComponent]

dist/dist/index.js

Lines changed: 46 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,25 +16,47 @@ FusionChartsStatic.decorators = [
1616
FusionChartsStatic.ctorParameters = function () { return []; };
1717
var FusionChartsService = (function () {
1818
function FusionChartsService(FCStatic) {
19-
/* TODO: Need to remove this when FusionCharts becomes ES6 modules */
20-
if (FCStatic.core && FCStatic.core.getCurrentRenderer &&
21-
FCStatic.core.getCurrentRenderer() === 'javascript') {
22-
this._fusionchartsStatice = FCStatic.core;
19+
var fcRoot;
20+
if (FusionChartsService.isFCRootSet()) {
21+
fcRoot = FusionChartsService.getFCRoot();
2322
}
2423
else {
25-
this._fusionchartsStatice = FCStatic.core();
24+
fcRoot = {
25+
core: FCStatic.core,
26+
modules: FCStatic.modules
27+
};
2628
}
27-
if (FCStatic && FCStatic.modules) {
28-
FCStatic.modules.forEach(function (FusionChartsModules) {
29-
FusionChartsModules(FCStatic.core);
29+
this.resolveFusionCharts(fcRoot.core, fcRoot.modules);
30+
}
31+
FusionChartsService.setFCRoot = function (fcRoot) {
32+
FusionChartsService._fcRoot = fcRoot;
33+
};
34+
FusionChartsService.getFCRoot = function () {
35+
return FusionChartsService._fcRoot;
36+
};
37+
FusionChartsService.isFCRootSet = function () {
38+
return !!FusionChartsService._fcRoot;
39+
};
40+
FusionChartsService.prototype.resolveFusionCharts = function (core, modules) {
41+
if (core && core.getCurrentRenderer &&
42+
core.getCurrentRenderer() === 'javascript') {
43+
this._fusionchartsStatice = core;
44+
}
45+
else {
46+
this._fusionchartsStatice = core();
47+
}
48+
if (modules) {
49+
modules.forEach(function (FusionChartsModules) {
50+
FusionChartsModules(core);
3051
});
3152
}
32-
}
53+
};
3354
FusionChartsService.prototype.getFusionChartsStatic = function () {
3455
return this._fusionchartsStatice;
3556
};
3657
return FusionChartsService;
3758
}());
59+
FusionChartsService._fcRoot = null;
3860
FusionChartsService.decorators = [
3961
{ type: _angular_core.Injectable },
4062
];
@@ -306,6 +328,7 @@ FusionChartsPipe.ctorParameters = function () { return []; };
306328
var FusionChartsModule = (function () {
307329
function FusionChartsModule() {
308330
}
331+
// Keep this for backward compatible
309332
FusionChartsModule.forRoot = function (fcCore) {
310333
var fcModules = [];
311334
for (var _i = 1; _i < arguments.length; _i++) {
@@ -322,6 +345,16 @@ var FusionChartsModule = (function () {
322345
}]
323346
};
324347
};
348+
FusionChartsModule.fcRoot = function (fcCore) {
349+
var fcModules = [];
350+
for (var _i = 1; _i < arguments.length; _i++) {
351+
fcModules[_i - 1] = arguments[_i];
352+
}
353+
FusionChartsService.setFCRoot({
354+
core: fcCore,
355+
modules: fcModules
356+
});
357+
};
325358
return FusionChartsModule;
326359
}());
327360
FusionChartsModule.decorators = [
@@ -335,6 +368,10 @@ FusionChartsModule.decorators = [
335368
FusionChartsComponent,
336369
FusionChartsDirective,
337370
FusionChartsPipe
371+
],
372+
providers: [
373+
FusionChartsService,
374+
FusionChartsStatic
338375
]
339376
},] },
340377
];

dist/dist/index.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,5 @@ import { FusionChartsStatic } from './src/fusioncharts.service';
66
export { FusionChartsComponent, FusionChartsDirective, FusionChartsPipe, FusionChartsStatic };
77
export declare class FusionChartsModule {
88
static forRoot(fcCore?: any, ...fcModules: any[]): ModuleWithProviders;
9+
static fcRoot(fcCore?: any, ...fcModules: any[]): void;
910
}

0 commit comments

Comments
 (0)