Skip to content

Commit d228901

Browse files
committed
Merge branch 'develop' into feature/restructure-and-issue-fix
- And fix the conflicts
2 parents 690f2e4 + cb30d00 commit d228901

File tree

2 files changed

+24
-13
lines changed

2 files changed

+24
-13
lines changed

dist/src/fusioncharts.component.js

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,9 @@ var core_1 = require("@angular/core");
1313
var fusioncharts_service_1 = require("./fusioncharts.service");
1414
var fusioncharts_constructor_1 = require("./fusioncharts.constructor");
1515
var FusionChartsComponent = (function () {
16-
function FusionChartsComponent(element, fusionchartsService, differs) {
16+
function FusionChartsComponent(element, fusionchartsService, differs, zone) {
1717
this.differs = differs;
18+
this.zone = zone;
1819
this.oldDataSource = this.dataSource;
1920
this.constructerParams = {
2021
type: true,
@@ -81,6 +82,7 @@ var FusionChartsComponent = (function () {
8182
// @ViewChild('samplediv') chartContainer: ElementRef;
8283
FusionChartsComponent.prototype.ngOnInit = function () {
8384
this.oldDataSource = JSON.stringify(this.dataSource);
85+
this.placeholder = this.placeholder || 'FusionCharts will render here';
8486
};
8587
FusionChartsComponent.prototype.ngOnChanges = function (changes) {
8688
for (var _i = 0, _a = Object.keys(changes); _i < _a.length; _i++) {
@@ -142,16 +144,22 @@ var FusionChartsComponent = (function () {
142144
_this.chartObj = fusioncharts_constructor_1.FusionChartsConstructor(_this.fusionchartsService, configObj);
143145
// configObj['renderAt'] = 'container-' + _this.chartObj.id;
144146
// _this.containerId = _this.chartObj.id;
145-
setTimeout(function () {
146-
_this.chartObj.render(_this.element.nativeElement.querySelector('div'));
147-
}, 1);
147+
this.zone.runOutsideAngular(function () {
148+
setTimeout(function () {
149+
_this.chartObj.render(_this.element.nativeElement.querySelector('div'));
150+
}, 1);
151+
});
148152
}
149153
};
150154
FusionChartsComponent.prototype.ngOnDestroy = function () {
151155
this.chartObj.dispose();
152156
};
153157
return FusionChartsComponent;
154158
}());
159+
__decorate([
160+
core_1.Input(),
161+
__metadata("design:type", String)
162+
], FusionChartsComponent.prototype, "placeholder", void 0);
155163
__decorate([
156164
core_1.Input(),
157165
__metadata("design:type", Object)
@@ -383,9 +391,9 @@ __decorate([
383391
FusionChartsComponent = __decorate([
384392
core_1.Component({
385393
selector: 'fusioncharts',
386-
template: "<div attr.id=\"container-{{containerId}}\" >FusionCharts will render here</div>\n ",
394+
template: "<div attr.id=\"container-{{containerId}}\" >{{placeholder}}</div>\n ",
387395
providers: [fusioncharts_service_1.FusionChartsService],
388396
}),
389-
__metadata("design:paramtypes", [core_1.ElementRef, fusioncharts_service_1.FusionChartsService, core_1.KeyValueDiffers])
397+
__metadata("design:paramtypes", [core_1.ElementRef, fusioncharts_service_1.FusionChartsService, core_1.KeyValueDiffers, core_1.NgZone])
390398
], FusionChartsComponent);
391399
exports.FusionChartsComponent = FusionChartsComponent;

src/angular2-fusioncharts/src/fusioncharts.component.ts

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,22 @@
11
import {Component, Input, ElementRef, OnInit,
22
OnChanges, DoCheck, AfterViewInit, OnDestroy,
3-
KeyValueDiffers, ViewChild} from '@angular/core';
3+
KeyValueDiffers, ViewChild, NgZone} from '@angular/core';
44

55
import { FusionChartsService } from './fusioncharts.service';
66
import { FusionChartsConstructor } from './fusioncharts.constructor';
77

88

99
@Component({
1010
selector: 'fusioncharts',
11-
template: `<div attr.id="container-{{containerId}}" >FusionCharts will render here</div>
11+
template: `<div attr.id="container-{{containerId}}" >{{placeholder}}</div>
1212
`,
1313
providers: [FusionChartsService],
1414
})
1515
export class FusionChartsComponent implements OnInit, OnChanges, DoCheck, AfterViewInit, OnDestroy {
1616

1717
chartObj: any;
1818

19+
@Input() placeholder: string;
1920
@Input() dataSource: Object;
2021
@Input() type: string;
2122
@Input() id: string;
@@ -139,7 +140,7 @@ export class FusionChartsComponent implements OnInit, OnChanges, DoCheck, AfterV
139140
element: ElementRef;
140141
fusionchartsService: FusionChartsService;
141142

142-
constructor(element: ElementRef, fusionchartsService: FusionChartsService, private differs: KeyValueDiffers) {
143+
constructor(element: ElementRef, fusionchartsService: FusionChartsService, private differs: KeyValueDiffers, private zone: NgZone) {
143144
this.element = element;
144145
this.fusionchartsService = fusionchartsService;
145146
}
@@ -148,6 +149,7 @@ export class FusionChartsComponent implements OnInit, OnChanges, DoCheck, AfterV
148149

149150
ngOnInit() {
150151
this.oldDataSource = JSON.stringify(this.dataSource);
152+
this.placeholder = this.placeholder || 'FusionCharts will render here';
151153
}
152154

153155

@@ -235,10 +237,11 @@ export class FusionChartsComponent implements OnInit, OnChanges, DoCheck, AfterV
235237
// configObj['renderAt'] = 'container-' + _this.chartObj.id;
236238
// _this.containerId = _this.chartObj.id;
237239

238-
setTimeout(() => {
239-
_this.chartObj.render(_this.element.nativeElement.querySelector('div'));
240-
}, 1);
241-
240+
this.zone.runOutsideAngular(() => {
241+
setTimeout(() => {
242+
_this.chartObj.render(_this.element.nativeElement.querySelector('div'));
243+
}, 1);
244+
})
242245
}
243246
}
244247

0 commit comments

Comments
 (0)