Skip to content

Commit eb8170d

Browse files
committed
Disable transformer finetuning
This feature in its current state mostly causes problems and confusion, although it should be revisited some day. Word learning is better handled by the dictionary.
1 parent 02746d6 commit eb8170d

File tree

3 files changed

+15
-14
lines changed

3 files changed

+15
-14
lines changed

java/src/org/futo/inputmethod/latin/uix/Settings.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ val USE_SYSTEM_VOICE_INPUT = SettingsKey(
371371
)
372372

373373
val USE_TRANSFORMER_FINETUNING = SettingsKey(
374-
key = booleanPreferencesKey("useTransformerFinetuning"),
374+
key = booleanPreferencesKey("useTransformerFinetuning2"),
375375
default = false
376376
)
377377

java/src/org/futo/inputmethod/latin/uix/settings/pages/PredictiveText.kt

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,11 @@ val PredictiveTextMenu = UserSettingsMenu(
3131
),
3232

3333
// if(transformerLmEnabled) {
34-
userSettingToggleDataStore(
35-
title = R.string.prediction_settings_transformer_finetuning,
36-
subtitle = R.string.prediction_settings_transformer_finetuning_subtitle,
37-
setting = USE_TRANSFORMER_FINETUNING
38-
).copy(visibilityCheck = visibilityCheckLMEnabled),
39-
34+
//userSettingToggleDataStore(
35+
// title = R.string.prediction_settings_transformer_finetuning,
36+
// subtitle = R.string.prediction_settings_transformer_finetuning_subtitle,
37+
// setting = USE_TRANSFORMER_FINETUNING
38+
//).copy(visibilityCheck = visibilityCheckLMEnabled),
4039

4140
userSettingNavigationItem(
4241
title = R.string.prediction_settings_transformer_models,

java/src/org/futo/inputmethod/latin/xlm/LanguageModelFacilitator.kt

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ import org.futo.inputmethod.latin.settings.SettingsValuesForSuggestion
3636
import org.futo.inputmethod.latin.uix.SHOW_EMOJI_SUGGESTIONS
3737
import org.futo.inputmethod.latin.uix.SettingsKey
3838
import org.futo.inputmethod.latin.uix.USE_TRANSFORMER_FINETUNING
39-
import org.futo.inputmethod.latin.uix.actions.PersistentEmojiState
4039
import org.futo.inputmethod.latin.uix.getSetting
4140
import org.futo.inputmethod.latin.uix.getSettingFlow
4241
import org.futo.inputmethod.latin.utils.AsyncResultHolder
@@ -552,6 +551,13 @@ public class LanguageModelFacilitator(
552551
}
553552
}
554553

554+
launch {
555+
withContext(Dispatchers.Default) {
556+
context.getSettingFlow(SHOW_EMOJI_SUGGESTIONS).collect { shouldSuggestEmojis = it }
557+
}
558+
}
559+
560+
/*
555561
trainingEnabled = context.getSetting(USE_TRANSFORMER_FINETUNING)
556562
launch {
557563
withContext(Dispatchers.Default) {
@@ -567,15 +573,10 @@ public class LanguageModelFacilitator(
567573
}
568574
}
569575
570-
launch {
571-
withContext(Dispatchers.Default) {
572-
context.getSettingFlow(SHOW_EMOJI_SUGGESTIONS).collect { shouldSuggestEmojis = it }
573-
}
574-
}
575-
576576
if(trainingEnabled) {
577577
scheduleTrainingWorkerBackground(context)
578578
}
579+
*/
579580
}
580581

581582
public fun shouldPassThroughToLegacy(): Boolean = when {
@@ -725,6 +726,7 @@ public class LanguageModelFacilitator(
725726
}
726727

727728
public fun saveHistoryLog() {
729+
if(!context.getSetting(USE_TRANSFORMER_FINETUNING)) historyLog.clear()
728730
saveHistoryLogBackup(context, historyLog)
729731
}
730732

0 commit comments

Comments
 (0)