Concurrency bad

Author: futurGH

pegasus/lib/repository.ml

@@ -645,12 +645,9 @@ let import_car t (stream : Car.stream) : (t, exn) Lwt_result.t =
               let$! () = User_store.Bulk.put_blocks mst_blocks conn in
               let$! () =
                 [%rapper execute {sql| DELETE FROM records |sql}] () conn
-              in
-              let$!* _ =
-                Lwt.all
-                  [ User_store.Bulk.put_records record_data conn
-                  ; User_store.Bulk.put_blob_refs !blob_refs conn ]
-              in
+                in
+              let$! () = User_store.Bulk.put_records record_data conn in
+              let$! () = User_store.Bulk.put_blob_refs !blob_refs conn in
               Lwt.return_ok () ) )
     in
     (* clear cached block_map so it's rebuilt on next access *)

pegasus/lib/util.ml

@@ -33,23 +33,6 @@ module Syntax = struct
   let ( let$! ) m f =
     match%lwt m with Ok x -> f x | Error e -> raise (Caqti_error.Exn e)
 
-  (* let$! but for an array of results *)
-  let ( let$!* ) m f =
-    let%lwt results =
-      match%lwt m with
-      | xs ->
-          Lwt.return @@ List.rev
-          @@ List.fold_left
-               (fun acc x ->
-                 match x with
-                 | Ok x ->
-                     x :: acc
-                 | Error e ->
-                     raise (Caqti_error.Exn e) )
-               [] xs
-    in
-    f results
-
   (* unwraps an Lwt result, raising an exception if there's an error *)
   let ( >$! ) m f =
     match%lwt m with