FIX: webView:didStartProvisionalNavigation: should not reset progress

funnel20 · funnel20 · commit 2b6fbe464384 · 2024-11-05T15:41:34.000+01:00
Because the observer for `estimatedProgress` has already been fired before and set a value > 0.0 to the progress bar This bug was discovered during implementation of #515
diff --git a/Sources/InAppSettingsKit/Controllers/IASKAppSettingsWebViewController.m b/Sources/InAppSettingsKit/Controllers/IASKAppSettingsWebViewController.m
@@ -312,7 +312,6 @@ - (void)goForward {
 - (void)webView:(WKWebView *)webView didStartProvisionalNavigation:(WKNavigation *)navigation {
     // Show progress:
     [self.activityIndicatorView startAnimating];
-    self.progressView.progress = 0.0;
 }
 
 // Tells the delegate that navigation is complete.

Original file line number	Diff line number	Diff line change
`@@ -312,7 +312,6 @@ - (void)goForward {`
`312`	`312`	`- (void)webView:(WKWebView )webView didStartProvisionalNavigation:(WKNavigation )navigation {`
`313`	`313`	`// Show progress:`
`314`	`314`	`[self.activityIndicatorView startAnimating];`
`315`		`- self.progressView.progress = 0.0;`
`316`	`315`	`}`
`317`	`316`
`318`	`317`	`// Tells the delegate that navigation is complete.`