BUG FIX: foreach(..., .errorhandling = "pass") %dofuture% { ... }` now works as expected [#86]

Author: HenrikBengtsson

DESCRIPTION

@@ -1,5 +1,5 @@
 Package: doFuture
-Version: 1.1.0-9002
+Version: 1.1.0-9003
 Title: Use Foreach to Parallelize via the Future Framework
 Depends:
     foreach (>= 1.5.0),

NEWS.md

@@ -1,6 +1,11 @@
 # Version (development version)
 
- * ...
+## Bug Fixes
+
+ * `foreach(...) %dofuture% { ... }` would signal errors, despite
+   using `.errorhandling = "pass"` or `.errorhandling = "remove"`.
+   This was originally by design, because all errors should be errors,
+   but have since been convinced it was a design mistake.
 
 
 # Version 1.1.0 (2025-05-19)

R/doFuture2.R

@@ -70,19 +70,24 @@ doFuture2 <- function(obj, expr, envir, data) {   #nolint
     options[name] <- opts[name]
   }
   options(future.disposable = NULL)
-  
-  errors <- options[["errors"]]
-  if (is.null(errors)) {
-    errors <- "future"
-  } else if (is.character(errors)) {
-    if (length(errors) != 1L) {
-      stop(sprintf("Element 'errors' of '.options.future' should be of length one': [n = %d] %s", length(errors), paste(sQuote(errors), collapse = ", ")))
-    }
-    if (! errors %in% c("future", "foreach")) {
-      stop(sprintf("Unknown value of '.options.future' element 'errors': %s", sQuote(errors)))
-    }
+
+  error_handling <- obj$errorHandling
+  if (!identical(error_handling, "stop")) {
+    errors <- "foreach"
   } else {
-    stop("Unknown type of '.options.future' element 'errors': ", mode(errors))
+    errors <- options[["errors"]]
+    if (is.null(errors)) {
+      errors <- "future"
+    } else if (is.character(errors)) {
+      if (length(errors) != 1L) {
+        stop(sprintf("Element 'errors' of '.options.future' should be of length one': [n = %d] %s", length(errors), paste(sQuote(errors), collapse = ", ")))
+      }
+      if (! errors %in% c("future", "foreach")) {
+        stop(sprintf("Unknown value of '.options.future' element 'errors': %s", sQuote(errors)))
+      }
+    } else {
+      stop("Unknown type of '.options.future' element 'errors': ", mode(errors))
+    }
   }
 
 
@@ -630,7 +635,6 @@ elements in 'X' (= %d). There were in total %d chunks and %d elements (%s)",
       ## ... or as traditionally with %dopar%, which throws an error
       ## or return the combined results
       ## NOTE: This is adopted from foreach:::doSEQ()
-      error_handling <- obj$errorHandling
       if (debug) {
         mdebugf("processing errors (handler = %s)", sQuote(error_handling))
       }

R/dofuture_OP.R

@@ -14,12 +14,16 @@
 #' When using `%dofuture%`:
 #'
 #' * there is no need to use `registerDoFuture()`
+#'
 #' * there is no need to use `%dorng%` of the **doRNG** package
 #'   (but you need to specify `.options.future = list(seed = TRUE)`
 #'    whenever using random numbers in the `expr` expression)
+#'
 #' * global variables and packages are identified automatically by
 #'   the \pkg{future} framework
-#' * errors are relayed as-is (with `%dopar%` they are captured and modified)
+#'
+#' * errors are relayed as-is with the default `.errorhandling = "stop"`,
+#'   whereas with `%dopar%` they are captured and modified.
 #'
 #'
 #' @section Global variables and packages: