Skip to content

Commit 214e869

Browse files
Drop support for rscript = "*" - does not make sense
1 parent fe70036 commit 214e869

14 files changed

+27
-39
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
Package: future.batchtools
2-
Version: 0.20.0-9022
2+
Version: 0.20.0-9023
33
Depends:
44
R (>= 3.2.0),
55
parallelly,

R/batchtools_slurm.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ print.BatchtoolsSlurmFutureBackend <- function(x, ...) {
118118
#' modules = c("r", "jags"),
119119
#' details = TRUE,
120120
#' envs = c(R_LIBS_USER="~/R/rocker-%p-library/%v-CBI-gcc13"),
121-
#' rscript = c("apptainer", "exec", "~/lxc/rocker_r-base.sif", "*")
121+
#' rscript = c("apptainer", "exec", "~/lxc/rocker_r-base.sif", "Rscript")
122122
#' ))
123123
#'
124124
#' f <- future({

inst/templates/bash.tmpl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,8 @@ exec > <%= log.file %> 2>&1
3131
rscript <- resources[["rscript"]]
3232
if (is.null(rscript)) {
3333
rscript <- "Rscript"
34-
} else {
35-
if (length(rscript) == 0 || !nzchar(rscript)[1]) stop("Argument 'resources' specifies an empty 'rscript' field")
36-
rscript[rscript == "*"] <- "Rscript"
34+
} else if (length(rscript) == 0 || !nzchar(rscript)[1]) {
35+
stop("Argument 'resources' specifies an empty 'rscript' field")
3736
}
3837
resources[["rscript"]] <- NULL
3938

inst/templates/lsf.tmpl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,8 @@
3333
rscript <- resources[["rscript"]]
3434
if (is.null(rscript)) {
3535
rscript <- "Rscript"
36-
} else {
37-
if (length(rscript) == 0 || !nzchar(rscript)[1]) stop("Argument 'resources' specifies an empty 'rscript' field")
38-
rscript[rscript == "*"] <- "Rscript"
36+
} else if (length(rscript) == 0 || !nzchar(rscript)[1]) {
37+
stop("Argument 'resources' specifies an empty 'rscript' field")
3938
}
4039
resources[["rscript"]] <- NULL
4140
rscript_args <- resources[["rscript_args"]]

inst/templates/openlava.tmpl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,8 @@
3333
rscript <- resources[["rscript"]]
3434
if (is.null(rscript)) {
3535
rscript <- "Rscript"
36-
} else {
37-
if (length(rscript) == 0 || !nzchar(rscript)[1]) stop("Argument 'resources' specifies an empty 'rscript' field")
38-
rscript[rscript == "*"] <- "Rscript"
36+
} else if (length(rscript) == 0 || !nzchar(rscript)[1]) {
37+
stop("Argument 'resources' specifies an empty 'rscript' field")
3938
}
4039
resources[["rscript"]] <- NULL
4140
rscript_args <- resources[["rscript_args"]]

inst/templates/sge.tmpl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,8 @@
4242
rscript <- resources[["rscript"]]
4343
if (is.null(rscript)) {
4444
rscript <- "Rscript"
45-
} else {
46-
if (length(rscript) == 0 || !nzchar(rscript)[1]) stop("Argument 'resources' specifies an empty 'rscript' field")
47-
rscript[rscript == "*"] <- "Rscript"
45+
} else if (length(rscript) == 0 || !nzchar(rscript)[1]) {
46+
stop("Argument 'resources' specifies an empty 'rscript' field")
4847
}
4948
resources[["rscript"]] <- NULL
5049
rscript_args <- resources[["rscript_args"]]

inst/templates/slurm.tmpl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,8 @@
3232
rscript <- resources[["rscript"]]
3333
if (is.null(rscript)) {
3434
rscript <- "Rscript"
35-
} else {
36-
if (length(rscript) == 0 || !nzchar(rscript)[1]) stop("Argument 'resources' specifies an empty 'rscript' field")
37-
rscript[rscript == "*"] <- "Rscript"
35+
} else if (length(rscript) == 0 || !nzchar(rscript)[1]) {
36+
stop("Argument 'resources' specifies an empty 'rscript' field")
3837
}
3938
resources[["rscript"]] <- NULL
4039
rscript_args <- resources[["rscript_args"]]

inst/templates/torque.tmpl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,8 @@
3636
rscript <- resources[["rscript"]]
3737
if (is.null(rscript)) {
3838
rscript <- "Rscript"
39-
} else {
40-
if (length(rscript) == 0 || !nzchar(rscript)[1]) stop("Argument 'resources' specifies an empty 'rscript' field")
41-
rscript[rscript == "*"] <- "Rscript"
39+
} else if (length(rscript) == 0 || !nzchar(rscript)[1]) {
40+
stop("Argument 'resources' specifies an empty 'rscript' field")
4241
}
4342
resources[["rscript"]] <- NULL
4443
rscript_args <- resources[["rscript_args"]]

man/batchtools_bash.Rd

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/batchtools_lsf.Rd

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)