Skip to content

Commit 686ca65

Browse files
CLEANUP: Removed S3 generic await(); it is only used internally and can be a regular function (fixes #58)
1 parent b33bdb2 commit 686ca65

File tree

5 files changed

+16
-56
lines changed

5 files changed

+16
-56
lines changed

NAMESPACE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
# Generated by roxygen2: do not edit by hand
22

3-
S3method(await,BatchtoolsFuture)
43
S3method(delete,BatchtoolsFuture)
54
S3method(finished,BatchtoolsFuture)
65
S3method(loggedError,BatchtoolsFuture)
@@ -14,6 +13,7 @@ S3method(status,BatchtoolsFuture)
1413
export("%resources%")
1514
export(BatchtoolsFuture)
1615
export(BatchtoolsFutureError)
16+
export(await)
1717
export(batchtools_custom)
1818
export(batchtools_interactive)
1919
export(batchtools_local)

NEWS

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
11
Package: future.batchtools
22
==========================
33

4-
Version: 0.9.0-9000 [2020-12-23]
4+
Version: 0.9.0-9000 [2021-01-02]
55

66
SIGNIFICANT CHANGES:
77

88
* Lazy batchtools futures only creates the internal batchtools registry when
99
the future is launched.
1010

11+
* Removed S3 generic await(), which is a function that was only used for
12+
internal purposes.
13+
1114
DOCUMENTATION:
1215

1316
* Document option 'future.delete' and clarify option 'future.cache.path'
@@ -18,6 +21,11 @@ BUG FIXES:
1821
* If run() was called twice for a BatchtoolsFuture, it would not produce
1922
a FutureError but only a regular non-classed error.
2023

24+
DEPRECATED AND DEFUNCT:
25+
26+
* Removed S3 generic await(), which is a function that was only used for
27+
internal purposes.
28+
2129

2230
Version: 0.9.0 [2020-04-14]
2331

R/BatchtoolsFuture-class.R

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -502,8 +502,6 @@ run.BatchtoolsFuture <- function(future, ...) {
502502
} ## run()
503503

504504

505-
await <- function(...) UseMethod("await")
506-
507505
#' Awaits the value of a batchtools future
508506
#'
509507
#' @param future The future.
@@ -528,13 +526,11 @@ await <- function(...) UseMethod("await")
528526
#' @importFrom batchtools getErrorMessages loadResult waitForJobs
529527
#' @importFrom utils tail
530528
#' @keywords internal
531-
await.BatchtoolsFuture <- function(future, cleanup = TRUE,
532-
timeout = getOption("future.wait.timeout",
533-
30 * 24 * 60 * 60),
534-
delta = getOption("future.wait.interval",
535-
1.0),
536-
alpha = getOption("future.wait.alpha", 1.01),
537-
...) {
529+
await <- function(future, cleanup = TRUE,
530+
timeout = getOption("future.wait.timeout", 30 * 24 * 60 * 60),
531+
delta = getOption("future.wait.interval", 1.0),
532+
alpha = getOption("future.wait.alpha", 1.01),
533+
...) {
538534
stop_if_not(is.finite(timeout), timeout >= 0)
539535
stop_if_not(is.finite(alpha), alpha > 0)
540536

R/options.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
#' options(future.cache.path = "/cluster-wide/folder/.future")
5555
#'
5656
#' # Set an environment variable:
57-
#' Sys.setenv(R_FUTURE_RNG_ONMISUSE = "/cluster-wide/folder/.future")
57+
#' Sys.setenv(R_FUTURE_CACHE_PATH = "/cluster-wide/folder/.future")
5858
#'
5959
#' @aliases
6060
#' future.cache.path

man/await.BatchtoolsFuture.Rd

Lines changed: 0 additions & 44 deletions
This file was deleted.

0 commit comments

Comments
 (0)