Skip to content

Commit 7885dee

Browse files
Merge branch 'release/0.10.0'
2 parents 32088a7 + db6edc3 commit 7885dee

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+601
-603
lines changed

.Rbuildignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
^.git
66
^.github
77
^.make
8+
^.local
89
^INSTALL[.]md$
910
^OVERVIEW[.]md$
1011
^README[.]md$

.github/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
*.html

.github/workflows/R-CMD-check.yaml

Lines changed: 40 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -4,32 +4,35 @@ name: R-CMD-check
44

55
jobs:
66
R-CMD-check:
7+
if: "! contains(github.event.head_commit.message, '[ci skip]')"
8+
79
runs-on: ${{ matrix.config.os }}
10+
811
name: ${{ matrix.config.os }} (${{ matrix.config.r }})
9-
if: "! contains(github.event.head_commit.message, '[ci skip]')"
10-
12+
1113
strategy:
1214
fail-fast: false
1315
matrix:
1416
config:
15-
- { os: windows-latest, r: '3.5'}
16-
- { os: windows-latest, r: '3.6'}
17-
- { os: macOS-latest, r: '3.5'}
18-
- { os: macOS-latest, r: '3.6'}
19-
- { os: macOS-latest, r: 'devel'}
20-
- { os: ubuntu-16.04, r: '3.2', cran: "https://demo.rstudiopm.com/all/__linux__/xenial/latest"}
21-
- { os: ubuntu-16.04, r: '3.3', cran: "https://demo.rstudiopm.com/all/__linux__/xenial/latest"}
22-
- { os: ubuntu-16.04, r: '3.4', cran: "https://demo.rstudiopm.com/all/__linux__/xenial/latest"}
23-
- { os: ubuntu-16.04, r: '3.5', cran: "https://demo.rstudiopm.com/all/__linux__/xenial/latest"}
24-
- { os: ubuntu-16.04, r: '3.6', cran: "https://demo.rstudiopm.com/all/__linux__/xenial/latest"}
17+
- {os: windows-latest, r: 'devel'}
18+
#2020-09-23# - {os: windows-latest, r: 'release'}
19+
- {os: macOS-latest, r: 'devel'}
20+
- {os: macOS-latest, r: 'release'}
21+
- {os: ubuntu-20.04, r: 'devel', rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}
22+
- {os: ubuntu-20.04, r: 'release', rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}
23+
- {os: ubuntu-20.04, r: 'oldrel', rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}
24+
- {os: ubuntu-20.04, r: '3.5', rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}
25+
- {os: ubuntu-20.04, r: '3.4', rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}
26+
- {os: ubuntu-20.04, r: '3.3', rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}
2527

2628
env:
2729
R_REMOTES_NO_ERRORS_FROM_WARNINGS: true
28-
CRAN: ${{ matrix.config.cran }}
29-
30+
R_FUTURE_RNG_ONMISUSE: error
31+
RSPM: ${{ matrix.config.rspm }}
32+
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
3033

3134
steps:
32-
- uses: actions/checkout@v1
35+
- uses: actions/checkout@v2
3336

3437
- uses: r-lib/actions/setup-r@master
3538
with:
@@ -38,15 +41,19 @@ jobs:
3841
- uses: r-lib/actions/setup-pandoc@master
3942

4043
- name: Query dependencies
41-
run: Rscript -e "install.packages('remotes')" -e "saveRDS(remotes::dev_package_deps(dependencies = TRUE), 'depends.Rds', version = 2)"
44+
run: |
45+
install.packages('remotes')
46+
saveRDS(remotes::dev_package_deps(dependencies = TRUE), ".github/depends.Rds", version = 2)
47+
writeLines(sprintf("R-%i.%i", getRversion()$major, getRversion()$minor), ".github/R-version")
48+
shell: Rscript {0}
4249

4350
- name: Cache R packages
4451
if: runner.os != 'Windows'
4552
uses: actions/cache@v1
4653
with:
4754
path: ${{ env.R_LIBS_USER }}
48-
key: ${{ runner.os }}-r-${{ matrix.config.r }}-${{ hashFiles('depends.Rds') }}
49-
restore-keys: ${{ runner.os }}-r-${{ matrix.config.r }}-
55+
key: ${{ runner.os }}-${{ hashFiles('.github/R-version') }}-1-${{ hashFiles('.github/depends.Rds') }}
56+
restore-keys: ${{ runner.os }}-${{ hashFiles('.github/R-version') }}-1-
5057

5158
- name: Install system dependencies
5259
if: runner.os == 'Linux'
@@ -59,20 +66,27 @@ jobs:
5966
6067
- name: Install dependencies
6168
run: |
62-
Rscript -e "library(remotes)" -e "update(readRDS('depends.Rds'))" -e "remotes::install_cran('rcmdcheck')"
63-
Rscript -e "install.packages('.', type = 'source', repos = NULL)"
69+
remotes::install_deps(dependencies = TRUE)
70+
remotes::install_cran("rcmdcheck")
71+
install.packages(".", repos=NULL, type="source") ## needed by parallel workers
72+
shell: Rscript {0}
73+
74+
- name: Session info
75+
run: |
76+
options(width = 100)
77+
pkgs <- installed.packages()[, "Package"]
78+
sessioninfo::session_info(pkgs, include_base = TRUE)
79+
shell: Rscript {0}
6480

6581
- name: Check
66-
run: Rscript -e "rcmdcheck::rcmdcheck(args = '--no-manual', error_on = 'warning', check_dir = 'check')"
82+
env:
83+
_R_CHECK_CRAN_INCOMING_REMOTE_: false
84+
run: rcmdcheck::rcmdcheck(args = c("--no-manual", "--as-cran"), error_on = "warning", check_dir = "check")
85+
shell: Rscript {0}
6786

6887
- name: Upload check results
6988
if: failure()
7089
uses: actions/upload-artifact@master
7190
with:
7291
name: ${{ runner.os }}-r${{ matrix.config.r }}-results
7392
path: check
74-
75-
- name: Test coverage
76-
if: matrix.config.os == 'ubuntu-16.04' && matrix.config.r == '3.6-HIDE'
77-
run: |
78-
Rscript -e "install.packages('covr')" -e 'covr::codecov(token = "${{secrets.CODECOV_TOKEN}}")'

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
.ghi
1818
.issues
1919
.make
20+
.local
2021
revdep/data.sqlite
2122
revdep/checks/*
2223
revdep/library/*
24+
.github/

.travis.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ matrix:
5959
- covr
6060
script:
6161
- R CMD build --no-build-vignettes --no-manual .
62-
after_success:
6362
- Rscript -e 'covr::codecov(quiet=FALSE)'
6463
env: NB='w/ covr' ## Just a label
6564

DESCRIPTION

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
Package: future.batchtools
2-
Version: 0.9.0
2+
Version: 0.10.0
33
Depends:
44
R (>= 3.2.0),
5-
future (>= 1.14.0)
5+
future (>= 1.17.0)
66
Imports:
7-
batchtools (>= 0.9.11),
7+
batchtools (>= 0.9.13),
88
utils
99
Suggests:
1010
future.apply,
@@ -26,5 +26,5 @@ License: LGPL (>= 2.1)
2626
LazyLoad: TRUE
2727
URL: https://github.com/HenrikBengtsson/future.batchtools
2828
BugReports: https://github.com/HenrikBengtsson/future.batchtools/issues
29-
RoxygenNote: 7.1.0
29+
RoxygenNote: 7.1.1
3030
Roxygen: list(markdown = TRUE)

Makefile

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
11
include .make/Makefile
22

3+
spelling:
4+
$(R_SCRIPT) -e "spelling::spell_check_files(c('NEWS', dir('vignettes', pattern='[.]rsp', full.names=TRUE)), ignore=readLines('inst/WORDLIST', warn=FALSE))"
5+
36
future.tests/%:
47
$(R_SCRIPT) -e "future.tests::check" --args --test-plan=$*
58

69
future.tests: future.tests/future.batchtools\:\:batchtools_local
10+
11+
spelling:
12+
$(R_SCRIPT) -e "spelling::spell_check_package()"
13+
$(R_SCRIPT) -e "spelling::spell_check_files(c('NEWS', dir('vignettes', pattern='[.]rsp', full.names=TRUE)), ignore=readLines('inst/WORDLIST', warn=FALSE))"

NAMESPACE

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,13 @@
11
# Generated by roxygen2: do not edit by hand
22

3-
S3method(await,BatchtoolsFuture)
43
S3method(delete,BatchtoolsFuture)
5-
S3method(finished,BatchtoolsFuture)
64
S3method(loggedError,BatchtoolsFuture)
75
S3method(loggedOutput,BatchtoolsFuture)
86
S3method(nbrOfWorkers,batchtools)
97
S3method(print,BatchtoolsFuture)
108
S3method(resolved,BatchtoolsFuture)
119
S3method(result,BatchtoolsFuture)
1210
S3method(run,BatchtoolsFuture)
13-
S3method(status,BatchtoolsFuture)
1411
export("%resources%")
1512
export(BatchtoolsFuture)
1613
export(BatchtoolsFutureError)
@@ -23,10 +20,8 @@ export(batchtools_openlava)
2320
export(batchtools_sge)
2421
export(batchtools_slurm)
2522
export(batchtools_torque)
26-
export(finished)
2723
export(loggedError)
2824
export(loggedOutput)
29-
export(status)
3025
importFrom(batchtools,batchExport)
3126
importFrom(batchtools,batchMap)
3227
importFrom(batchtools,clearRegistry)

NEWS

Lines changed: 29 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,32 @@
11
Package: future.batchtools
22
==========================
33

4+
Version: 0.10.0 [2021-01-02]
5+
6+
SIGNIFICANT CHANGES:
7+
8+
* Lazy batchtools futures only creates the internal batchtools registry when
9+
the future is launched.
10+
11+
* Removed S3 generic functions await(), finished(), and status(), which were
12+
functions that were used for internal purposes.
13+
14+
DOCUMENTATION:
15+
16+
* Document option 'future.delete' and clarify option 'future.cache.path'
17+
in help("future.batchtools.options").
18+
19+
BUG FIXES:
20+
21+
* If run() was called twice for a BatchtoolsFuture, it would not produce
22+
a FutureError but only a regular non-classed error.
23+
24+
DEPRECATED AND DEFUNCT:
25+
26+
* Removed S3 generic functions await(), finished(), and status(), which were
27+
functions that were used for internal purposes.
28+
29+
430
Version: 0.9.0 [2020-04-14]
531

632
SIGNIFICANT CHANGES:
@@ -27,7 +53,7 @@ NEW FEATURES:
2753
available on all workers on a shared file system, e.g. plan(batchtools_nnn,
2854
registry = list(work.dir = "~")).
2955

30-
* It is possible to control if and how batchtools should use file compressions
56+
* It is possible to control if and how batchtools should use file compression
3157
for exported globals and results by specifying batchtools registry parameter
3258
'compress'. For example, to turn off file compression, use
3359
plan(batchtools_nnn, registry = list(compress = FALSE)).
@@ -112,8 +138,8 @@ BUG FIXES:
112138
* A bug was introduced in future.batchtools 0.7.0 that could result in "Error
113139
in readLog(id, reg = reg) : Log file for job with id 1 not available" when
114140
using one of the batchtools backends. It occurred when the value was
115-
queried. It was observered using 'batchtools_torque' but not when using
116-
'batchools_local'. This bug was missed because the 0.7.0 release was not
141+
queried. It was observed using 'batchtools_torque' but not when using
142+
'batchtools_local'. This bug was missed because the 0.7.0 release was not
117143
tested on an TORQUE/PBS HPC scheduler as it should have.
118144

119145

0 commit comments

Comments
 (0)