Skip to content

Commit 80f5da3

Browse files
Assert no positional arguments in more places
1 parent 932cdcb commit 80f5da3

File tree

5 files changed

+15
-3
lines changed

5 files changed

+15
-3
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
Package: future.batchtools
2-
Version: 0.10.0-9031
2+
Version: 0.10.0-9032
33
Depends:
44
R (>= 3.2.0),
55
parallelly,

R/BatchtoolsCustomFuture-class.R

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,11 @@
22
#' @export
33
BatchtoolsCustomFuture <- function(expr = NULL, substitute = TRUE, envir = parent.frame(), ...) {
44
if (substitute) expr <- substitute(expr)
5-
5+
assert_no_positional_args_but_first()
6+
67
future <- BatchtoolsFuture(expr = expr, substitute = FALSE, envir = envir, ...)
78
future <- structure(future, class = c("BatchtoolsCustomFuture", class(future)))
8-
9+
910
future
1011
}
1112

@@ -15,6 +16,7 @@ BatchtoolsCustomFuture <- function(expr = NULL, substitute = TRUE, envir = paren
1516
#' @export
1617
BatchtoolsBashFuture <- function(expr = NULL, substitute = TRUE, envir = parent.frame(), ...) {
1718
if (substitute) expr <- substitute(expr)
19+
assert_no_positional_args_but_first()
1820

1921
future <- BatchtoolsCustomFuture(expr = expr, substitute = FALSE, envir = envir, ..., workers = 1L)
2022
future <- structure(future, class = c("BatchtoolsBashFuture", "BatchtoolsUniprocessFuture", class(future)))

R/BatchtoolsFuture-class.R

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ BatchtoolsFuture <- function(expr = NULL, envir = parent.frame(),
6161
registry = list(),
6262
...) {
6363
if (substitute) expr <- substitute(expr)
64+
assert_no_positional_args_but_first()
6465

6566
## Record globals
6667
gp <- getGlobalsAndPackages(expr, envir = envir, globals = globals)

R/BatchtoolsMultiprocessFuture-class.R

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
#' @export
33
BatchtoolsMultiprocessFuture <- function(expr = NULL, substitute = TRUE, envir = parent.frame(), ...) {
44
if (substitute) expr <- substitute(expr)
5+
assert_no_positional_args_but_first()
56

67
future <- BatchtoolsFuture(expr = expr, substitute = FALSE, envir = envir, ...)
78
future <- structure(future, class = c("BatchtoolsMultiprocessFuture", class(future)))
@@ -14,6 +15,7 @@ BatchtoolsMultiprocessFuture <- function(expr = NULL, substitute = TRUE, envir =
1415
#' @export
1516
BatchtoolsMulticoreFuture <- function(expr = NULL, substitute = TRUE, envir = parent.frame(), ...) {
1617
if (substitute) expr <- substitute(expr)
18+
assert_no_positional_args_but_first()
1719

1820
future <- BatchtoolsMultiprocessFuture(expr = expr, substitute = FALSE, envir = envir, ...)
1921
future <- structure(future, class = c("BatchtoolsMulticoreFuture", class(future)))
@@ -26,6 +28,7 @@ BatchtoolsMulticoreFuture <- function(expr = NULL, substitute = TRUE, envir = pa
2628
#' @export
2729
BatchtoolsTemplateFuture <- function(expr = NULL, substitute = TRUE, envir = parent.frame(), ...) {
2830
if (substitute) expr <- substitute(expr)
31+
assert_no_positional_args_but_first()
2932

3033
future <- BatchtoolsMultiprocessFuture(expr = expr, substitute = FALSE, envir = envir, ...)
3134
future <- structure(future, class = c("BatchtoolsTemplateFuture", class(future)))
@@ -50,6 +53,7 @@ BatchtoolsLsfFuture <- function(expr = NULL, substitute = TRUE, envir = parent.f
5053
#' @export
5154
BatchtoolsOpenLavaFuture <- function(expr = NULL, substitute = TRUE, envir = parent.frame(), ...) {
5255
if (substitute) expr <- substitute(expr)
56+
assert_no_positional_args_but_first()
5357

5458
future <- BatchtoolsTemplateFuture(expr = expr, substitute = FALSE, envir = envir, ...)
5559
future <- structure(future, class = c("BatchtoolsOpenLavaFuture", class(future)))
@@ -62,6 +66,7 @@ BatchtoolsOpenLavaFuture <- function(expr = NULL, substitute = TRUE, envir = par
6266
#' @export
6367
BatchtoolsSGEFuture <- function(expr = NULL, substitute = TRUE, envir = parent.frame(), ...) {
6468
if (substitute) expr <- substitute(expr)
69+
assert_no_positional_args_but_first()
6570

6671
future <- BatchtoolsTemplateFuture(expr = expr, substitute = FALSE, envir = envir, ...)
6772
future <- structure(future, class = c("BatchtoolsSGEFuture", class(future)))
@@ -86,6 +91,7 @@ BatchtoolsSlurmFuture <- function(expr = NULL, substitute = TRUE, envir = parent
8691
#' @export
8792
BatchtoolsTorqueFuture <- function(expr = NULL, substitute = TRUE, envir = parent.frame(), ...) {
8893
if (substitute) expr <- substitute(expr)
94+
assert_no_positional_args_but_first()
8995

9096
future <- BatchtoolsTemplateFuture(expr = expr, substitute = FALSE, envir = envir, ...)
9197
future <- structure(future, class = c("BatchtoolsTorqueFuture", class(future)))

R/BatchtoolsUniprocessFuture-class.R

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
#' @export
33
BatchtoolsUniprocessFuture <- function(expr = NULL, substitute = TRUE, envir = parent.frame(), ...) {
44
if (substitute) expr <- substitute(expr)
5+
assert_no_positional_args_but_first()
56

67
future <- BatchtoolsFuture(expr = expr, substitute = FALSE, envir = envir, ..., workers = 1L)
78
future <- structure(future, class = c("BatchtoolsUniprocessFuture", class(future)))
@@ -14,6 +15,7 @@ BatchtoolsUniprocessFuture <- function(expr = NULL, substitute = TRUE, envir = p
1415
#' @export
1516
BatchtoolsLocalFuture <- function(expr = NULL, substitute = TRUE, envir = parent.frame(), ...) {
1617
if (substitute) expr <- substitute(expr)
18+
assert_no_positional_args_but_first()
1719

1820
future <- BatchtoolsUniprocessFuture(expr = expr, substitute = FALSE, envir = envir, ...)
1921
future <- structure(future, class = c("BatchtoolsLocalFuture", class(future)))
@@ -26,6 +28,7 @@ BatchtoolsLocalFuture <- function(expr = NULL, substitute = TRUE, envir = parent
2628
#' @export
2729
BatchtoolsInteractiveFuture <- function(expr = NULL, substitute = TRUE, envir = parent.frame(), ...) {
2830
if (substitute) expr <- substitute(expr)
31+
assert_no_positional_args_but_first()
2932

3033
future <- BatchtoolsUniprocessFuture(expr = expr, substitute = FALSE, envir = envir, ...)
3134
future <- structure(future, class = c("BatchtoolsInteractiveFuture", class(future)))

0 commit comments

Comments
 (0)