Skip to content

Commit 0b8b092

Browse files
CLEANUP: Drop argument '.signalEarly = TRUE' (default) from signalEarly(), because this function is always called with the default arguments
1 parent 2f32d32 commit 0b8b092

File tree

2 files changed

+5
-12
lines changed

2 files changed

+5
-12
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
Package: future
2-
Version: 1.68.0-9026
2+
Version: 1.68.0-9027
33
Title: Unified Parallel and Distributed Processing in R for Everyone
44
Depends:
55
R (>= 3.2.0)

R/utils-signalEarly.R

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,24 +2,18 @@
22
#'
33
#' @param future A [Future] object.
44
#'
5-
#' @param .signalEarly (logical) If TRUE, and the future results have been
6-
#' collected, any non-signaled conditions are signaled.
7-
#'
85
#' @param \ldots ... Not used.
96
#'
107
#' @return The `future` object.
118
#'
129
#' @details
1310
#' This function returns immediately ("no-op"), if the future (i) is _not_
1411
#' flagged for early signaling, or (ii) not resolved.
15-
#' Otherwise, the future results are collected. Then, nothing is signaled, if:
16-
#' * no conditions were captured, or
17-
#' * `.signalEarly = FALSE`.
18-
#' Otherwise, captured conditions are signaled, unless they have been
19-
#' signaled previously.
12+
#' Otherwise, the future results are collected and any captured conditions
13+
#' are signaled, unless they have been signaled previously.
2014
#'
2115
#' @noRd
22-
signalEarly <- function(future, .signalEarly = TRUE, ...) {
16+
signalEarly <- function(future, ...) {
2317
## Don't signal early?
2418
if (!isTRUE(future[["earlySignal"]])) return(future)
2519

@@ -44,9 +38,8 @@ signalEarly <- function(future, .signalEarly = TRUE, ...) {
4438
conditions <- result[["conditions"]]
4539

4640
## Nothing to do?
47-
if (!.signalEarly || length(conditions) == 0L) {
41+
if (length(conditions) == 0L) {
4842
if (debug) {
49-
if (!.signalEarly) mdebug("Skipping because .signalEarly = FALSE")
5043
if (length(conditions) == 0L) mdebug("No conditions to signal")
5144
mdebug_pop()
5245
}

0 commit comments

Comments
 (0)