Use x[["name"]] instead of x$name through the code; consistency + slightly faster

Author: HenrikBengtsson

R/000.bquote.R

@@ -95,8 +95,8 @@ bquote_apply <- function(tmpl, envir = parent.frame()) {
 
   for (kk in seq_along(tmpl)) {
     entry <- tmpl[[kk]]
-    value <- eval(entry$expression, envir = envir)
-    at <- entry$at
+    value <- eval(entry[["expression"]], envir = envir)
+    at <- entry[["at"]]
 
     ## Special case: Result becomes just a value
     nat <- length(at)

R/backend_api-ClusterFuture-class.R

@@ -121,7 +121,7 @@ getSocketSelectTimeout <- function(future, timeout = NULL) {
   ## in infinite waiting (PR17203).  Fixed in R devel r73470 (2017-10-05)
   ## and R 3.4.3
   ## Source: https://github.com/HenrikBengtsson/Wishlist-for-R/issues/35
-  if (.Platform$OS.type != "windows" && getRversion() < "3.4.3") {
+  if (.Platform[["OS.type"]] != "windows" && getRversion() < "3.4.3") {
     timeout <- round(timeout, digits = 0L)
   }
   attr(timeout, "validated") <- TRUE
@@ -143,8 +143,8 @@ resolved.ClusterFuture <- function(x, run = TRUE, timeout = NULL, ...) {
   future <- x
   backend <- future[["backend"]]
   stop_if_not(inherits(backend, "FutureBackend"))
-  workers <- backend$workers
-  reg <- backend$reg
+  workers <- backend[["workers"]]
+  reg <- backend[["reg"]]
 
   ## A lazy future not even launched?
   if (future[["state"]] == "created") {
@@ -157,7 +157,7 @@ resolved.ClusterFuture <- function(x, run = TRUE, timeout = NULL, ...) {
       ## Find which nodes are available
       avail <- rep(TRUE, times = length(workers))
       futures <- FutureRegistry(reg, action = "list", earlySignal = FALSE)
-      nodes <- unlist(lapply(futures, FUN = function(f) f$node), use.names = FALSE)
+      nodes <- unlist(lapply(futures, FUN = function(f) f[["node"]]), use.names = FALSE)
       avail[nodes] <- FALSE
       if (debug) mdebug(" - avail: [n=%d] %s", length(avail), commaq(avail))
 
@@ -185,7 +185,7 @@ resolved.ClusterFuture <- function(x, run = TRUE, timeout = NULL, ...) {
   node <- cl[[1]]
 
   ## Check if workers socket connection is available for reading
-  if (!is.null(con <- node$con)) {
+  if (!is.null(con <- node[["con"]])) {
     ## AD HOC/SPECIAL CASE: Skip if connection has been serialized and lacks
     ## internal representation. /HB 2018-10-27
     connId <- connectionId(con)
@@ -200,7 +200,7 @@ resolved.ClusterFuture <- function(x, run = TRUE, timeout = NULL, ...) {
       ## n infinite waiting (PR17203).  Fixed in R devel r73470 (2017-10-05)
       ## and R 3.4.3
       ## Source: https://github.com/HenrikBengtsson/Wishlist-for-R/issues/35
-      if (!isTRUE(attr(timeout, "validated", exact = TRUE)) && .Platform$OS.type != "windows" && getRversion() < "3.4.3") {
+      if (!isTRUE(attr(timeout, "validated", exact = TRUE)) && .Platform[["OS.type"]] != "windows" && getRversion() < "3.4.3") {
         timeout <- round(timeout, digits = 0L)
       }
     }
@@ -296,8 +296,8 @@ receiveMessageFromWorker <- function(future, ...) {
   if (!inherits(backend, "FutureBackend") && !is.list(backend)) {
     stop(sprintf("[INTERNAL ERROR] receiveMessageFromWorker(): the 'backend' element of the %s object is neither a FutureBackend object nor a list: %s", class(future)[1], class(backend)[1]))
   }
-  workers <- backend$workers
-  reg <- backend$reg
+  workers <- backend[["workers"]]
+  reg <- backend[["reg"]]
 
   node_idx <- future[["node"]]
   if (debug) mdebugf(" - cluster node index: %d", node_idx)
@@ -318,7 +318,7 @@ receiveMessageFromWorker <- function(future, ...) {
   if (inherits(ack, "error")) {
     if (debug) mdebugf("- parallel:::recvResult() produced an error: %s", conditionMessage(ack))
     msg <- post_mortem_cluster_failure(ack, when = "receive message results from", node = node, future = future)
-    ex <- FutureError(msg, call = ack$call, future = future)
+    ex <- FutureError(msg, call = ack[["call"]], future = future)
     future[["result"]] <- ex
     stop(ex)          
   }
@@ -367,7 +367,7 @@ receiveMessageFromWorker <- function(future, ...) {
     ## they will be resignaled each time value() is called.
     signaled <- future[[".signaledConditions"]]
     if (length(signaled) > 0) {
-      result$conditions <- c(future[[".signaledConditions"]], result$conditions)
+      result[["conditions"]] <- c(future[[".signaledConditions"]], result[["conditions"]])
       future[[".signaledConditions"]] <- NULL
     }
 
@@ -430,9 +430,9 @@ receiveMessageFromWorker <- function(future, ...) {
     }
 
     ## Increment signal count
-    signaled <- condition$signaled
+    signaled <- condition[["signaled"]]
     if (is.null(signaled)) signaled <- 0L
-    condition$signaled <- signaled + 1L
+    condition[["signaled"]] <- signaled + 1L
 
     ## Record condition as signaled
     signaled <- future[[".signaledConditions"]]
@@ -562,13 +562,13 @@ post_mortem_cluster_failure <- function(ex, when, node, future) {
   ## (2) Information on the cluster node
 
   ## (a) Process information on the worker, if available
-  pid <- node$session_info$process$pid
+  pid <- node[["session_info"]][["process"]][["pid"]]
   pid_info <- if (is.numeric(pid)) sprintf("PID %.0f", pid) else NULL
 
   ## (b) Host information on the worker, if available
   ##     AD HOC: This assumes that the worker has a hostname, which is not
   ##     the case for MPI workers. /HB 2017-03-07
-  host <- node$host
+  host <- node[["host"]]
   localhost <- isTRUE(attr(host, "localhost", exact = TRUE))
   host_info <- if (!is.null(host)) {
     sprintf("on %s%s", if (localhost) "localhost " else "", sQuote(host))
@@ -589,7 +589,7 @@ post_mortem_cluster_failure <- function(ex, when, node, future) {
 
   ## (a) Inspect the 'reason' for known clues
   if (grepl("ignoring SIGPIPE signal", reason)) {
-    postmortem$sigpipe <- "The SIGPIPE error suggests that the R socket connection to the parallel worker broke, which can happen for different reasons, e.g. the parallel worker crashed"
+    postmortem[["sigpipe"]] <- "The SIGPIPE error suggests that the R socket connection to the parallel worker broke, which can happen for different reasons, e.g. the parallel worker crashed"
   }
 
   ## (a) Did the worker process terminate?
@@ -615,20 +615,20 @@ post_mortem_cluster_failure <- function(ex, when, node, future) {
         msg2 <- "No process exists with this PID on the remote host, i.e. the remote worker is no longer alive"
       }
     }
-    postmortem$alive <- msg2
+    postmortem[["alive"]] <- msg2
   }
 
   ## (b) Did the worker use a connection that changed?
-  if (inherits(node$con, "connection")) {
-    postmortem$connection <- check_connection_details(node, future = future)
+  if (inherits(node[["con"]], "connection")) {
+    postmortem[["connection"]] <- check_connection_details(node, future = future)
   }
 
   ## (c) Any non-exportable globals?
   globals <- future[["globals"]]
-  postmortem$non_exportable <- assert_no_references(globals, action = "string")
+  postmortem[["non_exportable"]] <- assert_no_references(globals, action = "string")
 
   ## (d) Size of globals
-  postmortem$global_sizes <- summarize_size_of_globals(globals)
+  postmortem[["global_sizes"]] <- summarize_size_of_globals(globals)
 
   ## (5) The final error message
   msg <- sprintf("%s (%s) failed to %s %s. The reason reported was %s",
@@ -701,11 +701,11 @@ assertValidConnection <- function(future) {
   node_idx <- future[["node"]]
   if (debug) mdebugf(" - cluster node index: %d", node_idx)
 
-  cl <- backend$workers[node_idx]
+  cl <- backend[["workers"]][node_idx]
   node <- cl[[1]]
 
   ## Nothing to do?
-  if (is.null(con <- node$con)) return()
+  if (is.null(con <- node[["con"]])) return()
 
   ## AD HOC/SPECIAL CASE: Skip if connection has been serialized and lacks internal representation. /HB 2018-10-27
   connId <- connectionId(con)

R/backend_api-Future-class.R

@@ -132,13 +132,13 @@ Future <- function(expr = NULL, envir = parent.frame(), substitute = TRUE, stdou
       ## Global objects?
       ## 'persistent' is only allowed for ClusterFuture:s, which will be
       ## asserted when run() is called /HB 2023-01-17
-      gp <- getGlobalsAndPackages(expr, envir = envir, tweak = tweakExpression, globals = globals, persistent = isTRUE(args$persistent))
-      globals <- gp$globals
-      expr <- gp$expr
+      gp <- getGlobalsAndPackages(expr, envir = envir, tweak = tweakExpression, globals = globals, persistent = isTRUE(args[["persistent"]]))
+      globals <- gp[["globals"]]
+      expr <- gp[["expr"]]
 
       ## Record packages?
-      if (length(packages) > 0 || (length(gp$packages) > 0 && lazy)) {
-        packages <- c(gp$packages, packages)
+      if (length(packages) > 0 || (length(gp[["packages"]]) > 0 && lazy)) {
+        packages <- c(gp[["packages"]], packages)
       }
 
       gp <- NULL
@@ -202,7 +202,7 @@ Future <- function(expr = NULL, envir = parent.frame(), substitute = TRUE, stdou
   core <- new.env(parent = emptyenv())
 
   ## Version of future
-  version <- args$version
+  version <- args[["version"]]
   if (is.null(version)) version <- "1.8"
   core[["version"]] <- version
 
@@ -331,16 +331,16 @@ print.Future <- function(x, ...) {
 
   if (hasResult) {
     if (inherits(result, "FutureResult")) {
-      value <- result$value
+      value <- result[["value"]]
     } else if ("value" %in% names(future)) {
       .Defunct(msg = sprintf("Detected a %s object that rely on the defunct 'value' field of format version 1.7 or before.", class(future)[1]), package = .packageName)
     } else {
       stop(FutureError(sprintf("The %s object does not have a 'results' field", class(future)[1]), future = future))
     }
     cat(sprintf("Value: %s of class %s\n", asIEC(objectSize(value)), sQuote(class(value)[1])))
     if (inherits(result, "FutureResult")) {
-      conditions <- result$conditions
-      conditionClasses <- vapply(conditions, FUN = function(c) class(c$condition)[1], FUN.VALUE = NA_character_)
+      conditions <- result[["conditions"]]
+      conditionClasses <- vapply(conditions, FUN = function(c) class(c[["condition"]])[1], FUN.VALUE = NA_character_)
       cat(sprintf("Conditions captured: [n=%d] %s\n", length(conditionClasses), hpaste(sQuote(conditionClasses))))
     }
   } else {
@@ -358,8 +358,8 @@ assertOwner <- local({
   hpid <- function(uuid) {
     info <- attr(uuid, "source", exact = TRUE)
     if (is.null(info)) info <- list(pid = NA_integer_, host = NA_character_)
-    stop_if_not(is.list(info), length(info$pid) == 1L, length(info$host) == 1L)
-    pid <- sprintf("%s; pid %d on %s", uuid, info$pid, info$host)
+    stop_if_not(is.list(info), length(info[["pid"]]) == 1L, length(info[["host"]]) == 1L)
+    pid <- sprintf("%s; pid %d on %s", uuid, info[["pid"]], info[["host"]])
     stop_if_not(length(pid) == 1L)
     pid
   }
@@ -466,7 +466,7 @@ run.Future <- function(future, ...) {
 
   ## SPECIAL: 'cluster' takes argument 'persistent' for now /HB 2023-01-17
   has_persistent <- ("persistent" %in% names(future))
-  if (has_persistent) args$persistent <- future[["persistent"]]
+  if (has_persistent) args[["persistent"]] <- future[["persistent"]]
 
   tmpFuture <- do.call(evaluator, args = args)
 
@@ -812,7 +812,7 @@ getFutureContext <- function(future, mc.cores = NULL, local = TRUE, ..., debug =
   )
 
   if (!is.null(mc.cores)) {
-    forwardOptions$mc.cores <- mc.cores
+    forwardOptions[["mc.cores"]] <- mc.cores
   }
 
   reset <- future[["reset"]]
@@ -930,7 +930,7 @@ getFutureBackendConfigs.ClusterFuture <- function(future, ..., debug = isTRUE(ge
   stop_if_not(inherits(cl, "cluster"))
   node <- cl[[1L]]
   stop_if_not(inherits(node, c("SOCK0node", "SOCKnode")))
-  con <- node$con
+  con <- node[["con"]]
   if (is.null(con)) return(list())
 
   capture <- list(
@@ -957,7 +957,7 @@ getFutureData <- function(future, ..., debug = isTRUE(getOption("future.debug"))
   data <- list(
        core = getFutureCore(future, debug = debug),
     capture = getFutureCapture(future, debug = debug),
-    context = getFutureContext(future, mc.cores = args$mc.cores, local = args$local, debug = debug)
+    context = getFutureContext(future, mc.cores = args[["mc.cores"]], local = args[["local"]], debug = debug)
   )
 
   ## Tweak per backend?

R/backend_api-FutureBackend-class.R

@@ -59,8 +59,8 @@ makeFutureBackend <- function(evaluator, ...) {
   args <- attr(evaluator, "tweaks")
   if (is.null(args)) args <- list()
   args2 <- formals(evaluator)
-  args2$`...` <- NULL
-  args2$envir <- NULL
+  args2[["..."]] <- NULL
+  args2[["envir"]] <- NULL
   args2$lazy <- NULL         ## bc multisession; should be removed
   for (name in names(args2)) {
     args[[name]] <- args2[[name]]

R/backend_api-FutureRegistry.R

@@ -94,7 +94,7 @@ FutureRegistry <- local({
     ## Early signaling of conditions?
     if (earlySignal && length(futures) > 0L) {
       ## Which futures have early signaling enabled?
-      idxs <- lapply(futures, FUN = function(f) f$earlySignal)
+      idxs <- lapply(futures, FUN = function(f) f[["earlySignal"]])
       idxs <- which(unlist(idxs, use.names = FALSE))
 
       ## Any futures to be scanned for early signaling?

R/backend_api-MulticoreFuture-class.R

@@ -114,14 +114,14 @@ result.MulticoreFuture <- function(future, ...) {
   if (!inherits(result, "FutureResult")) {
     if (debug) mdebugf("Detected non-FutureResult result ...")
     alive <- NA
-    pid <- job$pid
+    pid <- job[["pid"]]
     if (is.numeric(pid)) {
       pid_exists <- import_parallelly("pid_exists")
       alive <- pid_exists(pid)
     }
 
     ## AD HOC: Record whether the forked process is alive or not
-    job$alive <- alive
+    job[["alive"]] <- alive
     future[["job"]] <- job
 
     ## SPECIAL: Check for fallback 'fatal error in wrapper code'
@@ -152,14 +152,14 @@ result.MulticoreFuture <- function(future, ...) {
         } else {
           msg2 <- "No process exists with this PID, i.e. the forked localhost worker is no longer alive"
         }
-        postmortem$alive <- msg2
+        postmortem[["alive"]] <- msg2
       }
 
       ## (c) Any non-exportable globals?
-      postmortem$non_exportable <- assert_no_references(future, action = "string")
+      postmortem[["non_exportable"]] <- assert_no_references(future, action = "string")
 
       ## (d) Size of globals
-      postmortem$global_sizes <- summarize_size_of_globals(future[["globals"]])
+      postmortem[["global_sizes"]] <- summarize_size_of_globals(future[["globals"]])
 
       postmortem <- unlist(postmortem, use.names = FALSE)
       if (!is.null(postmortem)) {
@@ -199,7 +199,7 @@ result.MulticoreFuture <- function(future, ...) {
   future[[".signaledConditions"]] <- signaled
 
   ## Record conditions
-  result$conditions <- c(result$conditions, signaled)
+  result[["conditions"]] <- c(result[["conditions"]], signaled)
   signaled <- NULL
 
   future[["result"]] <- result

R/backend_api-SequentialFutureBackend-class.R

@@ -29,7 +29,7 @@ launchFuture.SequentialFutureBackend <- function(backend, future, ...) {
 
   ## Apply backend tweaks
   split <- backend[["split"]]
-  if (!is.null(split)) data$capture$split <- split
+  if (!is.null(split)) data[["capture"]][["split"]] <- split
   earlySignal <- backend[["earlySignal"]]
   if (!is.null(earlySignal)) future[["earlySignal"]] <- earlySignal