Don't use invisible(), if not needed

Author: HenrikBengtsson

R/backend_api-ClusterFutureBackend-class.R

@@ -284,7 +284,7 @@ launchFuture.ClusterFutureBackend <- function(backend, future, ...) {
 
   if (debug) mdebugf("%s started", class(future)[1])
 
-  invisible(future)
+  future
 }
 
 
@@ -360,7 +360,7 @@ ClusterRegistry <- local({
       last <<- NULL
     }
 
-    invisible(cluster)
+    cluster
   }
 }) ## ClusterRegistry()
 

R/backend_api-FutureRegistry.R

@@ -43,7 +43,7 @@ FutureRegistry <- local({
       }
     } ## for (ii ...)
 
-    invisible(futures)
+    futures
   } ## collectValues()
 
 

R/backend_api-MulticoreFutureBackend-class.R

@@ -194,7 +194,7 @@ requestCore <- function(await, workers = availableCores(), timeout = getOption("
     stop(msg)
   }
 
-  invisible(unname(finished))
+  unname(finished)
 }
 
 #' A MulticoreFutureBackend resolves futures in parallel using forked processing on the current machine
@@ -289,7 +289,7 @@ launchFuture.MulticoreFutureBackend <- local({
 
     if (debug) mdebugf("%s started", class(future)[1])
 
-    invisible(future)
+    future
   }
 })
 

R/backend_api-UniprocessFuture-class.R

@@ -48,7 +48,7 @@ run.UniprocessFuture <- function(future, ...) {
   ## Signal conditions early, iff specified for the given future
   signalEarly(future, collect = FALSE)
 
-  invisible(future)
+  future
 }
 
 

R/protected_api-journal.R

@@ -280,7 +280,7 @@ makeFutureJournal <- function(x, event = "create", category = "other", parent =
   data <- data.frame(event = event, category = category, parent = parent, start = start, stop = stop)
   class(data) <- c("FutureJournal", class(data))
   x[[".journal"]] <- data
-  invisible(x)
+  x
 }
 
 updateFutureJournal <- function(x, event, start = NULL, stop = Sys.time()) {
@@ -306,7 +306,7 @@ updateFutureJournal <- function(x, event, start = NULL, stop = Sys.time()) {
   data[row, ] <- entry
   stop_if_not(inherits(data, "FutureJournal"))
   x[[".journal"]] <- data
-  invisible(x)
+  x
 }
 
 
@@ -327,7 +327,7 @@ appendToFutureJournal <- function(x, event, category = "other", parent = NA_char
 
   data <- data.frame(event = event, category = category, parent = parent, start = start, stop = stop)
   x[[".journal"]] <- rbind(x[[".journal"]], data)
-  invisible(x)
+  x
 }
 
 

R/protected_api-signalConditions.R

@@ -26,7 +26,7 @@
 #' @keywords internal
 signalConditions <- function(future, include = "condition", exclude = NULL, resignal = TRUE, ...) {
   ## Nothing to do?
-  if (length(include) == 0L) return(invisible(future))
+  if (length(include) == 0L) return(future)
 
   ## Future is not yet launched
   if (!future[["state"]] %in% c("finished", "failed", "interrupted")) {
@@ -43,7 +43,7 @@ signalConditions <- function(future, include = "condition", exclude = NULL, resi
   conditions <- result[["conditions"]]
 
   ## Nothing to do
-  if (length(conditions) == 0) return(invisible(future))
+  if (length(conditions) == 0) return(future)
 
   debug <- isTRUE(getOption("future.debug"))
 
@@ -109,7 +109,7 @@ signalConditions <- function(future, include = "condition", exclude = NULL, resi
         future <- resetFuture(backend, future)
       }
       warning(FutureInterruptWarning(msg, future = future))
-      return(invisible(future))
+      return(future)
     } else if (inherits(condition, "warning")) {
       warning(condition)
     } else if (inherits(condition, "message")) {
@@ -131,7 +131,7 @@ signalConditions <- function(future, include = "condition", exclude = NULL, resi
   result[["conditions"]] <- conditions
   future[["result"]] <- result
 
-  invisible(future)
+  future
 }
 
 
@@ -145,7 +145,7 @@ signalImmediateConditions <- function(future, include = NULL, resignal = FALSE,
       if (is.null(include)) include <- "immediateCondition"
     }
   }
-  if (length(include) == 0L) return(invisible(future))
+  if (length(include) == 0L) return(future)
   signalConditions(future, include = include, resignal = resignal, ...)
 }
 
@@ -284,5 +284,5 @@ muffleCondition <- function(cond, pattern = "^muffle") {
     }
   }
 
-  invisible(muffled)
+  muffled
 } ## muffleCondition()

R/utils-basic.R

@@ -185,7 +185,7 @@ assign_globals <- function(envir, globals, exclude = getOption("future.assign_gl
 
   if (debug) mdebug("assign_globals() ... done")
 
-  invisible(envir)
+  envir
 }
 
 
@@ -231,14 +231,14 @@ grmall <- local(function(envir = .GlobalEnv) {
   vars <- ls(envir = envir, all.names = TRUE)
   rm(list = vars, envir = envir, inherits = FALSE)
   ## Return a value identifiable for troubleshooting purposes
-  invisible("future-grmall")
+  "future-grmall"
 })
 
 ## Assigns a value to the global environment.
 gassign <- local(function(name, value, envir = .GlobalEnv) {
   assign(name, value = value, envir = envir)
   ## Return a value identifiable for troubleshooting purposes
-  invisible("future-grassign")
+  "future-grassign"
 })
 
 ## Evaluates an expression in global environment.

R/utils-immediateCondition.R

@@ -115,7 +115,7 @@ readImmediateConditions <- function(path = immediateConditionsPath(rootPath = ro
   ## Remove files?
   if (remove && length(files) > 0L) file.remove(files)
 
-  invisible(conds)
+  conds
 }
 
 
@@ -146,7 +146,7 @@ saveImmediateCondition <- function(cond, path = immediateConditionsPath(rootPath
 #'
 #' @param \ldots (optional) Additional arguments passed to [base::saveRDS()].
 #'
-#' @return (invisible) The pathname of the RDS written.
+#' @return The pathname of the RDS written.
 #'
 #' @details
 #' Uses [base::saveRDS] internally but writes the object atomically by first
@@ -185,7 +185,7 @@ save_rds <- function(object, pathname, ...) {
     stop(msg)
   }
 
-  invisible(pathname)
+  pathname
 }
 
 

R/utils-signalEarly.R

@@ -44,5 +44,5 @@ signalEarly <- function(future, collect = TRUE, .signalEarly = TRUE, ...) {
 
   if (debug) mdebug("signalEarly() ... DONE")
 
-  invisible(future)
+  future
 }