Skip to content

Commit 6810ac5

Browse files
GHA: check also 'shiny' with NOT_CRAN=false because of expect_snapshot() tests
1 parent 39b6fe9 commit 6810ac5

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

.github/workflows/revdepcheck-top.yaml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ jobs:
2121
- { r: "release", pkg: "future.mirai" }
2222
- { r: "release", pkg: "doFuture" }
2323
- { r: "release", pkg: "future.apply" }
24-
- { r: "release", pkg: "furrr" }
24+
- { r: "release", pkg: "furrr", not_cran: false }
2525
- { r: "release", pkg: "future.tests" }
2626
- { r: "release", pkg: "promises" }
27-
- { r: "release", pkg: "shiny" }
27+
- { r: "release", pkg: "shiny", not_cran: false }
2828
- { r: "release", pkg: "plumber" }
2929
- { r: "release", pkg: "future.batchtools" , globals: develop, label: 'globals develop' }
3030
- { r: "release", pkg: "future.callr" , globals: develop, label: 'globals develop' }
@@ -50,7 +50,7 @@ jobs:
5050
R_FUTURE_PLAN: ${{ matrix.config.plan }}
5151
R_FUTURE_GLOBALS_KEEPWHERE: ${{ matrix.config.globals_keepWhere }}
5252
R_GLOBALS_BRANCH: ${{ matrix.config.globals }}
53-
NOT_CRAN: true
53+
NOT_CRAN: ${{ matrix.config.not_cran || 'true' }}
5454

5555
steps:
5656
- uses: actions/checkout@v4
@@ -93,10 +93,6 @@ jobs:
9393
run: |
9494
url=$(Rscript -e "cat(remotes:::download_version_url('${{ matrix.config.pkg }}', version=NULL, repos='https://cloud.r-project.org', type='source'))")
9595
wget "$url"
96-
## Specific to furrr (to disable expect_snapshot() tests)
97-
if [[ "${{ matrix.config.pkg }}" == "furrr" ]]; then
98-
export NOT_CRAN=false
99-
fi
10096
R CMD check --no-manual --as-cran "$(basename "$url")"
10197
10298
- name: Upload check results

0 commit comments

Comments
 (0)