BUG FIX: future() argument 'stdout' was not used when loading packages [#789]

Author: HenrikBengtsson

DESCRIPTION

@@ -1,5 +1,5 @@
 Package: future
-Version: 1.49.0-9027
+Version: 1.49.0-9028
 Title: Unified Parallel and Distributed Processing in R for Everyone
 Depends:
     R (>= 3.2.0)

NEWS.md

@@ -22,11 +22,11 @@
    worker causes warnings to be escalated immediately to errors on the
    worker, which therefore also terminates the future.
 
- * `future()` argument `conditions` was not used when loading and
-   attaching packages specified via argument `packages`, which
-   prevented us from excluding, for instance,
-   `packageStartupMessage`:s, causing them to be displayed in
-   sequential and multicore processing.
+ * `future()` arguments `stdout` and `conditions` were not applied
+   when packages that are specified via argument `packages` where
+   loaded and attached. This prevented us from excluding, for
+   instance, `packageStartupMessage`:s, causing them to be displayed
+   in sequential and multicore processing.
 
  * Now the ClusterFutureBackend tries even harder to shut down
    parallel cluster workers when shutting down the backend. If it

R/backend_api-evalFuture.R

@@ -625,6 +625,33 @@ evalFutureInternal <- function(data) {
   ...future.conditions <- list()
 
 
+  ## -----------------------------------------------------------------
+  ## Ignore, capture or discard standard output?
+  ## -----------------------------------------------------------------
+  if (is.na(stdout)) {  ## stdout = NA
+    ## Don't capture, but also don't block any output
+  } else {
+    if (stdout) {  ## stdout = TRUE
+      ## Capture all output
+      ## NOTE: Capturing to a raw connection is much more efficient
+      ## than to a character connection, cf.
+      ## https://www.jottr.org/2014/05/26/captureoutput/
+      ...future.stdout <- rawConnection(raw(0L), open = "w")
+    } else {  ## stdout = FALSE
+      ## Silence all output by sending it to the void
+      ...future.stdout <- file(
+        switch(.Platform[["OS.type"]], windows = "NUL", "/dev/null"),
+        open = "w"
+      )
+    }
+    sink(...future.stdout, type = "output", split = split)
+    on.exit(if (!is.null(...future.stdout)) {
+      sink(type = "output", split = split)
+      close(...future.stdout)
+    }, add = TRUE)
+  }
+
+
   ## -----------------------------------------------------------------
   ## Load and attached backend packages
   ## -----------------------------------------------------------------
@@ -855,29 +882,6 @@ evalFutureInternal <- function(data) {
     expr <- bquote_apply(tmpl_expr_local)
   }
 
-  ## Ignore, capture or discard standard output?
-  if (is.na(stdout)) {  ## stdout = NA
-    ## Don't capture, but also don't block any output
-  } else {
-    if (stdout) {  ## stdout = TRUE
-      ## Capture all output
-      ## NOTE: Capturing to a raw connection is much more efficient
-      ## than to a character connection, cf.
-      ## https://www.jottr.org/2014/05/26/captureoutput/
-      ...future.stdout <- rawConnection(raw(0L), open = "w")
-    } else {  ## stdout = FALSE
-      ## Silence all output by sending it to the void
-      ...future.stdout <- file(
-        switch(.Platform[["OS.type"]], windows = "NUL", "/dev/null"),
-        open = "w"
-      )
-    }
-    sink(...future.stdout, type = "output", split = split)
-    on.exit(if (!is.null(...future.stdout)) {
-      sink(type = "output", split = split)
-      close(...future.stdout)
-    }, add = TRUE)
-  }
 
   ## Prevent 'future.plan' / R_FUTURE_PLAN settings from being nested
   options(future.plan = NULL)