Skip to content

Commit 3282171

Browse files
clarify that 'milestones' is a vector + spacing
1 parent 6b61181 commit 3282171

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

R/make_progression_handler.R

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -259,14 +259,14 @@ make_progression_handler <- function(name, reporter = list(), handler = NULL, en
259259
if (type == "reset") {
260260
max_steps <<- NULL
261261
step <<- NULL
262-
message <<- NULL
262+
message <<- NULL
263263
auto_finish <<- TRUE
264264
timestamps <<- NULL
265265
milestones <<- NULL
266266
prev_milestone <<- NULL
267267
enabled <<- FALSE
268268
finished <<- FALSE
269-
owner <<- NULL
269+
owner <<- NULL
270270
done <<- list()
271271
reset_reporter(p)
272272
.validate_internal_state(sprintf("handler(type=%s) ... end", type))
@@ -280,11 +280,11 @@ make_progression_handler <- function(name, reporter = list(), handler = NULL, en
280280
unhide_reporter(p)
281281
.validate_internal_state(sprintf("handler(type=%s) ... end", type))
282282
} else {
283-
stop("Unknown control_progression type: ", sQuote(type))
284-
}
283+
stop("Unknown control_progression type: ", sQuote(type))
284+
}
285285
.validate_internal_state(sprintf("control_progression ... end", type))
286286
return(invisible())
287-
}
287+
}
288288

289289
## Ignore stray progressions coming from other sources, e.g.
290290
## a function of a package that started to report on progression.
@@ -313,8 +313,8 @@ make_progression_handler <- function(name, reporter = list(), handler = NULL, en
313313

314314
if (type == "initiate") {
315315
max_steps <<- p$steps
316-
if (debug) mstr(list(max_steps=max_steps))
317-
stop_if_not(!is.null(max_steps), is.numeric(max_steps), length(max_steps) == 1L, max_steps >= 1)
316+
if (debug) mstr(list(max_steps=max_steps))
317+
stop_if_not(!is.null(max_steps), is.numeric(max_steps), length(max_steps) == 1L, max_steps >= 1)
318318
auto_finish <<- p$auto_finish
319319
times <- min(times, max_steps)
320320
if (debug) mstr(list(auto_finish = auto_finish, times = times, interval = interval, intrusiveness = intrusiveness))
@@ -325,14 +325,14 @@ make_progression_handler <- function(name, reporter = list(), handler = NULL, en
325325
interval <- interval * intrusiveness
326326

327327
milestones <<- if (times == 1L) {
328-
max_steps
329-
} else {
330-
seq(from = 1L, to = max_steps, length.out = times)
331-
}
328+
c(max_steps)
329+
} else {
330+
seq(from = 1L, to = max_steps, length.out = times)
331+
}
332332
timestamps <<- rep(as.POSIXct(NA), times = max_steps)
333333
timestamps[1] <<- Sys.time()
334334
step <<- 0L
335-
message <<- character(0L)
335+
message <<- character(0L)
336336
if (debug) mstr(list(finished = finished, milestones = milestones))
337337
initiate_reporter(p)
338338
prev_milestone <<- step
@@ -344,14 +344,14 @@ make_progression_handler <- function(name, reporter = list(), handler = NULL, en
344344
prev_milestone <<- max_steps
345345
.validate_internal_state()
346346
} else if (type == "update") {
347-
if (debug) mstr(list(step=step, "p$amount"=p$amount, max_steps=max_steps))
347+
if (debug) mstr(list(step=step, "p$amount"=p$amount, max_steps=max_steps))
348348
step <<- min(max(step + p$amount, 0L), max_steps)
349-
stop_if_not(step >= 0L)
349+
stop_if_not(step >= 0L)
350350
msg <- conditionMessage(p)
351351
if (length(msg) > 0) message <<- msg
352352
timestamps[step] <<- Sys.time()
353353
if (debug) mstr(list(finished = finished, step = step, milestones = milestones, prev_milestone = prev_milestone, interval = interval))
354-
if (length(milestones) > 0L && step >= milestones[1]) {
354+
if (length(milestones) > 0L && step >= milestones[1]) {
355355
skip <- FALSE
356356
if (interval > 0) {
357357
dt <- difftime(timestamps[step], timestamps[max(prev_milestone, 1L)], units = "secs")
@@ -385,8 +385,8 @@ make_progression_handler <- function(name, reporter = list(), handler = NULL, en
385385

386386
class(handler) <- c(sprintf("%s_progression_handler", name),
387387
"progression_handler", "calling_handler",
388-
class(handler))
389-
388+
class(handler))
389+
390390
handler
391391
}
392392

0 commit comments

Comments
 (0)