Fix - not all images were encoded as dataURIs

HenrikBengtsson · HenrikBengtsson · commit ca7f6a7eebac · 2020-04-16T17:25:57.000-07:00
diff --git a/R/handler_void.R b/R/handler_void.R
@@ -12,7 +12,7 @@
 #' }}
 #'
 #' @details
-#' This progression handler give not output - it is invisible and silent.
+#' This progression handler gives not output - it is invisible and silent.
 #'
 #' @export
 handler_void <- function(intrusiveness = 0, ...) {
diff --git a/R/vignette_engine.R b/R/vignette_engine.R
@@ -22,17 +22,18 @@ register_vignette_engine_during_build_only <- function(pkgname) {
                                         smart = FALSE,
                                         extensions = "table",
                                         normalize = FALSE)
-
-      ## Embed images as <img src="data:img/png;base64...">
+      
+      ## Embed images as <img src="data:image/png;base64...">
       mimes <- list(
         gif = "image/gif",
         jpg = "image/jpeg",
         png = "image/png",
         svg = "image/svg+xml"
       )
-      for (kk in seq_along(mimes)) {
-        mime <- mimes[[kk]]
-        pattern <- sprintf('(.*[ ]src=")([^"]+[.]%s)(".*)', names(mimes)[kk])
+      html <- unlist(strsplit(html, split = "\n", fixed = TRUE))
+      for (ext in names(mimes)) {
+        mime <- mimes[[ext]]
+        pattern <- sprintf('(.*[ ]src=")([^"]+[.]%s)(".*)', ext)
         idxs <- grep(pattern, html)
         if (length(idxs) == 0) next
         for (idx in idxs) {
@@ -41,7 +42,7 @@ register_vignette_engine_during_build_only <- function(pkgname) {
           html[idx] <- gsub(pattern, sprintf("\\1%s\\3", uri), html[idx])
         }
       }
-        
+
       ## Inject HTML environment
       html <- c("<!DOCTYPE html>",
                 "<html lang=\"en\">",
diff --git a/man/handler_void.Rd b/man/handler_void.Rd
