Better support for tag-only releases

Signed-off-by: Matthew Ballance <matt.ballance@gmail.com>

Author: mballance

src/ivpm/pkg_types/package_gh_rls.py

@@ -20,6 +20,7 @@
 #*
 #****************************************************************************
 import os
+import fnmatch
 import httpx
 import json
 import re
@@ -89,20 +90,45 @@ def update(self, update_info):
         else:
             return self._update_normal(update_info, pkg_dir, file_url, forced_ext)
 
+    def _repo_base_url(self):
+        """Return the base GitHub API URL for this package's repo."""
+        github_com_idx = self.url.find("github.com")
+        return "https://api.github.com/repos/" + self.url[github_com_idx + len("github.com") + 1:]
+
+    def _fetch_tags(self):
+        """Fetch tags from GitHub API and normalize them to release-like dicts."""
+        tags_url = self._repo_base_url() + "/tags"
+        resp = httpx.get(tags_url, follow_redirects=True)
+        if resp.status_code != 200:
+            return []
+        tags = json.loads(resp.content)
+        # Normalize tags to look like release dicts so existing version-selection
+        # logic can be reused.  Tags only provide source archives, no binary assets.
+        normalized = []
+        for t in tags:
+            normalized.append({
+                "tag_name": t["name"],
+                "prerelease": False,
+                "assets": [],
+                "tarball_url": t.get("tarball_url"),
+                "zipball_url": t.get("zipball_url"),
+                "_is_tag": True,
+            })
+        return normalized
+
     def _resolve_release(self):
         """Query GitHub API and resolve the release and asset to download.
         
         Returns:
             Tuple of (rls_info, rls, file_url, forced_ext)
         """
-        github_com_idx = self.url.find("github.com")
-        url = "https://api.github.com/repos/" + self.url[github_com_idx + len("github.com") + 1:] + "/releases"
-        rls_info = httpx.get(url, follow_redirects=True)
+        releases_url = self._repo_base_url() + "/releases"
+        rls_info_resp = httpx.get(releases_url, follow_redirects=True)
 
-        if rls_info.status_code != 200:
-            raise Exception("Failed to fetch release info: %d" % rls_info.status_code)
+        if rls_info_resp.status_code != 200:
+            raise Exception("Failed to fetch release info: %d" % rls_info_resp.status_code)
 
-        rls_info = json.loads(rls_info.content)
+        rls_info = json.loads(rls_info_resp.content)
 
         # Select release per version specification
         rls = None
@@ -113,19 +139,40 @@ def _resolve_release(self):
                 rls = r
                 break
             if rls is None:
-                raise Exception("Failed to find latest release (prerelease=%s)" % self.prerelease)
+                # No formal releases — fall back to most recent tag
+                tags = self._fetch_tags()
+                if tags:
+                    rls = tags[0]
+                    rls_info = tags
+                else:
+                    raise Exception("Failed to find latest release (prerelease=%s)" % self.prerelease)
         else:
             rls = self._select_release_by_version(rls_info)
             if rls is None:
-                raise Exception(f"No release matches version spec '{self.version}' (prerelease={self.prerelease})")
+                # Not found in releases — try tags
+                tags = self._fetch_tags()
+                rls = self._select_release_by_version(tags)
+                if rls is None:
+                    raise Exception(f"No release or tag matches version spec '{self.version}'")
+                rls_info = tags
 
         # Determine file to download
         file_url = None
         forced_ext = None
 
         assets = rls.get("assets", [])
         if self.file is not None:
-            raise NotImplementedError("File specification not yet supported")
+            # Filter assets to those whose name starts with the basename or matches it as a pattern
+            filtered = [
+                a for a in assets
+                if (lambda nm: nm.startswith(self.file) or fnmatch.fnmatch(nm, self.file))(
+                    a.get("name") or os.path.basename(a.get("browser_download_url", ""))
+                )
+            ]
+            if not filtered:
+                names = [a.get("name") or os.path.basename(a.get("browser_download_url", "")) for a in assets]
+                raise Exception(f"No assets matching basename '{self.file}' found in release. Available assets: {', '.join(names)}")
+            assets = filtered
 
         # If source=true, skip binary detection and go straight to source
         has_binaries = self._has_binary_assets(assets) if not self.source else False

test/unit/test_gh_rls.py

@@ -190,5 +190,49 @@ def test_os_specific_packages(self):
                 f"Expected OS-specific package error, got: {error_msg}"
             )
 
+    @unittest.skipUnless(_check_github_api_available(), "GitHub API rate-limited or unavailable")
+    def test_tag_fallback_latest(self):
+        """Test that gh-rls falls back to tags when a project has no formal releases."""
+        # OpenROAD-flow-scripts uses tags but not formal GitHub releases
+        self.mkFile("ivpm.yaml", """
+        package:
+            name: gh_rls_tag_fallback
+            dep-sets:
+                - name: default-dev
+                  deps:
+                    - name: orfs
+                      url: https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts
+                      src: gh-rls
+                      version: latest
+                      source: true
+        """)
+
+        self.ivpm_update(skip_venv=True)
+
+        pkg_dir = os.path.join(self.testdir, "packages", "orfs")
+        self.assertTrue(os.path.isdir(pkg_dir), "orfs package directory missing")
+
+    @unittest.skipUnless(_check_github_api_available(), "GitHub API rate-limited or unavailable")
+    def test_tag_fallback_exact_version(self):
+        """Test that gh-rls finds a specific tag when it is not a formal release."""
+        self.mkFile("ivpm.yaml", """
+        package:
+            name: gh_rls_tag_exact
+            dep-sets:
+                - name: default-dev
+                  deps:
+                    - name: orfs
+                      url: https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts
+                      src: gh-rls
+                      version: 26Q1
+                      source: true
+        """)
+
+        self.ivpm_update(skip_venv=True)
+
+        pkg_dir = os.path.join(self.testdir, "packages", "orfs")
+        self.assertTrue(os.path.isdir(pkg_dir), "orfs package directory missing")
+
+