Make sure that a column is provided in stack frames

Author: fwcd

adapter/src/main/kotlin/org/javacs/ktda/adapter/DAPConverter.kt

@@ -33,7 +33,8 @@ private typealias InternalException = org.javacs.ktda.core.exception.DebuggeeExc
  * using ObjectPools and ids.
  */
 class DAPConverter(
-	var lineConverter: LineNumberConverter = LineNumberConverter()
+	var lineConverter: LineNumberConverter = LineNumberConverter(),
+	var columnConverter: LineNumberConverter = LineNumberConverter()
 ) {
 	val stackFramePool = ObjectPool<Long, InternalStackFrame>() // Contains stack frames owned by thread ids
 	val variablesPool = ObjectPool<Unit, VariableTreeNode>() // Contains unowned variable trees (the ids are used as 'variables references')
@@ -78,7 +79,7 @@ class DAPConverter(
 		id = stackFramePool.store(threadId, internalFrame)
 		name = internalFrame.name
 		line = internalFrame.position?.lineNumber?.let(lineConverter::toExternalLine) ?: 0L
-		column = 0L
+		column = (internalFrame.position?.columnNumber ?: 1).let(columnConverter::toExternalLine)
 		source = internalFrame.position?.source?.let(::toDAPSource)
 	}
 

adapter/src/main/kotlin/org/javacs/ktda/adapter/KotlinDebugAdapter.kt

@@ -57,6 +57,9 @@ class KotlinDebugAdapter(
 		converter.lineConverter = LineNumberConverter(
 			externalLineOffset = if (args.linesStartAt1) 0L else -1L
 		)
+		converter.columnConverter = LineNumberConverter(
+			externalLineOffset = if (args.columnsStartAt1) 0L else -1L
+		)
 
 		val capabilities = Capabilities()
 		capabilities.supportsConfigurationDoneRequest = true
@@ -395,6 +398,8 @@ class KotlinDebugAdapter(
 		val exception = id?.let { exceptionsPool.getByID(it) }
 		ExceptionInfoResponse().apply {
 			exceptionId = id?.toString() ?: ""
+			description = exception?.description ?: "Unknown exception"
+			breakMode = ExceptionBreakMode.ALWAYS
 			details = exception?.let(converter::toDAPExceptionDetails)
 		}
 	}

adapter/src/main/kotlin/org/javacs/ktda/core/exception/DebuggeeException.kt

@@ -1,6 +1,7 @@
 package org.javacs.ktda.core.exception
 
 interface DebuggeeException {
+    val description: String
     val message: String?
         get() = null
     val typeName: String?

adapter/src/main/kotlin/org/javacs/ktda/jdi/exception/JDIException.kt

@@ -12,6 +12,13 @@ class JDIException(
 
     override val fullTypeName: String by lazy { type.name() }
     override val typeName: String? by lazy { fullTypeName.split(".").last() }
+    override val description: String by lazy {
+        type.methodsByName("toString")
+            .firstOrNull()
+            ?.let { exception.invokeMethod(thread, it, emptyList(), 0) }
+            ?.toString()
+            ?: fullTypeName
+    }
     override val message: String? by lazy {
         type.methodsByName("getMessage")
             .firstOrNull()